From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6148376494 for ; Fri, 26 Jun 2026 11:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782471869; cv=none; b=XLyPkvg59LezPvwIqGjq9aM5DDAVkY2ALP0uRY4PG4r7MkEAwgDYahMAFrwDTE1U0ABMCly0G0C8VbUk4z2mM2QRik4znMjSLCld3TcpAZFXmEdkovbNgGs1it5TOr46MUR46U7cGBYJK2s9f9TJpA9Ou1tMFE+YGQ8ZD+M/w18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782471869; c=relaxed/simple; bh=IFfo2PqVhs4LB9en5ZOxT2gnMExm7F4Cs1+p9+ZsBqQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SnpHsNQ8IigyJpeFtPglNr5s7hKoUpZruco7CQG4VPZWUxjglu8BLLjWDM+RJDkxBUBLPp7NUw3AEHHsZ9Qs1TAqY1rpAP4madKdAxaf5XP7SkxmZuaqNGj583E01jhSxcLO4QJe8ffaQ0Ctd24NPIMhyJHI4k7KQU5aemWMEyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kH8OzdwV; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kH8OzdwV" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-139986373b8so1113881c88.0 for ; Fri, 26 Jun 2026 04:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782471868; x=1783076668; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Omn/hVFEp8NRB7W9LBODAywOnRWJWEvbpZswLa0+Wpg=; b=kH8OzdwVR+0+XS3MXnd5m66S75FxbYByxOLuaKzpGRFQjkzlrpKCJK9OIasWGqI1GL eImqUJmq/pcBIDv9JXCnVxfdrYBv9DrYnN/2GmIWmCT2gJSAs3fVcqdVvmnVwjqLhplE +VMArd99Oko/hC+ciQe9GF+ns8yE14NxgHbicD1Ye/Alj7o7u/vGZ1Tr24l3+aVM6MdP 1jSgYfZ93uoWYrvmyAFjfUFxPoIBKDH44q09bsi0PMEGctej4iz+J84G5DOqRW7vzA3c SF56KVYB08Iu6ZJt2msal5x9U8LeXywyP/aIUWZqixghEe8NEzcyur9EyzHKTocbKLvS tKQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782471868; x=1783076668; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Omn/hVFEp8NRB7W9LBODAywOnRWJWEvbpZswLa0+Wpg=; b=WxEjIrOmvcmpCRqCz3HX8mZhIPKovgdacAgWeBr7XaBQP0iIMfYSk1WCJipjwbQng5 jM17l/z7sXnydOAxVnjcfmJXS8qc/qrYyQC5b/GiTY3bsrg1xBF5SCGKTB+p9dX8g+Ny 6LOdaH3Qxug5J/mz4sKrH6Vx2mB77NOX2F2ffBDyHEsye6RUAV/0PwyRzWvml3ArZTHZ 4lNAbblPwKMvSLp627GUloLjiUN7rpbI04CXLH+m50YlwNZAUAdIkwclbXbtOEMlr8AQ G7Jgy4DewT8jkfIbV1H9d9uJ04XtgQF93T1I5LQT3bo0H5hCngEyVH6fBjrN20AIk8E4 oABA== X-Forwarded-Encrypted: i=1; AFNElJ+lSlBmZBRf0/jwm68BLlz0kP0SK8bcO5EA9B2jQV/WyR6vkoamhqg3wg/YaAR0yaeLVGZh56RDLx9GiK8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+cK2mKMs7l80rY4lFyRA6Ppgj1dD8c3N/KntDVRtV4Uwvo7K+ ezNvY2riMBFBWrfC+a9rO7bhpeyrPGXX4UgJ4Zl03k8/nWXW8wv6uaim X-Gm-Gg: AfdE7ckW9muoAk990CeggTasn1gnOHMVV0O8oaHX3T4ag4E87xEEbPLsuz5flS7a9yo ckkRw2lgPdCq3vVhw9wncwwy9FjRxiWJl+aAmgUu2nG3RQXt2E2rXzNp/Mzy4uFRDaqgG8s2nci i5WwbFCsrKz4ihy2kt55AMYAZISzTAtagu1+kakXRjnUJn9HlAmIkvkT4dM11CeKmPU+kH1HBT3 fpkx+yR/zoCx0sdGQT1kz34oHNC7JVnvQg5Ihdvqg9Xft7iIssAa+0TMCZDfNl9a/BltdOJmJHK /vlY2TGKVWVJCUg8LRFkwL0r4xi2LWN0tZzMiOqT7LCLoKBwNjY6gmiy1NwEJW+PbGzqgMX0j86 NNk0/1K5OBxBFAI/ADN0zXI5DX3lyemUQpj4m/so9pDfPtgt1d82tFBQEuDkvrSdM3zC0JHgisz vtWd+z9FaqRxbW4b5New9Fwo4acQjhHpYZEHCZVE/NsrbCnHwGYcaR86gRRbxMdq0zmHO5/xphQ v/oXoZTKbchsYog3nWnh0A= X-Received: by 2002:a05:7022:110:b0:138:407c:1d1a with SMTP id a92af1059eb24-139dbbd5ad3mr5578817c88.38.1782471867586; Fri, 26 Jun 2026 04:04:27 -0700 (PDT) Received: from MacBookPro.tail792e28.ts.net ([2401:4900:1c17:d4b4:14f2:a68e:e644:dca4]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-139d8f6d2e4sm17171357c88.7.2026.06.26.04.04.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 26 Jun 2026 04:04:27 -0700 (PDT) From: Shardul Deshpande To: Jonathan Cameron , Javier Carrasco Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Shardul Deshpande Subject: [PATCH] iio: light: veml6075: fix UV index reported at half value Date: Fri, 26 Jun 2026 16:34:00 +0530 Message-ID: <20260626110400.68885-1-iamsharduld@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit veml6075_get_uvi_micro() normalises the UV index for the configured integration time by dividing the summed, responsivity-weighted UVA/UVB components by the integration-time scale factor relative to the 50 ms base case (which is returned undivided). The supported integration times are 50, 100, 200, 400 and 800 ms, i.e. the register field index int_index in 0..4 selects (50 << int_index) ms, so the correct scale factor is 2^int_index == (1 << int_index). The code instead divides by (2 << int_index) == 2^(int_index + 1), which is twice the correct value. The reported UV index is therefore half of the true value for every integration time except 50 ms (handled as a separate case). As the driver powers up with VEML6075_IT_100_MS, the UV index is reported at half value out of the box. Divide by (1 << int_index) instead; this also matches the undivided 50 ms case (1 << 0 == 1). Fixes: 3b82f43238ae ("iio: light: add VEML6075 UVA and UVB light sensor driver") Cc: stable@vger.kernel.org Signed-off-by: Shardul Deshpande --- drivers/iio/light/veml6075.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/veml6075.c b/drivers/iio/light/veml6075.c index 59187244a..af71df69f 100644 --- a/drivers/iio/light/veml6075.c +++ b/drivers/iio/light/veml6075.c @@ -244,7 +244,7 @@ static int veml6075_get_uvi_micro(struct veml6075_data *data, int uva_comp, case VEML6075_IT_200_MS: case VEML6075_IT_400_MS: case VEML6075_IT_800_MS: - return (uvia_micro + uvib_micro) / (2 << int_index); + return (uvia_micro + uvib_micro) / (1 << int_index); default: return -EINVAL; } -- 2.50.1 (Apple Git-155)