From: WenTao Liang <vulab@iscas.ac.cn>
To: akhilrajeev@nvidia.com, herbert@gondor.apana.org.au,
davem@davemloft.net, thierry.reding@kernel.org,
jonathanh@nvidia.com
Cc: linux-crypto@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, WenTao Liang <vulab@iscas.ac.cn>,
stable@vger.kernel.org
Subject: [PATCH] fix: crypto/tegra: tegra_se_host1x_submit: timeout path leaks host1x_job reference
Date: Fri, 26 Jun 2026 20:14:53 +0800 [thread overview]
Message-ID: <20260626121453.35043-1-vulab@iscas.ac.cn> (raw)
When host1x_syncpt_wait returns a timeout error, the function returns ret
directly without calling host1x_job_put(job). The job reference acquired
by host1x_job_alloc is properly released on all other error paths via the
job_put label but is missing on the timeout path.
Cc: stable@vger.kernel.org
Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
Signed-off-by: WenTao Liang <vulab@iscas.ac.cn>
---
drivers/crypto/tegra/tegra-se-main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/tegra/tegra-se-main.c b/drivers/crypto/tegra/tegra-se-main.c
index eb71113ed146..7fbf69236ff2 100644
--- a/drivers/crypto/tegra/tegra-se-main.c
+++ b/drivers/crypto/tegra/tegra-se-main.c
@@ -180,6 +180,7 @@ int tegra_se_host1x_submit(struct tegra_se *se, struct tegra_se_cmdbuf *cmdbuf,
MAX_SCHEDULE_TIMEOUT, NULL);
if (ret) {
dev_err(se->dev, "host1x job timed out\n");
+ host1x_job_put(job);
return ret;
}
--
2.39.5 (Apple Git-154)
next reply other threads:[~2026-06-26 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 12:14 WenTao Liang [this message]
2026-06-26 15:07 ` Akhil R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260626121453.35043-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=akhilrajeev@nvidia.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jonathanh@nvidia.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®