[PATCH] fix: firewire: report_lost_node: unconditional fw_node_put after conditional fw_node_event causes excess put

[WenTao Liang <vulab@iscas.ac.cn>]

report_lost_node unconditionally calls fw_node_put after fw_node_event,
  but fw_node_event does not unconditionally acquire a reference. Since
  for_each_fw_node already holds a reference on the node during traversal,
  the extra fw_node_put over-decrements the refcount. The sibling callback
  report_found_node does not call fw_node_put, confirming the extra put is
  erroneous.

Cc: stable@vger.kernel.org
Fixes: 3038e353cfaf ("firewire: Add core firewire stack.")
Signed-off-by: WenTao Liang <vulab@iscas.ac.cn>
---
 drivers/firewire/core-topology.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/firewire/core-topology.c b/drivers/firewire/core-topology.c
index bb2d2db30795..49820e4a34ff 100644
--- a/drivers/firewire/core-topology.c
+++ b/drivers/firewire/core-topology.c
@@ -298,7 +298,6 @@ static void report_lost_node(struct fw_card *card,
 			     struct fw_node *node, struct fw_node *parent)
 {
 	fw_node_event(card, node, FW_NODE_DESTROYED);
-	fw_node_put(node);
 
 	/* Topology has changed - reset bus manager retry counter */
 	card->bm_retries = 0;
-- 
2.39.5 (Apple Git-154)