From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 838DE3FD14D for ; Fri, 26 Jun 2026 16:35:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782491727; cv=none; b=RZTfoZr6CvEb1HZiQqlZ7ii412AEQkyLO3eHX0hNsnUIkXzTsW0qXEsTCyR/cm4+LvJX3ayzHRmPOiqrPLIFqI9MhJNkP1RQFuEgVJrMf7z+cbBjfEEbdORsHfHMvm0o5EUnsbrcSfbI7KUuVSdAYSMdtQchFptxeXL2NJ++gvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782491727; c=relaxed/simple; bh=G0ur+VGsK5u8uehJUY577XPYpSiXqEDgqalyWKWqXew=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GDPLPK7cXyRpr0alJ8LJTCkfedGY6NiJoz2pkJjsQgTdvNMNs8uPQEIPLGRsJ6jGHeO6F0WQnXmqS/9Qdet2dLI/9fnG6QFAQDh4Boy616LkotYPgZEtC07irG4bfaOgYdd+8r3A2fiC8p/puK4Hr+cZmVZuNr7gLF7fnl6rSl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ImNjInA5; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ImNjInA5" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4923fb1f095so11528675e9.1 for ; Fri, 26 Jun 2026 09:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782491723; x=1783096523; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/9JIf9OJEzVS6CWv1FSk8ReHN3mioJ8+p1Xh5mgkJRk=; b=ImNjInA5iKioWKD+XL+xYCLmU7oLyGLf25sa+a19d17uFXgl9+atFON9qKpenByXne VKaI/Oi6oWkeM35rcLzmDSD1QytduBqaKSOd3H2iR0b/K8QAtXZGEn4mzD5n3j6TMLV2 A0FkOJPlBc/ClIXvxcW+U+gY3xgBwKoY3ehV7P56MajuvzcxC1zRjezzLBZ/WhGozvcj Q5L8gcsmCGXHtFTpjwhKXVl9RuLbi3BJ2was23bzqwoo+xcloBBcrt1PJlhqdXs4PTC3 PgIGiFzb1QphOzS7UAu1siRgMMyMQB1I4gK0I68wpmjHcpKmQIaMHzIyqnPjU84BsS5j zR7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782491723; x=1783096523; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/9JIf9OJEzVS6CWv1FSk8ReHN3mioJ8+p1Xh5mgkJRk=; b=LcjYzVxsKaVOuoNJgZY/Q7PQHqeE//48CbWLwfqcZLyBksD3dnPEMwapiWfUAZ3nW0 y0ZXMP3oclrlz8HK1x1GuPJTAE9qbgpBUeU5fflHV8OHBgFDQP8ezeg34W6BTxS8ReqG AQD4/p91GRwRfhOhCoYjFI7ElD3Gv6u1JX55nYZBA+T+YvjfhphqIMi51xXQAOVcdkG9 pdMVkEk6blgz7HtGWq+kFFWr7VddpfG9QmfuXu+VcJ/gq9bmr6f9FJ+1/SJRTTu5YcA7 N8Bjppz6kDvQ09RSfsOXXhQOJ76LsDsVOsbyWHnfTCmaKTP4tFmytlWIJz0iOV9N77B5 QwCw== X-Forwarded-Encrypted: i=1; AFNElJ/r2FAwXYY4zYQrkAEvTxhFWMZIHELKbXMxFwVt40jdxzlNLXG36Rgl84EXhAErZ+7YyG8mP4t6dCtOXco=@vger.kernel.org X-Gm-Message-State: AOJu0YylN1KMBrUsT/X8/9UyhbnyxTyfXj5Y/c1TSyHl82qqlbO2nehI SQWJBewLpZUJwoj8Q7iUO2yEGacr/3AVmPVCQ7okhHoEPN/rAUdE+5bq X-Gm-Gg: AfdE7cmTrg+noSWjw3/RzysnnOfU6EoWJKHDAHPlXp56ne9w1cRFHIld+jmKoaY6fMa 4yC/5m/AEpnMzUl6R8uhdfICi3vJ58xK6UrchxkXypw2aAz22O0UYSxSyR5xOMZ7W3XTtPbkrRK bg9gCQNQ/isY6EUh+F/o+KtqZUscj/7wmpJljIkIix0EpQO5vHFRXU74aLsgXl606mcRMq7TeJt HD6lufPY53IYiUyDC41SIaEFryr0t7NAFIeIZ6FylDJfyHlrgS1efjaoBvol3OTy8UNTCV6ngtL vpDFA6vDLIbLeXvpy7X2u4k9dJXO204osZiEI315QrzGoqT0slJHIoIZguxM7asRdKLvrWIiL2n EDJLB7zGWMI4DA2BulgTL/L24yLp/F8XmgtPxMRhwtP4j85/QYTScUBM8DoBSQi6cUIBeDVk7Ei 0mO8idWSbtqURuWJYtgCLHyCqLo3dme28BDa9GwlufIYKe6zmoykyysNxRn7GykwKM+CiE4I8UH wJDSPReItEbx0/qZA== X-Received: by 2002:a05:600c:34ca:b0:492:58d6:2565 with SMTP id 5b1f17b1804b1-4926689dfe6mr106861335e9.25.1782491722478; Fri, 26 Jun 2026 09:35:22 -0700 (PDT) Received: from localhost.localdomain (ip-89-176-136-191.bb.vodafone.cz. [89.176.136.191]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49269071e49sm89894875e9.10.2026.06.26.09.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 09:35:21 -0700 (PDT) From: Petr Wozniak To: maxime.chevallier@bootlin.com, olek2@wp.pl, linux@armlinux.org.uk, andrew@lunn.ch, hkallweit1@gmail.com Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, bjorn@mork.no, kabel@kernel.org, Petr Wozniak Subject: Re: [PATCH net v4 2/2] net: phy: mdio-i2c: defer RollBall bridge probe to PHY discovery Date: Fri, 26 Jun 2026 18:35:19 +0200 Message-ID: <20260626163519.10678-1-petr.wozniak@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260624084814.20972-3-petr.wozniak@gmail.com> References: <20260624084814.20972-3-petr.wozniak@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Maxime Chevallier wrote: > I finally got time to test this with a RollBall module, and I > confirm what Aleksander says, the RollBall module's PHY doesn't > get detected even with this patch. It does work on v7.0 though, > so before the bridge probing was introduced. Thanks a lot for taking the time to test, Maxime - and Aleksander for the original report. That settles it: the deferred-probe approach in patch 2/2 doesn't actually restore genuine RollBall PHY detection, and as you both confirm it worked before 8fe125892f40 introduced the bridge probing. Sashiko's static review flagged the same thing (the probe bypasses the PHY discovery retry loop for slow-initializing modules), so the static analysis and the two hardware reports all point at the same flaw. I only have RTL8261BE-based copper modules here, not a genuine RollBall one, so I can't develop and verify a proper slow-init timing fix (module_t_wait / a retry that waits for the bridge) without the hardware to test against. Given that, my suggestion: - Please drop patch 2/2 from the series. - Since 8fe125892f40 regressed genuine RollBall detection and the deferred probe doesn't restore it, I think the cleanest fix is to revert 8fe125892f40. I'm happy to send that revert if you'd prefer. The 5-minute RTL8261BE probe loop it was addressing is handled in our downstream tree, so reverting it upstream is fine on our side. - Patch 1/2 (the mii_bus leak fix) is independent of all this and already has Reviewed-by from Maxime and Larysa - it would be good to take that one regardless. I can resend it standalone if that's easier. A proper fix covering slow-firmware modules really needs a genuine RollBall module to validate, so it's better owned by someone who has that hardware - happy to help review. Thanks again, Petr