From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE24E3939CE for ; Sat, 27 Jun 2026 11:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782559337; cv=none; b=pNt6J16oYgP0u9N5XmwJJAiy9ZEY2/9w9I2DqdfF6tC+1WIe9hXSNf4KeaJaAM1HfFaa+2JIROUwa8sCXqGoZePolr9HpasfstlMFY2mzp27jj4a4U5pIZKl9Bb7hOVnnRIC3eBbteqfgBW2HcYQcKIT8Pxyz/tu030Wi/ep3qs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782559337; c=relaxed/simple; bh=ZT/PZtgzdYRy73XPl/aMR13wYjd5GdwxwhY+llB5HPQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=sN23WWMkiO2aOEH1NwHEuPnfpfNqH1a+eBUf9aJ7RLTJSf3D284tCMDtv4Y+swkAt0RuTYBKhXz9hkQxOQ3my1ILb7ZdtKFhwVb2ZLVHt+VKAVemihhRwBcE3gOjo5PkQc6sN2vm7XGhZYjiBZMN/+aWlfsofPCKCpST4nwXChQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HcQrRhMw; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HcQrRhMw" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-30c965eab27so2148332eec.0 for ; Sat, 27 Jun 2026 04:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782559336; x=1783164136; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LMRgtKqlNRIjgH8R3D1T5Dz4r8PEuj4RA5dDt7dU0ek=; b=HcQrRhMwvSYam7mQCwcSzigvBaMw9j20dVZ/FuWSu6avhFjD6Iav0cXWor1ZqucbAQ 6wGTDDSs9grIKwX/6b/9IRbabo6oiTEdvKq8KJiAPLtgxMG9FtCZnXF59AFAq3Ayd04/ lMuydaIMWkV7gpjMSJLjJ1hwA68BtQbEfcDRWM7LpLtmNDPf1nlebr5TK0iiwOOrOi66 kfzQcOdeWqUegxCfcKUXmu3eSOVqGFpdL/sjNmMqwRfgJhEnJIufu5c+MkDnZrWtwwvw O+rM5kNQk8zXylfVDrVvHy+bvz9jyfHBFcCPu7ECw5RhFNw7VydG7HQ0kDGTFA3V74zM Rv4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782559336; x=1783164136; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LMRgtKqlNRIjgH8R3D1T5Dz4r8PEuj4RA5dDt7dU0ek=; b=rgjiGD4u4PTpybFbdEVJLsb3fq1nIcm5spZWfxOryp1lIlnOSHJLPauda/1FSIE7rH gASV8lQFaTxDoZ0Th+p1DvmNvu1JDtRk2lj0yINNUfGW7/5nbmtVzmgDpmAj6S4EcYlo WPUFkNC54VdzzJFsF8pmNq2jUmS96UTg4LNWKbSO87kW+EuCGaHtbH9QE6xu4wB9Z3WK 9MEcB4fM+m6JRzT5sTusFogc5bYmnBm5rRalM03WtGbLAlWLzG7OSrLLoCZ1N+T9wTE5 rfMwowloCMpl4+TyT9f/UjG16UfAGtnHgS1PZu1MBeMnbLMb4Impk/iJFBbl4aPOsb5R aiNw== X-Forwarded-Encrypted: i=1; AHgh+RoY4rF9wk0ivrK6mCVaqgapi1q/rZM0t4bfn/5qLf5sdgMM2JBdo/tu/2iVScWxcIM6moYW1IyzxMBCbbQ=@vger.kernel.org X-Gm-Message-State: AOJu0YypoEvJBukkP9JASsNIXgZXjBF/0UwmUs858etpMuzEsj/pIyqn AL1Z1ZYZWceuHHh9O0gUSH4JUdjPdejLDkJibtWJ1JLCk4DZG28PUN9O X-Gm-Gg: AfdE7clnws+PnEDr3J7pZNdYLGM8/pd/1/QzeNsET7GP01Z9IEvLbitI5TDTewjrAbU 3jEPTJg8LKH/cIA3mh57GygnyB4HO7a62sAV7O23vaMxiUelxX78uo7H2AOs19Z4a3Nk2Exdsi0 JUuAFkmyyE0XXwW62ymE2PGZP30YyL4rvrzNiHcirqSyEL2M7eprcfwfHSxaEpC58BzGwqxMfXO 8HrKsb/A2LLDplLSEvczCkPu397FKmfRC8ru/aB4w8rDkr0sYwQ21RbyAHGU3TQRxkXeJp3kfUJ bU7km0/V0fdrBHTmFleuTiCZiNH2v/VpayyVxCis+Zb1zNRgnFjZSb/ec1zA0NTUyPyJuMN5jNC hsAFvv4dBsD4QNaHOxRqDg/Wb8tvrZaHAu0h3fCFkTAoI12MODsKAoclIg7fRPr0NT6qL5ccvZd 7IwTXb6N0BGEalShdwFgE5JJmgMYMK8LXbhQlIHof9j5bmo/gj65nBngz9+NUeANIDuAhHhVahH dns X-Received: by 2002:a05:7300:6dac:b0:30c:9f31:b631 with SMTP id 5a478bee46e88-30c9f31c2f3mr5761269eec.33.1782559335623; Sat, 27 Jun 2026 04:22:15 -0700 (PDT) Received: from moksh-Nitro-ANV15-51.. ([45.118.104.214]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7c58831asm29719037eec.13.2026.06.27.04.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jun 2026 04:22:14 -0700 (PDT) From: Moksh Panicker To: jic23@kernel.org Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com, dlechner@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, skhan@linuxfoundation.org, Moksh Panicker Subject: [PATCH] iio: adc: ad7779: Initialize completion before requesting IRQ Date: Sat, 27 Jun 2026 11:22:05 +0000 Message-Id: <20260627112205.31409-1-mokshpanicker.7@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit init_completion() is called after devm_request_irq() in ad7779_setup_trigger(). If the IRQ fires before init_completion() runs, the completion is in an undefined state. Move init_completion() before devm_request_irq() to ensure the completion is ready before the IRQ handler can signal it. Fixes: c9a3f8c7bfcb ("drivers: iio: adc: add support for ad777x family") Cc: stable@vger.kernel.org Signed-off-by: Moksh Panicker --- drivers/iio/adc/ad7779.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7779.c b/drivers/iio/adc/ad7779.c index 695cc79e78da..db8f5f4c6d6a 100644 --- a/drivers/iio/adc/ad7779.c +++ b/drivers/iio/adc/ad7779.c @@ -838,6 +838,8 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev st->trig->ops = &ad7779_trigger_ops; iio_trigger_set_drvdata(st->trig, st); + init_completion(&st->completion); + ret = devm_request_irq(dev, st->spi->irq, iio_trigger_generic_data_rdy_poll, IRQF_NO_THREAD | IRQF_NO_AUTOEN, indio_dev->name, @@ -852,8 +854,6 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev indio_dev->trig = iio_trigger_get(st->trig); - init_completion(&st->completion); - ret = devm_iio_triggered_buffer_setup(dev, indio_dev, &iio_pollfunc_store_time, &ad7779_trigger_handler, -- 2.34.1