From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B460E40D58D for ; Sun, 28 Jun 2026 07:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782630106; cv=none; b=UE5ETMv06jN/KrD/nWIXi3gF6nrabbtZ4+IPvMiZABWdJQ9ZxvQ93jk2JRWjQCNQ/8267B7OoAonb33qeDWYcC3wRz7Z/3EBdkGjgJrH7/S0itX8ysZKCVBObADAiQbGCRhPcuCE6V5LO2mWvpKKDpBnOb9MfaF+g9jmjuhwaMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782630106; c=relaxed/simple; bh=yRCcfb6gzCUYAlOhUKhiJn0xpFlhZN6+77apDBYmQaY=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=iiaFl2M4A43tEh9y7wKmCeDzk5WxJF0pf/mpUsRteAKFn0aCDISVER54sieThQkNbRaEYHCATD01VC0gsmJK5u0u00Ir3Py8wMX7xP703se4/W+yTbVo9EyyNrjXlBlkloU9p57yKzyFxNGDeqh9VbE3IdDKAhto0HxU0sCAA7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rI4jd3U6; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rI4jd3U6" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-30ec3dfbcd1so221378eec.0 for ; Sun, 28 Jun 2026 00:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782630104; x=1783234904; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=P1kFhzQ1vV/uTKUMcLW22Qp/rdMXShnvpF435wRzJbM=; b=rI4jd3U6f7Yu5gvulSd8VESYJ1jkYGGE7kAfPTXCM0o2w0NxU+PF7O/WpR72x/riyV hGCEc+fcfqNqbvhAYnnLmuPZD3w71Jv5t7DbsNoMrKZu0dQ3EhVz2UT7KmW7HcbrVjU8 5jeDVEkKk+wYmT4PLnfZckYIDVCNvl66RiWI4jtPCaZmUAArrLMusRsLcYv6xAuDco8b FAVkCqGFHgcv8B6HStFpV4LLUuiJy7ouL9N3siSiDKbL8F5G6pUKfGY5IlxngnVdzFBg ivvNIhvxBuyADJfnZzGzODi3NV6g7BchJ5fkQa0LdoQRNdMvISiHzDJHzfE/YQrjQ3Ki aYpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782630104; x=1783234904; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P1kFhzQ1vV/uTKUMcLW22Qp/rdMXShnvpF435wRzJbM=; b=I1EnHQC/5b0PK8AhExNuzUO56LRgt0veiqxkrCCNTK4DZQ6WrP7jRPOFb1ybN9THcn G1LVdvygUf05f3um4S5q6AZ+BRoKlimWzfU9SmdpUjXEH9PY/2pbhqnLh59htAV43Ouq Zy3k7ZMWVWRgufEFAhe662ZhyfcRXtw7sANtXnyv8d3OZhC8gDXRjpcEsXLMTWGFk65/ S0QBPmhcVQgFZldn3opyFh8XOix9hMPHFxu71esVqtWixXUYDvk+UvYgC61J9cIyCIgH 5eibF0Al4lckNCHvF5+p0MkzxJx3TPpC++eYCPweZC9UJE2ppIq4ubyxKP0muW4S707g AkFQ== X-Forwarded-Encrypted: i=1; AHgh+Rp6dDXnBzN0PXTQKNgNkKNC5jMLlrPCbCBk3MCAypJ4asFt8E8V6jAUp7bk0//cbEXrpnc4nmukm8sgplM=@vger.kernel.org X-Gm-Message-State: AOJu0YwF+IcARjNYwtIFr4AtRcXJIfIsCt1nINuDj7zw5+GxM0bzDPes bypLsFCxRaLBDUPDdCYfDXXhdmfPYqJXImrLjAE+x7Sxys4Q0CqnecCs X-Gm-Gg: AfdE7cmYUA1WqDfghMyMBS0qW0XO6LAfqQh50qwN79JzcNF0TWMPklqj4XByYwE9qS0 l6xGv0BOq5nMh4gv3EcqTMnxa8QUJnpp5XwpQ8GUF7S3HFx6OTc76IW/r9+tgnNzTeOP1Vu91UV bCLConYNRxiURtQ/0LwZm0t7Hx31BWbUPm1L2guKA4Aoqy9ViMlQqoRIURZcuZioVNP29sHo0as zzX+gXy8lPYclCuy0nrNzIW8DoaTvfvrYtX8awsotwSNTUel5Jylxz66QdeSuvf0GnuOnmmdyB4 WAJ1irYtsO3Jowqrw20J8kdHj+Poq4z/ajC/cFoK3/dOsgPPWrRH+Q8YefWQex8V7bS7ymU36k/ xY68LtBEg7/yWoc1R62JRT7iNqFT6zFMqzA4N0t8493qvognQ0wSaWzlh/FLwp7mBTVzAf0vOQC +ZZYC/UHxK7Vdwl99gmSNRxrMmLnSb84tBgH4H7FY6yCSBVYSyURRmhYy+nmWWgXA1zrj+SmzY3 cNgBBFeWRg= X-Received: by 2002:a05:7300:503:b0:30c:a943:ea14 with SMTP id 5a478bee46e88-30ca943f3d5mr8156907eec.2.1782630103622; Sun, 28 Jun 2026 00:01:43 -0700 (PDT) Received: from [192.168.1.45] ([45.64.226.42]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7c8b1ae5sm39878489eec.16.2026.06.28.00.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 00:01:43 -0700 (PDT) From: Prashant Rahul Subject: [PATCH 0/4] staging: octeon: Improve initialization error handling Date: Sun, 28 Jun 2026 12:31:23 +0530 Message-Id: <20260628-staging-driver-octeon-panic-v1-0-fe8c34989254@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x3MMQqAMAxA0atIZgNasIpXEYfSxJollVREEO9uc Xzw+Q8UNuECc/OA8SVFslb0bQNxD5oYharBdc533g1YzpBEE5LJxYY5npwVj6ASsSaOaaKB/Aj 1cBhvcv/3ZX3fD+0ZsfZtAAAA X-Change-ID: 20260625-staging-driver-octeon-panic-2602ed8d5d67 To: Greg Kroah-Hartman Cc: Shuah Khan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Prashant Rahul X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1462; i=prashantrahul23@gmail.com; h=from:subject:message-id; bh=yRCcfb6gzCUYAlOhUKhiJn0xpFlhZN6+77apDBYmQaY=; b=owEBbQKS/ZANAwAKAWw+kajX8DhtAcsmYgBqQMbU14/8C7jz21w91Bjr5geSOjkTWV+60qkcb +M1I54Sgf6JAjMEAAEKAB0WIQRS5esR6MP3hQs0SsxsPpGo1/A4bQUCakDG1AAKCRBsPpGo1/A4 bR5QEACSkg4bJ3ts4Uac6/uNq0ITah8myM+2hZdBnllljnreG7AUbokJR7Ed2TGiF473eCmWRmq nrJMoHkyoX9+GA7iwdQN6orxVBW9p7y4+I/G0oM6wJ/1TF5Fz3e0DVUuOot34CthdsisAvVrL+8 WyLl8niKsML3+piP4m6wciNO5jCpeKsHDKwMBAHu5G1ZPdlYbxox5qdZICKCP5tXOeso9oKmqj6 FkJPHGmuytvRXKnIfqzSFiYUv3w7IeKxQbLv8QwtNsOiSHFnQaUVDIL+JBFssgHHk185gu6u3mO Xf07PJPuu9CtopqlP57mJbqra1MKX0jMdVHSbFYk3mn9oU9beE35tsLZ1NX44yUpAWHrNqvnPDu 41SifuDmeASCJceb8igp7PVI6vKCUIWNeQKHgesIvV9nZDEftrfY+wM0z0x92t8dCSNkPZ3UcRK dVRQC+d3t4f+f5Cq1O0q3KiDydOGqm+5f2bfTvl9e1NBcFTtcLh6t8dTS78RD7u2gYU9AomCPq9 v7sOxhYPhoSW3mzI6urlcYF7dnJUI6NrxLLlXUDOglWQg3okFm44lwDVw5rD/CE/mZbTN9MX6xk deVuzmZ33WHtvH4WagFkMNXick7B4MScNnc/zb5SuRU7BVApM/PqVXk/2iAaB7uWxr0ducbWLHW ceW1a7LI9wpJ6eA== X-Developer-Key: i=prashantrahul23@gmail.com; a=openpgp; fpr=52E5EB11E8C3F7850B344ACC6C3E91A8D7F0386D Hi all, The TX and RX initialization paths currently call panic() on some initialization failures. Instead, these failures should be reported back to the probe function so that it can unwind any resources acquired during initialization and fail gracefully. This series replaces those panic() calls with proper error logging, propagates the errors to the probe function, and adds the necessary cleanup to avoid leaving the driver in a partially initialized state. This is my first time working with drivers, so please let me know if I have made any mistakes. Thank you! :3 Signed-off-by: Prashant Rahul --- Prashant Rahul (4): staging: octeon: factor out device removal into a helper staging: octeon: Propagate rx initialization failures staging: octeon: Propagate tx initialization failures staging: octeon: handle rx/tx initialization failures in probe drivers/staging/octeon/ethernet-rx.c | 18 ++++++---- drivers/staging/octeon/ethernet-rx.h | 2 +- drivers/staging/octeon/ethernet-tx.c | 17 +++++----- drivers/staging/octeon/ethernet-tx.h | 2 +- drivers/staging/octeon/ethernet.c | 65 ++++++++++++++++++++++++++++-------- 5 files changed, 75 insertions(+), 29 deletions(-) --- base-commit: 4e5dfb7c84012007c3c7061126491bbc92d71bf1 change-id: 20260625-staging-driver-octeon-panic-2602ed8d5d67 Best regards, -- Prashant Rahul