From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF2421DC985 for ; Sun, 28 Jun 2026 07:01:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782630112; cv=none; b=RLt3Y3Rf218SShdWnrNVlm/3RCSNuEcI1H93zbMAbvUjWp1Xws/0l37vxe6qh/r1vcu4Sgh7jNNIw3o04xULy6UU86jJvJi8t/+SZlZ1gbTRwmutQBekY79Pvyp3/E2252vMly7iaVNYkoGU2vZrHswJ4FK9T5lfo3wnUyXL1fQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782630112; c=relaxed/simple; bh=S3WGUr8EbUDnzRnDQdiXuU7JQ5VvK/xEqOqJ6Y6XO6c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eTcnwA+uDojqtpnwT+c3HwdkbSo8IYi4laLORWhzxAC2c+9zdXAjo7HtMkeBsyPfJDdeLMMzzLH5rKGrcx+O93CUjdBUGwNgYZopFH0xvoxhH0uwQDQvKoOZZQq+T82uFvN+WituSyGKfIKdQ8m1sCXlOEymnW9POiqWQ1qiJNA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e55siP/V; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e55siP/V" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-30c591fb1cbso3584988eec.1 for ; Sun, 28 Jun 2026 00:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782630110; x=1783234910; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TXokKAA+ArLkoRHycPsFI7+9fMpYzVXji7Up+eouGtM=; b=e55siP/VptJqYwwGeKf52hwY4kLrGVnkpc92uWbG85AT40XHMogxh9CgS5eT20yUil ebtBrNXDGOMcbWzpGYMMIXpCp+ojllTEZajZjwSniTOeCM7xL9DbRwpKH0eApLDVF0nx 1GWVWnvNy37oQZ44pfS8I7ds5jscaMgzdVXYf9YcyX2mi4XuPVDIHIsCqz3Z+QNrPK4h zl+iDoKWfwq+23uBBf+PAauaBarSpF2u2tnYsOcO/ikdxZTF4c4WoodXL54MCJIvwtyU gLmjdZv7xF7KK5VBKne2q9SdEJV5k57WrAwxRiDhE4lJMxAbM+fhneVMzX5Fp1bfbtf+ U5Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782630110; x=1783234910; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TXokKAA+ArLkoRHycPsFI7+9fMpYzVXji7Up+eouGtM=; b=iDyEp0njCGUnA6yZbnxYErhIthJWuNaO/9XwRVl47yIjSANUVyWBMq6t10Kh4vdpkf zGt6b5itydbGA6AN/m9Q9lN1LNHWdFyUlAzVkLhAqDbQXri9zBizVXIaQkFsbv3PiXq+ NKrMtf9LZAY1BE4JyA3WjVqniOYz9DKIUGa5NnNrjEtVyQwSG+2rWI4No6YKYZ30zV58 CTk+j/zvZh1ivtTee+kHaVhWDBA+0b5krtEMOu4AIIoTn4FkuaMFlJxr74rjXPjcbPt7 7udH9IBLOMWyyhrCX6TT+UigmcsESi1oZNmmVgXBbVeJHawaBs/WFp7SdynKn2TIcdHR uB/A== X-Forwarded-Encrypted: i=1; AHgh+RpG1668NEVbOyTGy7KG9dbSSJvkMfttZUrwrXB5lC1PrXovNR9ARXw6g7TGgD+sU9bAxxW6uuzWLUCAceQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7GysX4E1pxai0bNf+4J4H7Jtp2KRpqL3NhFaaROz//wDNAM2l twW+NWA8MrTxkzCaW2AGC4YvV4nDU1WkOhdYYRbM5SSAliNdrZZntkqT X-Gm-Gg: AfdE7cmC2V8ctDSg2zDUgWv96xCnKCSzs3Ta4bpC1EE201FcG/hrqO1k85k+3J2CzOZ OQbqujJ1HjpTaiMMihLkXfJxSMaPR79HYRH5C6SkFODCvweFfBj2f9AFTpNR2QesYQbK5P8eMCy i0WY+WWYaUZT3kXIFK/PBqpNCslo6+FoPv558Gz2PzEtPh5pZpbd7yqFT3nye39BoRKCfydvE5W hok62kRBKtlt63r+Z8wNkgB5me/1+HVYe95xyb+mJTArvXIiU3m067smkMuDyLwHBQjgH7AGxeO EdWSJNag09ptE7ZgmCgMxSFtgQf3e8lY/EUiF4EgvT2GkoOuv99Ra9AFqt8unBHs6Ov7iyWUx0q SNd09LgL7V+KKDXFSeibCZGEEBu+IqHlynBLwZBReB8Z3MW3rJwSvP5vSshF76In+27Ys1U4Pcf a8U/e+5GcVT4Bka7QYMFZqu++hDW8h6/RrSmSXV7m7ulbRiK0u8q31O5dLF4zGwUI6TeP8DRPPB p7G6L1nc+A= X-Received: by 2002:a05:7300:4312:b0:304:df8b:71ee with SMTP id 5a478bee46e88-30c84b1dbbcmr11880558eec.7.1782630109767; Sun, 28 Jun 2026 00:01:49 -0700 (PDT) Received: from [192.168.1.45] ([45.64.226.42]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7c8b1ae5sm39878489eec.16.2026.06.28.00.01.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 00:01:49 -0700 (PDT) From: Prashant Rahul Date: Sun, 28 Jun 2026 12:31:25 +0530 Subject: [PATCH 2/4] staging: octeon: Propagate rx initialization failures Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260628-staging-driver-octeon-panic-v1-2-fe8c34989254@gmail.com> References: <20260628-staging-driver-octeon-panic-v1-0-fe8c34989254@gmail.com> In-Reply-To: <20260628-staging-driver-octeon-panic-v1-0-fe8c34989254@gmail.com> To: Greg Kroah-Hartman Cc: Shuah Khan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Prashant Rahul X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2879; i=prashantrahul23@gmail.com; h=from:subject:message-id; bh=S3WGUr8EbUDnzRnDQdiXuU7JQ5VvK/xEqOqJ6Y6XO6c=; b=owEBbQKS/ZANAwAKAWw+kajX8DhtAcsmYgBqQMbUFWyMMeHTyQti/HR7f2/My+Sb9hfniUkla yAys0Kg37iJAjMEAAEKAB0WIQRS5esR6MP3hQs0SsxsPpGo1/A4bQUCakDG1AAKCRBsPpGo1/A4 bZMYEACtuG8gzTuNLu4emvtvWLCssaiMlTqJBaXUj8w8NsLY+5GloxZxDYMY1o23bFuco74vQbH 5eRV2IWaHRLwM+ONkJ0b01zJL87p85bkNRYGJUaVoYrDIBbOXhH5BU/h6ZZ7qZ61Q1yWkeAamvo B6S4nJO+iPDlo2G++o4c7V8RZDvJTL+BcEvk1qnEC7PFdPYGiu0jDJ1nyXrC3zKjuM6pv96erAX 5bU5SrwAjy2QK6rxwBAV94q2RZa+fdjeVMaHLpaxw4WSsES4CXMpPskRics+TytZUTdHDzYNQWt BTXn2zzyAlz99bVaBUd0sAdzNwn/58KYtAzn1Bdunx/xwuVJC33fTlHRSMu+o5Gf2OrxMEDbQuP C87620IToNRVRRX3NRs+Wkgz/mMMJwgIHkSXJG1sZ3RyDJlO5MRoOfqLFIKUgVpvoVXUs+YJcic 7vz4SrQOtuGcWSlV2uHiIC5faf/jMXvsVGJL4g5PAGWI8M9D24AZQ512+YE6r5LahYqyO8N/dvj awQJ5k4WOQWV0AzK8Hi3HPplb+P3+RzbRoNAzFBBIN2JQ10sg4BpbBCqdgjAwsbp9M8GtGTaBfy HOstIyWVPARlaQRcI6F2GELWHm/QM6NGfcKFTam0vFvHLFcNmAQreICXdzwsU+qEkaXAm/PYQgi voRp8DNIXko+kgg== X-Developer-Key: i=prashantrahul23@gmail.com; a=openpgp; fpr=52E5EB11E8C3F7850B344ACC6C3E91A8D7F0386D Instead of calling panic(), log and propagate the error upwards for better error handling. Signed-off-by: Prashant Rahul --- drivers/staging/octeon/ethernet-rx.c | 18 ++++++++++++------ drivers/staging/octeon/ethernet-rx.h | 2 +- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index cd36b5ba6f6c2..66e7253d484de 100644 --- a/drivers/staging/octeon/ethernet-rx.c +++ b/drivers/staging/octeon/ethernet-rx.c @@ -5,6 +5,8 @@ * Copyright (c) 2003-2010 Cavium Networks */ +#include +#include #include #include #include @@ -445,22 +447,24 @@ void cvm_oct_poll_controller(struct net_device *dev) } #endif -void cvm_oct_rx_initialize(struct platform_device *pdev) +int cvm_oct_rx_initialize(struct platform_device *pdev) { int i; struct net_device *dev_for_napi = NULL; struct octeon_ethernet_platform *plat = platform_get_drvdata(pdev); struct oct_rx_group *rx_group = plat->rx_group; for (i = 0; i < TOTAL_NUMBER_OF_PORTS; i++) { if (cvm_oct_device[i]) { dev_for_napi = cvm_oct_device[i]; break; } } - if (!dev_for_napi) - panic("No net_devices were allocated."); + if (!dev_for_napi) { + dev_err(&pdev->dev, "No net_devices were allocated."); + return -ENODEV; + } for (i = 0; i < ARRAY_SIZE(plat->rx_group); i++) { int ret; @@ -479,9 +483,10 @@ void cvm_oct_rx_initialize(struct platform_device *pdev) /* Register an IRQ handler to receive POW interrupts */ ret = request_irq(rx_group[i].irq, cvm_oct_do_interrupt, 0, "Ethernet", &rx_group[i].napi); - if (ret) - panic("Could not acquire Ethernet IRQ %d\n", - rx_group[i].irq); + if (ret) { + dev_err(&pdev->dev, "Could not acquire Ethernet IRQ %d\n", rx_group[i].irq); + return ret; + } disable_irq_nosync(rx_group[i].irq); @@ -518,6 +523,7 @@ void cvm_oct_rx_initialize(struct platform_device *pdev) napi_schedule(&rx_group[i].napi); } atomic_inc(&oct_rx_ready); + return 0; } void cvm_oct_rx_shutdown(struct platform_device *pdev) diff --git a/drivers/staging/octeon/ethernet-rx.h b/drivers/staging/octeon/ethernet-rx.h index 6093694326cb6..ff3ed3d784a4b 100644 --- a/drivers/staging/octeon/ethernet-rx.h +++ b/drivers/staging/octeon/ethernet-rx.h @@ -8,7 +8,7 @@ struct platform_device; void cvm_oct_poll_controller(struct net_device *dev); -void cvm_oct_rx_initialize(struct platform_device *pdev); +int cvm_oct_rx_initialize(struct platform_device *pdev); void cvm_oct_rx_shutdown(struct platform_device *pdev); static inline void cvm_oct_rx_refill_pool(struct platform_device *pdev, -- 2.54.0