From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 115BF40D578 for ; Sun, 28 Jun 2026 00:14:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782605673; cv=none; b=a21VdFzWrP5BPjClkhx1kQcx/SZ10wcOY7rW2EfoTmWNKURR9UGAQuK0ag5FiaYf5miOqSHAEvLDggUFxeC+6eL73GLfnxyf3ScBFECZmeo7hbnzrvq59NjMKHZs7ZlXPExFdxK5zQ9HFuywixtM1lXxb7+w3NJdFx2xyHhEQis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782605673; c=relaxed/simple; bh=bn5D81Emdp3F9NQjebzQbfGPoc9F0nldGSqdoQJdmTg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EUBpso0nFdjkZNGLq45+g89o7GKVUuev4LOFNniFZ8vFTB7+7GuMnIap3pbtjZoqi29H2y16ic8s+T7TR/Vo78aV5vYKgh9hpVLsBZU4ST7aDF6Jimw3eZywloiUG7NOhxOFYfO7yrMjS55X3CtqBoef9xtC+MnvmrEpiyFTK/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X4vgZsiH; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X4vgZsiH" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-4624a44e152so1882843f8f.2 for ; Sat, 27 Jun 2026 17:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782605670; x=1783210470; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ebH+lK9HrTDn4Rg3W7vRRjbwOoSeOQcKiaNHs9OnUKM=; b=X4vgZsiHSmrJ+Zl3m9iPFdkxObopOdzVRz4wiU2C9qyJNK7oyhZw2YP5jUWlIX4daa reECGgG2pG0DAb8NtJFQG8+mLLxu7BgUg3MKj0hhj5T0rQfmYlswIij+9QA6nqcZ4sSs q2r4vfydOAxNAiqQMT0h8QAN/0RUck5LZzbpexLsw0/hd/08xp2G2+YLTF0kmbm26Vp9 saV4GRu84aMsFoah03+/3gfr8ZN40h+z27o31qh+53UdE2H+5DvTdccYNteEd9D9cVu6 nmiJEAT6WPOf31reQOGekA0at/mwY9KZBCXTfuwQvClzWgwMZJeisfKeckzPeVUlo7ts 3N9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782605670; x=1783210470; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ebH+lK9HrTDn4Rg3W7vRRjbwOoSeOQcKiaNHs9OnUKM=; b=Ap6OFYRFSM5REnEKnIqNBU1Z6jbfM47XcjtmZhOeaP//c++5Cy3YFUgZx2z8ziDjjE KAp4mRFb30Va2TEyeoIWIk7PDVjVu7eiX/TO8ecqzS14lwaNSLSHLSp7xl8Xct4V9ZE7 Fvb8DP8fpY3389JrAYhWeU2blFeFJRjhWisqavq0wxZ9V6HeMvB5WhTtka085evd6ClL soU2raE49WC8+eloZeCCZMOrqVwKyUXt4v6JeqZECxFK7H0bVLJgkESPNC0Go/DnTK4Z h7qJ/SBaXSbsUeAb61mhU8OYrWdXgtYTmFR9x3eqdGgLgUppc6P/8VMvBlp8e9b/7pT/ N2pQ== X-Forwarded-Encrypted: i=1; AFNElJ+XkOh6Mwqu6WF2p3IASTP+8FTJnua5jdCUIoHPfNVaXYmUSCKGlS9WpncWpFocb93Ui85TpHD01FQjskI=@vger.kernel.org X-Gm-Message-State: AOJu0YyYV3bJm48LhGgNtwOR21Xj3/x6e/fzz+Nc+85DPgZ2EbH723g1 HA4ksU/o/GgLC8Zt23i3PlK326QgD0oHr/mvPSZs+HE+gfrQU3eembkq8jqa7XXWJyE= X-Gm-Gg: AfdE7ckQa0qjxWDLVPksW7lq1kQLN4gWF3kgsiLDsHI+tarFewveY89DbhnYU1FTVJ1 /7KmR+sOrlIPZ6ESNNh1ZfIXZRdIO26BbGjEcGUhUaWFlfruAzMfwoB4vw74EexIJCma6FVnv73 s2N+GBn7uKS8KmYQw6QrIvFLOIiJPhKUlTzyoCgkv7iY/7kAa6j922ogR7E+Tr8mGsVfr5uUhJP 2zmtQoqF37O+84jHps2fbGC9L+rImi6x8eu3W7UqIFT1B3+l09cpKc+YiNR4hnhZHp3FUjz4LJl tPRBb8PksSbOfzdD4vVDpYuo3VbJEruHH8CBJWQf4G1Lv3tea6cT/wc310t7sSUo/mq1+eZL93u m4bROamaU3d/uti70JyPZdlumnB7jFN3P5Zd4omVO1i79HKL1KCfv6+gQI/Ky2w9ZR8Da2jVjVS JUVp6JCamOA4TcnQ8j9gv/s7bjeQ== X-Received: by 2002:a05:600c:3b13:b0:492:450c:57cf with SMTP id 5b1f17b1804b1-492668ad60fmr185218005e9.31.1782605670319; Sat, 27 Jun 2026 17:14:30 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4939a8279f3sm53101525e9.10.2026.06.27.17.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jun 2026 17:14:29 -0700 (PDT) From: Yousef Alhouseen To: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot+cb7ed9d85261445a0201@syzkaller.appspotmail.com, Yousef Alhouseen Subject: [PATCH] wifi: ath9k: avoid device access after async firmware request Date: Sun, 28 Jun 2026 02:13:50 +0200 Message-ID: <20260628001350.20997-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit request_firmware_nowait() may invoke the callback before the requesting context resumes. When a firmware lookup fails, the callback starts the next fallback request. That nested request can exhaust the fallback list, complete fw_done, and let disconnect free hif_dev before the parent request returns. The parent then dereferences hif_dev only to print a successful-request message. Remove that post-request access so completion cannot leave an older callback using the freed device state. Fixes: e904cf6fe230 ("ath9k_htc: introduce support for different fw versions") Reported-by: syzbot+cb7ed9d85261445a0201@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=cb7ed9d85261445a0201 Cc: stable@vger.kernel.org Signed-off-by: Yousef Alhouseen --- drivers/net/wireless/ath/ath9k/hif_usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c index 515267f48d80..aaf924cb8860 100644 --- a/drivers/net/wireless/ath/ath9k/hif_usb.c +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c @@ -1222,9 +1222,6 @@ static int ath9k_hif_request_firmware(struct hif_device_usb *hif_dev, return ret; } - dev_info(&hif_dev->udev->dev, "ath9k_htc: Firmware %s requested\n", - hif_dev->fw_name); - return ret; } -- 2.54.0