From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4769836EAA2 for ; Sun, 28 Jun 2026 07:14:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782630862; cv=none; b=jesHCIFJ1s3E0pDFgDIJxmUzkI0wzshGdviTxVJgsvZfmFeoDoi6SLgg9Rwrjv5zo8QE15Srpln3h73KpIHvfHCpTKRUc8m5OPG7RMbOc80QL8OmcMgfKgTF5TKNOj4V1IQhIShYij2R4qkhGX3AV5zAKTzWWmtDQ+57a1K19wE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782630862; c=relaxed/simple; bh=6KwVdXym8m9VmBu/yZDbGr4sR4go0nT/ImlSsY/m7K0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sn72pFWj4CLQ0vjZRB+QlAZOjxE47HUQ6NM+sp7dwgRLkpatgF3Powu1RnvEaLMejkr5TE2pkcE7KM/fmumhj8SFXrFVaBtBxLazr6vwCCCTeX3Bp/HmdLRilxg2N7mG/XzBVMr2Hy65r7n1yMhCpqrI3rfSUnBm4W3e1G18poE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VFcHIhtO; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VFcHIhtO" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-30ec3dfbcd1so227126eec.0 for ; Sun, 28 Jun 2026 00:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782630860; x=1783235660; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EJM+v6mJ9RBfgqnA3JaL3CQXECHO5LJ7tpDsIB136Js=; b=VFcHIhtO3BOBgSdZODZSh4uOSGmDwVsHHSYE8DUbaPyR70mEz7mnQ91w+6SqpdyeMK o+T19aEZkFUOp6G/DFBiD7WmTFPweqcmWKAN1D0aaTGLZBSPwY0ID4QlxwzQdGMEnfbH muRhPlgyNpX+y1m3sAiy1kn13Ur/qeXMjR5boQckjr4vtrVd84c/pUDLmobt+OpPugX0 oJxodN7CZ0C5fu8qa9ySOQLdJvqXkfbEuTQ5fqqN47Zw3dzNGCeJ5dCBFaOJyeicsWSk sGZoJID2r01JMz0OaHKUd6H+Uzj4eveZ98F56TLL4snAasOcIZrDxkrOeT2Dboc1yk40 DfcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782630860; x=1783235660; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EJM+v6mJ9RBfgqnA3JaL3CQXECHO5LJ7tpDsIB136Js=; b=P7Ne+DDGQNQER+pDJicIOylha59SeXwqhn0GUgWdgqxl7lY3j15rQeTWeVmwzaRWHq a6NCCHFmnqjyBVJ4o681zsGL3WEjSdpcZD2xo6IYqdh+Y0eGh+dQKqazY6B2+Fh0o4d1 uKfrbkcrXbYYEzGSgaAeSLzLFTnG5kouRF6h2XycWJWaaOz+Fi6wOOkyrbLKkBXdd/YL 8igxNLXj7X5Mb5XLKI52zo0LcTaq+WR4nZRMigOPVnFZDr4J2Q/C2x9j9PzbtLOJjwgX XU2GRJqtGfdI46nF3mR76c4J1rhQYw6y+53O12xdOpwjSpO/ghNiOB9d+HQO1dE5I2od REtw== X-Forwarded-Encrypted: i=1; AHgh+Ro6maqhbFO6UUjuD/YL2R3B57wR/aNJGPqiiOSIACkYmNqLRU9jhW7Pn+D2vaGf1iICotIqMf8KYer62K4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh7ejREwlMvZaVEHJHTxuxGC6+sIfzoj55GgVYPmElOVFjsTH7 0AgylqkJ2vYB0cbXwaFw+fJoqgw2wh0NN1fEGJQV5g0mrc3UGJ3Tir8C X-Gm-Gg: AfdE7cmVZOd3jiw7B3JCcjrrcqc0OmClRzFxhCjVVeYpzcxizOeoXchIdXZ4hVJn1AG kW2BMBlfZZH6uHBDX8qRjBe6MOBPlscJKyUArN4Dxp54nKf5hQ1ThwiK6tlGgt50gdjwd/W8ccv aQAzzUrgwf9EO0KZj1dKMYNNuN2LvYr26vA9DNh7nWAJ0vQgwCGcKotu0N+HVybwP4uTKmhaRqP cyGPwA2MDxZXgfNzFvQtFgz5WMDcUYm0E3/wbU5TLE4nuf3MbuqC45R1DHWvJ+yAL0ddxZkz1ZG Tegzq6vrBigGg1fb1uK/wie8e/URsCG8Qw+5d56saIbmnwKzAWmw+Yu9QsFklEz9E1Oq9arZcVL y3DjfNJmiHRQiWrZ2Nu/VBTyVxq1Ho92mN+tp9w6Wdhyuw1z3uXXflVBjwQsU8AoUAG3ERhH+/4 AYU7XuWZoX6u6hJJ94iXj7TnsCBQwE1yCRgrGdiX7rd+9UKZtY7oPuKLeJrZQMfAjP2g== X-Received: by 2002:a05:7301:4e8a:b0:303:f2fc:c483 with SMTP id 5a478bee46e88-30c84cf3f9cmr12151533eec.1.1782630860420; Sun, 28 Jun 2026 00:14:20 -0700 (PDT) Received: from moksh-Nitro-ANV15-51.. ([45.118.104.214]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7c9e9214sm34474940eec.20.2026.06.28.00.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 00:14:20 -0700 (PDT) From: Moksh Panicker To: jic23@kernel.org Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com, dlechner@baylibre.com, joshua.crofts1@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, Moksh Panicker Subject: [PATCH 2/2] iio: adc: ad7779: Remove redundant dev_err_probe() after devm_request_irq() Date: Sun, 28 Jun 2026 07:14:05 +0000 Message-Id: <20260628071405.51030-2-mokshpanicker.7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260628071405.51030-1-mokshpanicker.7@gmail.com> References: <20260627192638.5623df0e@systembl0wer> <20260628071405.51030-1-mokshpanicker.7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit devm_request_irq() already prints an error message on failure via the IRQ core, so wrapping its return value in dev_err_probe() results in a duplicate error message. Return the error directly instead. Suggested-by: Joshua Crofts Signed-off-by: Moksh Panicker --- drivers/iio/adc/ad7779.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7779.c b/drivers/iio/adc/ad7779.c index c1a99b4c1256..a5b8bfa99a74 100644 --- a/drivers/iio/adc/ad7779.c +++ b/drivers/iio/adc/ad7779.c @@ -842,8 +842,7 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev IRQF_NO_THREAD | IRQF_NO_AUTOEN, indio_dev->name, st->trig); if (ret) - return dev_err_probe(dev, ret, "request IRQ %d failed\n", - st->spi->irq); + return ret; ret = devm_iio_trigger_register(dev, st->trig); if (ret) -- 2.34.1