From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3AEA270EC1 for ; Sun, 28 Jun 2026 09:40:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782639618; cv=none; b=b2oCztiKPstv53uzAoNepnKpISbSajEEEJJx4EdkHUYUbSWMnBG7gKs+IyS6fPwzt8rfqxiFq0iRV1Zxt7PDLGDM9NB33RpDMQSkOFPEk9wkZtFuNtIY2bE2t+TgvuptIw1xWmtzKa04HVbO3kbmlyImjmelUcRfh7hvTRBMZww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782639618; c=relaxed/simple; bh=zEhabAI2O90UsNhJN+aYbI0vGc1cPHAPDwVCmpZpHDo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Y5oduXd8P92YiHyZNkaehZoBNTHlfAIRWiGJ7tz4zhaPEqW+wGuM6+MhU6DFO3eqglK2Rmo994G20BVN88LcM+m8DoZpPRp8rkmZSE5NHRkahBr5gjKlTwv7+YPlFo4TC20+JnDsNVp2MFKZOUcPMFSCMJeT2kv56QtmC75DV0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YQBPGFKF; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YQBPGFKF" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-49249707788so19330115e9.2 for ; Sun, 28 Jun 2026 02:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782639615; x=1783244415; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XP+qkIHt1FgWGwOQvENORT6XdMJYDsJDs2bi6NZ8b2Q=; b=YQBPGFKFKf0qAUaAICB1Y6tZnoIitRbxLxtjFM5FWLe1/EVQgRUByzreO8VevU3SQz 0mm2ewFJlLlFeCI4CqG9Q0Ys8uB5YrRaJc1PHVJjcXImp/5J3ZgLsASGf0YDW63zTdZa A1n3YmENCRblZu2leWHQsNBd8LVyI/SeJ+Xbl3Kc2DMzl+jOQehbBp8gAacBpki18Y/G rS1ru/sXf5LtRPCHNsGhDNUBJip+ddIeGy+SFc03JjykOu+aCLfcwtIvVlcZ3C+7UkmT pBQAV0Fd0jjff+9zPnK8oagPUSj0zn19mBpwiRXa+k3fGdVUGym1QP6aGh2TfyQFBvUV n7eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782639615; x=1783244415; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XP+qkIHt1FgWGwOQvENORT6XdMJYDsJDs2bi6NZ8b2Q=; b=gg5XKjKNkhCHCnWZykoP7P2SWkaZbHZMnORiCb1g85uxKUFa5k4RxjfMluGnydyTr1 UxWuiBdGiyAhZzya2D/W9DWL4/4TAGIfL7t0MdGUPQOOhPggJ2rTovt/kMWsoHpd8zMe xpg8fh6/XTPL4hQf7lQWEHUUa//UxVnysZlVz8Y2xrosITdg5EfQcU2mKgsD8SNXIT5P 2sVX7nBR/VIKxd/rYEKrYNbOIEcQN+oFtPvWW6uBcnYxp9x4x1pbh23B2djThxmgJzig bTpJRuploYLTHqKuGW6DO1FL6V6aWaB44AQ10mP587UZymuSV79twDdhI6mToz311zKC Ta1w== X-Forwarded-Encrypted: i=1; AFNElJ9lgreHgys/MrKoZfltwLuP+1o9fUz4uOHlEQljCGMnrnTJON/nKNJIVCFPUSvBGw+pA2CF4b6d8n6y4Hk=@vger.kernel.org X-Gm-Message-State: AOJu0YwPhHhlx+c3OY7SmNTpV5ucPqjF3xZS2k3COEPytZQkurmqJEdv P0oqgL7RWJdMbGLSiqEkKLGtZQFHIFLUZCc2f8fNCNHUaINXGsWt7Q3+ X-Gm-Gg: AfdE7cm0HNv2lRG8A4y8vldGlIR36aHjPvsQaH/2aOskbMXBbp5dWpNK2Yh4RsuBFoK sA+Bwqkjleyne8hV0nNDmIIdAa+45LFl0aRIFrK0v4MA2HI5fhyWqmOPnZbAVXVUZvazC9Dv8jL gRNzDDF8SgfBFUGkWGyT5hG6hCbzzaeWVoDdafET8PpYJpmK5NgBzvhYmZ2ueOzxkZiEdPr1pdv ZRixM/Ky5CCzLbLFyhE2w6ycwQtLmQYuZYHEdQpkIKE6jwQCe8B/2NuGAVWih6E7F2lJxtpQmLc Vty055NZeyXafc9kXarFvJIXB3CXPdWMLGtnLLqGUqZh2+3y6KMixcudk2bBvjMGv1Of/jsFVqk gHkIpoJ3NAtGwNxipzkNpa2oK5Z+m35U1kE2UAs1a785k28o0TRGjG5NBYCkk1c8mRVodkw2DBy 4+LrMQ/KkTKValGf02s6SzwZ6CFw== X-Received: by 2002:a05:600c:82cd:b0:492:48c8:c705 with SMTP id 5b1f17b1804b1-4926fc2fa58mr69551225e9.1.1782639615378; Sun, 28 Jun 2026 02:40:15 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47290ed4377sm5958924f8f.37.2026.06.28.02.40.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 02:40:14 -0700 (PDT) From: Yousef Alhouseen To: Petko Manolov , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot+9db6c624635564ad813c@syzkaller.appspotmail.com, Yousef Alhouseen Subject: [PATCH] net: usb: rtl8150: handle link status read failures Date: Sun, 28 Jun 2026 11:39:29 +0200 Message-ID: <20260628093929.44214-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit set_carrier() ignores the result of the USB control transfer and tests the stack variable supplied as its receive buffer. If the device rejects or aborts the request, that variable remains uninitialized and the driver chooses an arbitrary carrier state. Report carrier down when the link status cannot be read. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: syzbot+9db6c624635564ad813c@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=9db6c624635564ad813c Cc: stable@vger.kernel.org Signed-off-by: Yousef Alhouseen --- drivers/net/usb/rtl8150.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index c880c95c41a5..5606490aaea0 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c @@ -732,7 +732,11 @@ static void set_carrier(struct net_device *netdev) rtl8150_t *dev = netdev_priv(netdev); short tmp; - get_registers(dev, CSCR, 2, &tmp); + if (get_registers(dev, CSCR, 2, &tmp)) { + netif_carrier_off(netdev); + return; + } + if (tmp & CSCR_LINK_STATUS) netif_carrier_on(netdev); else -- 2.54.0