From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91D6531D72E for ; Sun, 28 Jun 2026 19:18:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782674293; cv=none; b=ayRQdsfiZ0MaeEdcRZeg1pqq8ywK93b1nlwpg1LjekELHbGwLD4gXAPkFSeYjTtzJQ9+K1x3RCczS+4YeQq86cJHwhONVY+3xt0J8F1a6ObwJLWup/kX88WAlIeh/d9PTpwsgfN9zfU0Jom0IFLUlVHpdjjlsxRYMGrm3sCca/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782674293; c=relaxed/simple; bh=s9lmi4jQi6DJYUYCwQ3xkTga/9as/SZs+1MrcjUFh24=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=E3Je6C5AFQN9xtA1Vjt9Kw2TrNNcEvapMHGFa+BBkwr9oLrH2lPTysBp9OBollzy1915EsocD91OR9eRzVxLQknixId0Q41nQIycnZXyZZJ4LNR3sFoed0S4nBV3NA58N95weMiJMbLKOnGJIvKDm6mdro5EsWoeN98gf5rtBX8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A0661F000E9; Sun, 28 Jun 2026 19:18:12 +0000 (UTC) Date: Sun, 28 Jun 2026 12:17:41 -0700 From: Andrew Morton To: Bradley Morgan Cc: Oleg Nesterov , "Eric W. Biederman" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] signal: change sys_kill() to use SEND_SIG_NOINFO Message-Id: <20260628121741.12a375ceaf9ba6f6a3ac51eb@linux-foundation.org> In-Reply-To: References: <20260626093603.7eb06a58684e0d02f3b9d0f8@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 28 Jun 2026 19:01:53 +0100 Bradley Morgan wrote: > >TODO: kill prepare_kill_siginfo() and change other users to use > >SEND_SIG_NOINFO too. This needs trivial changes in __send_signal_locked() > >and TP_STORE_SIGINFO(). > > > >Link: https://lore.kernel.org/all/20260622164029.11474-1-include@grrlz.net/ [1] > >Signed-off-by: Oleg Nesterov > > Code wise, please add my tag. > > Reviewed-by: Bradley Morgan Thanks. I updated the changelog for this patch. > I would do acked by personally but no idea if that's liked over in this > subsystm Both are liked ;) fwiw, I consider Reviewed-by to be stronger than Acked-by. I suspect the latter sometimes means "cool changelog!". > Description wise, I'm sure that looks fine > > > Andrew, could you please take my fix? There are many fixes, so please be specific to help avoid mistakes! I think you're referring to https://lore.kernel.org/all/86a8857d58d43ee26a8b365b837fd24830343494.1782159692.git.include@grrlz.net/