From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8D673A48F1 for ; Sun, 28 Jun 2026 14:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782655954; cv=none; b=TuHEvzBTFDqpVxnYvhc+IxxDsp1xjbObSSmQDkR0BkQ0JhjL+M+rKe8HEgjkPpDv7X66ci8kBIifku85pnZmiL1owREITP4sYeFcmUmykw2VUiRpOSyTajAP5tMIuUM+8asUwdovXA9zWqFst8Kh+VjZPhOUDSL5lKNvBtC+/NU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782655954; c=relaxed/simple; bh=hWytLo5lhGIClSKGyWEQEW+FaoLMyC8Sz0+WjVAkKZw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iTbVdnzGTzLsXt1ZyseQYAQExl6ZuvcQ9dw2/kgQv1+OwoeoWbFUB+QFL8SY699gPXWG/r+UFjgM9/EOfp+O1DV6/0yV13GJ5F4lNyfCJzSieSP+DWj8/hWlsnPjnsVRE7skE2puckHDHcYi9mxi2iJL9xSZXR7TubbHHclJbao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jVlMSejA; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jVlMSejA" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c96cb024ee0so200916a12.1 for ; Sun, 28 Jun 2026 07:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782655953; x=1783260753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hWytLo5lhGIClSKGyWEQEW+FaoLMyC8Sz0+WjVAkKZw=; b=jVlMSejAB7GjfmocxIFlKpnQGpcXZLnSvoPvRJdvWWOqKjrnzIXBtrACXBbOkKShQG 9q+7rkKXRKoa/vd85CzRLPa8y9zhkMJql1DNusd/nYK3mDIQGs0Z/3aAxW63m+mhXohO qjo5fBrArG1etho6Puxaygizzz2JARW0SJSmVEotj904c+DBlgzv2AQ+2b6H81CyhaVv waqXt1jcpcwhxt5qGCXFcXbIWa5YRdWPPA3Ke5ityG0rFFjsNu6KhNFL5CYTBxFtXZty VvOYtnf4nekP1jXyKpZWKhzG0JbFn9Af59nOWbteQ1VtCQ7pyCzD5qSfR/2DAxMi+Vyx E6zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782655953; x=1783260753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hWytLo5lhGIClSKGyWEQEW+FaoLMyC8Sz0+WjVAkKZw=; b=kEVxZP8RS/2TybcyYjSAlhAj4SlKC+U/YWS3jEsUpoUoWHly8IKAO7tfWKKeBfSQ3n rHpAI4ij+YxTg4NLvjxWnrDZa1xCVjopRd2T4qhvyHiobWwGX4fOfk/MWp30u3bqeTtu rThdldNd5CovwhscTL1I7/3AFNQyMtbLA934XJrUPxIO0qFlyBeHWYQKp8OhwpSx/oVV xNlwgO6OmA5IiHFnK5cpX69tTZbeiNBWjnRUYdN4BbHBYl6lbeefELPBEsn7Abte8JK/ 2lsNGhfyj+2aQKEz/GKh8clnJj2h8Cz6m29sbO9PyAiwNlyqIs0P8XdQCJEexPNNUFuE /04Q== X-Forwarded-Encrypted: i=1; AFNElJ/6VUXkVYnwWVCcSyuCpYYQgF6MMiL7udB9orvD+W14o+hDMGIbJIP8jgEvbyiJJkd/0VK/AOW+5TKuvNc=@vger.kernel.org X-Gm-Message-State: AOJu0YwZgnO35cVcn5o7KQ4R03fGOFIeq8rz/ES+um2X0wCLKWiu4MQ2 bS9wWqxTNq3bNKLYr331afYqIWjiAgBgm/zLGdFGC1guc/cws1QbE0L4 X-Gm-Gg: AfdE7cneJmJzBQ7epE2FySaxmqb2VHO68UHf5m7182aO4o1cIA2fIYqx20joLoKF/m7 rXiPlMeJ00obB8a/KkVfKb7e9BJ1FelwFhU3Pgt97ScNjq4MJB4tt/X0ugge+rWFIyW6dfR/2MB fZWkuyj7cXinMyS+i6+92jr0VCsAfOXxsQF9Jz58DnP2Tk9grKrQUt1VfizL6aYYQIiSZXIbyz9 wWhg1mW4uIvWsf4ycXD6yjltS811s49Q3STH+eSL54RiYI+wTI2uIfsd6DaaGe5p7XOCnP967SZ I49LI60xJ/+CBsWiXjn5seCAUQWC47gJtxYGXezPrHZ5XVCeY51lEXkOazDhSSlYjdszl0HBwr+ wI7bJstKJSxkIQsxh1cw1mMs2aU9j0l4f5+G1K5XQTL5fA4j9zkPZeeXIvUVshtJZsz3E680r0A Nez/dVypfKOifI30BuKeN/aLJ2mM0= X-Received: by 2002:a05:6a21:9982:b0:3ba:e5e2:73bf with SMTP id adf61e73a8af0-3bd4afd8113mr13935636637.43.1782655952941; Sun, 28 Jun 2026 07:12:32 -0700 (PDT) Received: from localhost.localdomain ([112.166.204.241]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c96ed000907sm1330488a12.4.2026.06.28.07.12.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 07:12:32 -0700 (PDT) From: Hojun Choi To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Deepak Karn , syzbot+ca7a2759caaa6cd4e3db@syzkaller.appspotmail.com, Hojun Choi Subject: Re: [PATCH wireless] wifi: mac80211: clear beaconing state in ieee80211_do_stop() Date: Sun, 28 Jun 2026 23:13:11 +0900 Message-ID: <20260628141311.12488-1-ghwns6743@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260628130802.7698-1-ghwns6743@gmail.com> References: <20260628130802.7698-1-ghwns6743@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Following up with the concrete path, since the question is whether cfg80211_leave() already covers this. It does not for AP start failure: ieee80211_start_ap() sets enable_beacon before its fail-able steps, but its error path (cfg.c:1930) only releases the channel, never clearing it (unlike the IBSS/mesh paths), while cfg80211 leaves ap.beacon_interval at 0. A later interface-down then makes ___cfg80211_stop_ap() short-circuit (-ENOENT, net/wireless/ap.c:30) and skip the stop_ap clear, so ieee80211_do_stop() runs with enable_beacon still set. I could not get a driver to fail start_ap() there, so this is by inspection, not a reproducer. I can fold this into the commit message in a v2, or instead fix the producer by clearing enable_beacon on the start_ap() error path (mirroring IBSS/mesh) - whichever you prefer. I used do_stop() since you suggested it might need to clear that bit. Thanks, Hojun