From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0691D3A6B61 for ; Sun, 28 Jun 2026 14:24:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782656673; cv=none; b=VegxFy8uXAtbi5BSJhhOL6yMapz/E5iVs1tuoQF/RRheAemuYtzoPZ9aOVHC3Iowt8VkHF4fWsJBqDLADwvEh2D07JVopIL930Gv23FwI7KSredgftKgsZWUxgLBTEcB1mNkQdJ9oGCwYVc8sQBv9hWHV+MLcTa5hAkSCzn1Q7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782656673; c=relaxed/simple; bh=1R/KuzTRQ4OYBfyE1PjecBDfm9bxCJCt3XJtXKafr8k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nxRXpcQ7UuaCjUQ2xPczhtBP8pKllnlnih599eVbxkkbP4g/9IS3gVJTU6EUSpz89RQLUmiS/UnhfyQQz9Mm3DH3H3MV+PNbGdqMf1iO53S2EL4gGrB7VkYF+YBF6O6XkT6k/vdZ5BTf/DnGFoMyOmtBk15DHb8Z00+ZBzoxfF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DT8SN+0Q; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DT8SN+0Q" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4938d60c035so8942205e9.0 for ; Sun, 28 Jun 2026 07:24:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782656669; x=1783261469; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xivX3NJ6EZtkbKkLAqCvtj9AF5zdWu3UP6KMCJ/Ac0o=; b=DT8SN+0Q/ZYqmILtFybfk2Rz5mkocm7Q9zcDKZQ57W987DX4qtDq8SgRHGh6VXCzrD xP1bA8MaJKqDResDZleqUbF4dOUNv5K8/fyUjGd0heGm4peBh7R3UgpM+UMnvwWM1DJB 8nF+W1Mu4DuBk+rr+WPsWarw/BznR/4nu0Tiq/2AsjCFgjaLCwBUY6y45CBqBuwVZ+NJ Er22HwWISHe9byBHLXyUhgsjroZWbUZWmzdEWYyTO/U4fWw7KECD3if4r3hh5CRxzEj4 ZSqxlaFwXd1KyZv/vYgl5fey/vNUEcQkaNmcr7jhXBByxk+Cpe6zicFno8gQ/iyrszs+ 8v9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782656669; x=1783261469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xivX3NJ6EZtkbKkLAqCvtj9AF5zdWu3UP6KMCJ/Ac0o=; b=jU4ORx7sNX0inJoomWt3FmctAyoScnHdyBqjmm/6/60Al7Sb2jHn9Hus09M7/ZsjA9 i+/He3LGlPXxQHUvEXTA5/66pG2XBCfch2znb7NY7eH2IeiA3a+9U05/xRnNJL6OF/SM OMLKVI/j9Nlp3+OeHJqr8LgRTzyGVTnTaojZItqyl48Ama+AyrPMCXEu9wIuqvYdVD2x v2LLX5U+EUur1rxBimW3/aM4vF87oOAkKDzpVNGMRoBzNM50tADcVKKOQZyiwM7V74sV cMXI/qGUS6dhTsC+I87q3yKPR9nO300lEYlbnSLbx9K++YxwWEyHOaJH+1riuevuuz5K ZuxQ== X-Forwarded-Encrypted: i=1; AFNElJ9R2sGxkfx3L4XqDKQWVOnMF6XyaNR+xuzUL18z/7AyT6VzjX2zKETDtnbxSmvFErMEvjxVcn/lph2/tZw=@vger.kernel.org X-Gm-Message-State: AOJu0YyqnHAGm/ulpHOsy4wHpYhobqYbGbI6VZYNz6Jj7PIX9bgO7cGT S8kTGTM+hHD0krHtHse/D0eumxKxmWqvhHVIazTlFLuN8jDKvwBeMkUx X-Gm-Gg: AfdE7cnyycKex9GNt0ja877hsJFxr67yRlH8QbxWqMu++MB3EdDLFGqa33TyP+z0JOA hIxkXKsqdR/eTrIQDgTmZnSZw4rMVxL5xpNLkYkv5yaW8Ell/2JCeez/uZxeiBlLdKypE8rsxjj L8+/fssOkDkxwZQnyoNwdYXI5/hz9QhuRuw/3/Ptw9amTKoH/9Pm+aEW2M4lag/Yrh2fPHKpdwU /3qlYvpkXidXO9/2djB+STxlG84yfRPOCQQs0Yale9cHO7eQb4usBResnswegdDn0YWg5IHhrp5 /2BG1I0Qkdlo4M2QKjaFQRt95WhLqMLdleHftGKEZkuKrIvrQ4Z2oK79jeZLTlyuYRbyB6MMWSP 1Y5Z1xu2G4o4vgY8APx9DeWJL7uq76YSyaKk4QGp+hzwQIZt5fHqKlx3uz1kb1JMJgXckjzAo5h Tz81EkYZZEsxg87TeDBBGlhTHfjTbX8xEpqQS/XWYoAvmgevijX9xb3AfIutdxliW/ne6sAmQNC xyYB34= X-Received: by 2002:a05:600c:c118:b0:492:6881:1114 with SMTP id 5b1f17b1804b1-49268811131mr154530535e9.0.1782656669173; Sun, 28 Jun 2026 07:24:29 -0700 (PDT) Received: from yocto.rz.uni-frankfurt.de (cb-8021x-nat-134-108.net.uni-frankfurt.de. [141.2.134.108]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4728072189asm7819927f8f.30.2026.06.28.07.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 07:24:27 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fygo.io, magiclinan@didiglobal.com, xiao@kernel.org, axboe@kernel.dk, vverma@digitalocean.com, john.g.garry@oracle.com, martin.petersen@oracle.com, abd.masalkhi@gmail.com, linux-kernel@vger.kernel.org Cc: linux-raid@vger.kernel.org, sashiko-bot Subject: [PATCH v2 1/7] md/raid10: fix r10bio leak in raid10_write_request() error paths Date: Sun, 28 Jun 2026 14:24:14 +0000 Message-ID: <20260628142420.1051027-2-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260628142420.1051027-1-abd.masalkhi@gmail.com> References: <20260628142420.1051027-1-abd.masalkhi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When raid10_write_request() fails because REQ_NOWAIT is set, the allocated r10_bio is not freed before returning, resulting in a memory leak. Free r10_bio before returning from the REQ_NOWAIT error paths. Fixes: c9aa889b035f ("md: raid10 add nowait support") Reported-by: sashiko-bot Closes: https://lore.kernel.org/linux-raid/20260613184042.BCEC01F000E9@smtp.kernel.org/ Signed-off-by: Abd-Alrhman Masalkhi --- Changes in v2: - No changes. - Link to v1: https://lore.kernel.org/linux-raid/20260623072456.333437-2-abd.masalkhi@gmail.com/ --- drivers/md/raid10.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 0a3cfdd3f5df..bd322eccdc3f 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1365,6 +1365,7 @@ static bool raid10_write_request(struct mddev *mddev, struct bio *bio, /* Bail out if REQ_NOWAIT is set for the bio */ if (bio->bi_opf & REQ_NOWAIT) { bio_wouldblock_error(bio); + free_r10bio(r10_bio); return false; } for (;;) { @@ -1398,6 +1399,7 @@ static bool raid10_write_request(struct mddev *mddev, struct bio *bio, if (bio->bi_opf & REQ_NOWAIT) { allow_barrier(conf); bio_wouldblock_error(bio); + free_r10bio(r10_bio); return false; } mddev_add_trace_msg(conf->mddev, -- 2.43.0