From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B35A3B0AF8 for ; Sun, 28 Jun 2026 14:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782656687; cv=none; b=HbpYNbj6vUmxnoBAzmT4lhU00twPyRU/85B0YFPY+iC++2eItuzLlug7COUHPfIris6sUGFsTL51jNDib/5dYuNeknpyqSuf4cWzwZcu98BcZY6MBH+V0TSWmB54YX8ZZa5aY/o4s20z+LtnX7vpKEmJB/Co5lH2bZ9cWUpbEKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782656687; c=relaxed/simple; bh=b6iP812E/S4AUBzMr6TGHGVkrfmOrTJLacq94xcyJ2g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EjXDEwecSXlnfbpqyJq1nb/HrlCac+GTt6jVitvMMV8/Oszd3UlCY2DikOeO3LLatU+z3wWTse2i/nYrKppWM0lq9s+57zIVAyQQIoM4bb1vuDVP6vRl8Hoo3Fk9VbIX7j8Z4Kw79GdTCznmmIBc4dM/OgqWsrEdF4VPKZ4ojYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XBX6rjUA; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XBX6rjUA" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-4720f3bf164so397714f8f.1 for ; Sun, 28 Jun 2026 07:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782656683; x=1783261483; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ayWrbW+jc26EuCDFJ6wgpKAN5JGPsLDXOp0AK1j+d5s=; b=XBX6rjUAFExG95kfzeA6LcHyV4/2I8CsiE4JMyvbdEy4xSdfdDYFyK2+dIcs/tcjO5 bqpwekCFe58ivAFwH8dghWtozq+Qqkr7nBf1HsnT1XTwI/ZbAFJXtGKUk+mTgs5NQDSy MIwHzdve+45rLUM8oIWxspnpXiiCUMeOCOPohK73J4ZAt4fa4NR7P8VnYDPsD9UpaG3l vq35C6qS/2aaf1NPsy7Gn7eBfX153L9QbrjxUTei2DV2NAgCvekKrWtlyVIwkljmY49u dwswGkOwLyZWA9xCJJuPcHSM7UviosktoON4F1fzAXyx+Wos24WE9OXhYyEg6vIIPshs UhIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782656683; x=1783261483; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ayWrbW+jc26EuCDFJ6wgpKAN5JGPsLDXOp0AK1j+d5s=; b=TqBBqbR2YFE5tfSFm19gS+mWe58Yu2WH5mU1rQr/vVNEoANjRXjNOaUmKedK82+nWP bPrjGcN9BCf3+sq+26HOESWmwx6VExbhe4ePsOhWcgI1q3Lny9Mj5sABWQ3SZRHx92Rz +I7ZW5ufIDEKO4hc6QfDQBwJNoRgoOXpxhWUvUQ+wHSK2DnYhbFiRlDRVdbpufqNWLZB Tg2ttskTOiU9LF3l7XAVIpnkrpCI1i95gTW6ZpYsmk+Pyn7RB54q4b0hN7eAq6SrRax7 MGw0Tc7812H4mm8vkK8JQYOPTAJb6PioIgEQljfaMCoHxrWPiMV/4jVLb5KSiikLkvR2 bRaQ== X-Forwarded-Encrypted: i=1; AHgh+RoS40qmBcp5QbxKVnfb3QULWn7DUEbO1zY4VhdwIvQXmJS8Q4u7FvVzUr5xlhyYI/xqQi5WnxSNHDZz0Ww=@vger.kernel.org X-Gm-Message-State: AOJu0YxDBN/1k0/Iz3CaKQM7DrzhHnhXXFSX6MJ4P/S7X9LlmPsa07yX cZpwWqbaJsYJbr96m/vE3pni0Xc//bMz+gaVmYmJgta6efwEJsYEolPm9VsIbQ== X-Gm-Gg: AfdE7cnIXQ+j2+ZIiAZcU6HaWrY3na5QVvWIpX73KIXLXkSFrohefPajZQjn77Tpziy 7OlDwag3CIwGE/1NbZ4cbItov8czcWWhc+bocTUCQpNUSnkg8bJFwVgrdjXW9GK++yL4QbN3/Vt sipa1gAil8Xf8AUjGENeCUFdIBfXy6W2ebrKRJwTXMc4MHR+QquIKj1qj6NgThWgm2HKGQhl9bp V1qkR+0uFU2bypiXG8ME/kiVkpRc/X7ultttMP+HaFOYqDQwlE+bnueL8EDT4jKP3B0kNJEq7V1 Jy68mP159TpgX6wLYQRS69DpkS8roY1c24wSMrj7+FE9Vy9O5T72rn1xw2oDaedtEeImm5FlPZx E71HdZCEceS69YEBOt8+1/PEGj+jtZrHbNOO4CThrS9uFDX4Gu51mOqZWRDYrTU/kcRbCudVw+P IR225IlVSysCbdIC0u0rdI/mAybgNAeexamGOQ+jGVzkLH0nQNMb71B3wUzW5XvtT3h0hLHFyBw kQfOkc= X-Received: by 2002:a05:6000:240f:b0:46f:8082:157d with SMTP id ffacd0b85a97d-46f80821678mr12286347f8f.28.1782656682774; Sun, 28 Jun 2026 07:24:42 -0700 (PDT) Received: from yocto.rz.uni-frankfurt.de (cb-8021x-nat-134-108.net.uni-frankfurt.de. [141.2.134.108]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4728072189asm7819927f8f.30.2026.06.28.07.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 07:24:41 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fygo.io, magiclinan@didiglobal.com, xiao@kernel.org, axboe@kernel.dk, vverma@digitalocean.com, john.g.garry@oracle.com, martin.petersen@oracle.com, abd.masalkhi@gmail.com, linux-kernel@vger.kernel.org Cc: linux-raid@vger.kernel.org Subject: [PATCH v2 5/7] md/raid10: replace wait loop with wait_event_idle() Date: Sun, 28 Jun 2026 14:24:18 +0000 Message-ID: <20260628142420.1051027-6-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260628142420.1051027-1-abd.masalkhi@gmail.com> References: <20260628142420.1051027-1-abd.masalkhi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The wait loop is equivalent to wait_event_idle() and can be simplified by usaing it for improving readability. Signed-off-by: Abd-Alrhman Masalkhi --- Changes in v2: - No changes. - Link to v1: https://lore.kernel.org/linux-raid/20260623072456.333437-6-abd.masalkhi@gmail.com/ --- drivers/md/raid10.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 2574f60dd771..57813f249578 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1362,22 +1362,17 @@ static bool raid10_write_request(struct mddev *mddev, struct bio *bio, mddev->cluster_ops->area_resyncing(mddev, WRITE, bio->bi_iter.bi_sector, bio_end_sector(bio)))) { - DEFINE_WAIT(w); /* Bail out if REQ_NOWAIT is set for the bio */ if (bio->bi_opf & REQ_NOWAIT) { bio_wouldblock_error(bio); free_r10bio(r10_bio); return false; } - for (;;) { - prepare_to_wait(&conf->wait_barrier, - &w, TASK_IDLE); - if (!mddev->cluster_ops->area_resyncing(mddev, WRITE, - bio->bi_iter.bi_sector, bio_end_sector(bio))) - break; - schedule(); - } - finish_wait(&conf->wait_barrier, &w); + + wait_event_idle(conf->wait_barrier, + !mddev->cluster_ops->area_resyncing(mddev, WRITE, + bio->bi_iter.bi_sector, + bio_end_sector(bio))); } sectors = r10_bio->sectors; -- 2.43.0