From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CA512D2495 for ; Sun, 28 Jun 2026 16:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782664231; cv=none; b=rjvV+kBJzV1HasBfg68lsM85e+ErJYt+0xWJiM6hYe/NnsSunsR1uBSGJsC5L8BF4npdZAkquBkwoz1u8ipy7zgdw9fVK595OYfeL26UNwx4bwgInDjtdQ/uIlZZBfjnsVA2p/1EL1LOv+zNsEfbKMoKRhYX2D14gCCSqqxmkqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782664231; c=relaxed/simple; bh=AwLmTjHbrcU+SOVQa01R8c+bODe7xXJZIanI/IfDJtA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RzJN1/rryqOVgAuygEvUhEPjM9bpS3kAXcGVZ4biuZL5TMD/GIiAD9UgG2U95+tN1d69PWld7/OxTgOJaJcAmMKi5uT9nkjY10RW4JiJGJ2Nq/q74llrj5qEdfkTn+vVtr5cUK/dROPDm4Ws5hv2mkabOv/QibyTylhsMmpKoDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qAslV0OY; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qAslV0OY" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4926ee9e8d9so10156845e9.0 for ; Sun, 28 Jun 2026 09:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782664229; x=1783269029; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fMnBtmnHmhK3jg0PxdbXqkHYJjM0gMd6xqD4YPFeDWU=; b=qAslV0OY1RR3QE+/3XPt75MHqz4pqPi8eBz4uS1tY1L/9Azg8W3mQpmKYOskpIYkgm 2JYcfhArOkkD5+wB3fQ5wMGajEVb6lUjMkpD1UN1x4wh7dd88SCj0NkUB8e7Zf8AXp2M Jqv9gQtG9nDLNzKFOpTDS/BS1Y0THgyk45zNdkHWe75AVt3dlt43m1D7qjFfB3wpuji1 YPXwuxeKHsEf5e3byYQiNS9psCJOwWLF7rrqVL+GGig1D0ElNSeA/yaDApTxCy222Zxg I+Ls3E/3QyFJsD8fIPAFBdiNgPqttJThO/Z/V9Lb4Rz63xDjR0qgZNQLeOKKKsVEG3/1 +ENw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782664229; x=1783269029; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fMnBtmnHmhK3jg0PxdbXqkHYJjM0gMd6xqD4YPFeDWU=; b=PjkuNiR3Rl34v5XpcNPoTke1qlOICOv+n9IE2o0luTPYxcXPbEK3rJOBQn2q4YS0V0 3vte+HYKWUjXJpVohjR4c9EhDWsbSP4u4nH/1eTJQcfkfRDi8Ku3m7B1ruvdsQSBeiRR 4YEjCtthOC+0+HM+3aAzw/0Ec27SADKKEbzgiUHDyRG+x7O34XqlHkNc4yYQtNhYgOOJ niEQvonWJU6bntKoOH2npF6jxhodET3Zld1zukkoKzIZsGgtV+ljX0xTPuFHgmO8ZS7j A8bO+PxgMTCQPSmQwVv9RXJq3witRTv8Oc5itCbVtlufOADiqN9PG/4bLGfwdOiCvTNb cLjA== X-Forwarded-Encrypted: i=1; AFNElJ/KkpOXYMc9pKE6XVpbWs2e6AS3H2wTsyJxtZVSTbu50t4eXoYlyWDjfUDPDRu9gNj+Me3cgYUHaSWm2fU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxtu4uTpcqGSmTrWyY8/4yJ+L8PzcZpgirU/bCpIyKS/mHPbJ+u e9FDfqiQmh4wO1XAaEt8BEDb+Z8CTCSSFlP6/mrmBWc91BxDXeBuxMyi X-Gm-Gg: AfdE7ckfwe3E8jq8yGoCST1Qe1B1ZxuVDrlLntp/cPI60ZZ1mEuKSfzwBWr//lp/7a8 k2DAefN4Z++g+bndBx/PqiFssunuKHkxRlrNY1HRIK7NN4T3AsCfygGbKyNC0x5pMfgUMujMkBk GAeqcAIjD1Iewe9XEhhbBnpyADMKi0Mnxoa2LsurX1tiLhhYxxPuAwE9FwjcgxJ6XZi6MFD+bNE aCJAkTxZKrNJFztvNvV8p8zWLn3CmMET84dmvmL0npZMvS8d2szHhPZE3LdoiRnpGrBOGtetyxv yBK4xEQLzrvDBpwkcXlkkzyM8ex3hBSiSwlVSBZN840OFbwq8rYV+iq6RnvNtFY5BA1c8xJ1Qn5 XCETSpboRI3Pvl1qjG+E0YjgBhKHXXf9Ba8+yXcsblwKmTYW2Fw+112O9F5eLsY/3AQ17C15iJB CX1aBjY/+/D2dxv066F1MeimxhqE0= X-Received: by 2002:a05:600c:e54a:20b0:492:3fb5:3a17 with SMTP id 5b1f17b1804b1-492663f5bc7mr127559565e9.2.1782664228533; Sun, 28 Jun 2026 09:30:28 -0700 (PDT) Received: from anthony.local ([2a06:c701:49b2:4c00:12ff:e0ff:fea5:3d2e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49268fde98csm261474625e9.6.2026.06.28.09.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 09:30:26 -0700 (PDT) From: Amit Barzilai To: andriy.shevchenko@intel.com Cc: airlied@gmail.com, andy@kernel.org, azuddinadam@gmail.com, chintanlike@gmail.com, conor+dt@kernel.org, deller@gmx.de, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, gregkh@linuxfoundation.org, javierm@redhat.com, krzk+dt@kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, maarten.lankhorst@linux.intel.com, mripard@kernel.org, robh@kernel.org, simona@ffwll.ch, tzimmermann@suse.de Subject: Re: [PATCH v2 2/4] drm/ssd130x: Add RGB565 support to SSD133X family Date: Sun, 28 Jun 2026 19:30:02 +0300 Message-ID: <20260628163002.56829-1-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Thanks for the review. On Tue, 23 Jun 2026 12:03:06 +0300, Andy Shevchenko wrote: >> + * Each Segment holds one pixel and each Common output has a row >> + * of pixels. A pixel is 8 bits (one byte) in the 256 color >> + * (RGB332) format or 16 bits (two bytes) in the 65k color >> + * (RGB565) format. When using the (default) horizontal address >> + * increment mode, the pixel data is sent Segment by Segment >> + * (e.g: SEG0 first). >> * >> * When using the 256 color depth format, each pixel contains 3 >> * sub-pixels for color A, B and C. These have 3 bit, 3 bit and >> * 2 bits respectively. > > Something wrong with the plural. There is a difference between "3-bit" and > "3 bits", but "3 bit" is odd. You're right. This is pre-existing context, but since I'm reworking the block I'll fix it. In v3 it will read: * These have 3, 3 and 2 bits respectively. >> + * >> + * When using the 65k color depth format, each pixel contains 3 >> + * sub-pixels for color A, B and C. These have 5 bit, 6 bit and >> + * 5 bits respectively. > > Same mistake is repeated here. Fixing it the same way in v3: * These have 5, 6 and 5 bits respectively. >> +/* >> + * Per-variant output format selector for the SSD133X data path. The >> + * hardware can drive the panel in RGB332 (1 byte/pixel) or RGB565 >> + * (2 bytes/pixel); this is a policy choice per variant, not a > > In other comments it was spelled fully, be consistent "1 byte per pixel", > "2 bytes per pixel". Good catch. Rather than spell it out, I'll switch to "bpp" (bits per pixel), which is more concise and matches the wording already used in the commit message. For consistency I'll update both this comment and the ssd133x_format_info() one in ssd130x.c. In v3: * hardware can drive the panel in RGB332 (8bpp) or RGB565 (16bpp); * this is a policy choice per variant, not a -- Thanks, Amit