mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
To: "Sibi Sankar" <sibi.sankar@oss.qualcomm.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
	"Maya Matuszczyk" <maccraft123mc@gmail.com>
Cc: linux-arm-msm@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Anvesh Jain P <anvesh.p@oss.qualcomm.com>
Subject: [PATCH] platform: arm64: qcom-hamoa-ec: Register cooling devices with their name
Date: Mon, 29 Jun 2026 14:46:19 +0530	[thread overview]
Message-ID: <20260629-fix_cooling_device_register-v1-1-c6e518b0bbd4@oss.qualcomm.com> (raw)

Each fan is registered as a thermal cooling device using
devm_thermal_of_cooling_device_register(). When the thermal core gained
cooling device ID support, the helper's prototype changed: its second
argument became a 'u32 cdev_id' and its third a 'const char *type',
replacing the previous 'struct device_node *np'.

The resulting semantic conflict between the EC driver and the reworked
thermal helper was resolved while merging the drivers-x86 tree into
linux-next by passing NULL as the 'type' argument, dropping the per-fan
'name' string. As a result every fan is registered as a cooling device
with an empty name.

Pass 'name' as the 'type' argument so the cooling devices are registered
with their intended "qcom_ec_fan_<n>" names.

Fixes: 5c44f48e91de ("platform: arm64: Add driver for EC found on Qualcomm reference devices")
Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
---
 drivers/platform/arm64/qcom-hamoa-ec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/arm64/qcom-hamoa-ec.c b/drivers/platform/arm64/qcom-hamoa-ec.c
index 45829f2786b7..12196d56b60e 100644
--- a/drivers/platform/arm64/qcom-hamoa-ec.c
+++ b/drivers/platform/arm64/qcom-hamoa-ec.c
@@ -391,7 +391,7 @@ static int qcom_ec_probe(struct i2c_client *client)
 		ec_cdev->fan_id = i + 1;
 		ec_cdev->parent_dev = dev;
 
-		ec_cdev->cdev = devm_thermal_of_cooling_device_register(dev, 0, NULL, ec_cdev,
+		ec_cdev->cdev = devm_thermal_of_cooling_device_register(dev, 0, name, ec_cdev,
 									&qcom_ec_thermal_ops);
 		if (IS_ERR(ec_cdev->cdev)) {
 			return dev_err_probe(dev, PTR_ERR(ec_cdev->cdev),

---
base-commit: 948efecf22e49aa4bf55bb73ec79a0ddcfd38571
change-id: 20260629-fix_cooling_device_register-cca038ff50c4

Best regards,
-- 
Anvesh Jain P <anvesh.p@oss.qualcomm.com>


             reply	other threads:[~2026-06-29  9:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  9:16 Anvesh Jain P [this message]
2026-06-29 11:21 ` Konrad Dybcio
2026-06-29 14:08   ` Anvesh Jain P
2026-06-29 12:33 ` Ilpo Järvinen
2026-06-30  5:30   ` Anvesh Jain P

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260629-fix_cooling_device_register-v1-1-c6e518b0bbd4@oss.qualcomm.com \
    --to=anvesh.p@oss.qualcomm.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maccraft123mc@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sibi.sankar@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®