mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Liam R. Howlett (Oracle)" <liam@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	maple-tree@lists.infradead.org,
	"Liam R. Howlett (Oracle)" <liam@infradead.org>,
	Jason Gunthorpe <jgg@ziepe.ca>, Rik van Riel <riel@surriel.com>
Subject: [PATCH 13/18] maple_tree: Document that erase may use GFP_KERNEL for allocations
Date: Mon, 29 Jun 2026 10:41:40 -0400	[thread overview]
Message-ID: <20260629144145.1572283-14-liam@infradead.org> (raw)
In-Reply-To: <20260629144145.1572283-1-liam@infradead.org>

State that the mas_erase() and mtree_erase() functions may use
GFP_KERNEL on allocation retry.  Don't just depend on people reading the
documentation by adding a check that will warn of the use.

Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Rik van Riel <riel@surriel.com>
Signed-off-by: Liam R. Howlett (Oracle) <liam@infradead.org>
---
 lib/maple_tree.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 67cc480534e96..c5efa3e2f7461 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -5686,6 +5686,10 @@ EXPORT_SYMBOL_GPL(mas_find_range_rev);
  * Searches for @mas->index, sets @mas->index and @mas->last to the range and
  * erases that range.
  *
+ * Note that erase requires allocations and will use GFP_KERNEL to do so if
+ * necessary.  If the allocation fails, the internal lock will be dropped to
+ * retry.
+ *
  * Return: the entry that was erased or %NULL, @mas->index and @mas->last are updated.
  */
 void *mas_erase(struct ma_state *mas)
@@ -5694,6 +5698,14 @@ void *mas_erase(struct ma_state *mas)
 	unsigned long index = mas->index;
 	MA_WR_STATE(wr_mas, mas, NULL);
 
+	/*
+	 * In low memory situations, the allocation is retried with the gfp flag
+	 * GFP_KERNEL.  The internal spinlock is dropped in mas_nomem(), however
+	 * the external lock is not dropped.
+	 */
+	if (mt_external_lock(mas->tree))
+		might_alloc(GFP_KERNEL);
+
 	if (!mas_is_active(mas) || !mas_is_start(mas))
 		mas->status = ma_start;
 
@@ -6040,6 +6052,10 @@ EXPORT_SYMBOL(mtree_alloc_rrange);
  * Erasing is the same as a walk to an entry then a store of a NULL to that
  * ENTIRE range.  In fact, it is implemented as such using the advanced API.
  *
+ * Note that erase requires allocations and will use GFP_KERNEL to do so if
+ * necessary.  If the allocation fails, the internal lock will be dropped to
+ * retry.
+ *
  * Return: The entry stored at the @index or %NULL
  */
 void *mtree_erase(struct maple_tree *mt, unsigned long index)
-- 
2.47.3


  parent reply	other threads:[~2026-06-29 14:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29 14:41 [PATCH 00/18] maple_tree: lock checking and clean ups Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 01/18] maple_tree: Add rcu locking check when LOCKDEP is enabled Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 02/18] locking/lockdep: Add sequence counter to held_lock Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 03/18] maple_tree: Add write lock checking with lockdep sequence numbers Liam R. Howlett (Oracle)
2026-06-29 15:03   ` [PATCH fixup] maple_tree: Static define mas_lockdep_map() Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 04/18] maple_tree: Documentation fix Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 05/18] maple_tree: Drop dead code from mas_extend_spanning_null() Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 06/18] maple_tree: Drop MAPLE_ALLOC_SLOTS Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 07/18] maple_tree: Clarify comments on mas_nomem() Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 08/18] maple_tree: Use prefetched value in mas_wr_store_type() Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 09/18] maple_tree: Optimise mas_wr_node_store() when not in rcu mode Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 10/18] maple_tree: micro optimisation of mas_wr_store_type() Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 11/18] maple_tree: Add bulk parent set helper Liam R. Howlett (Oracle)
2026-06-29 15:22   ` [PATCH fixup] maple_tree: Fix dereference of rcu type Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 12/18] maple_tree: Catch race in mas_alloc_cyclic() Liam R. Howlett (Oracle)
2026-06-29 14:41 ` Liam R. Howlett (Oracle) [this message]
2026-06-29 14:41 ` [PATCH 14/18] maple_tree: WARN_ON_ONCE when allocations fail Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 15/18] maple_tree: Document erase and allocations better Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 16/18] maple_tree: Change two GFP flags in tests Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 17/18] maple_tree: Fix argument name in header Liam R. Howlett (Oracle)
2026-06-29 14:41 ` [PATCH 18/18] maple_tree: Avoid extra gap calculation Liam R. Howlett (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260629144145.1572283-14-liam@infradead.org \
    --to=liam@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=riel@surriel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®