From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 204EA3E8345 for ; Mon, 29 Jun 2026 15:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782745639; cv=none; b=R031JOI2P5k5QQfUP/77n53+aZOWPICnSLedi3UgGMqIAoOi78TWrF4eg3eRJKo2UJFMTZNJemqVQ0CALCqP3CjJ5u6r6RJ10f2Ky+ywtbJotnPRyNmB+ZDfVDkG1tinv8EjerPc0LzkgX2gFZNhK/RCIuCqv4THdnd77awCBb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782745639; c=relaxed/simple; bh=J3/OG7xsULtTi43LFbheg6BUBWc1b4hsbrKhFAjULjo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QK9cfrvR870mT+qr3xlIwnAXDlq1xpv0nhTQ5K7s/FxAFsRMBJToAWpfJh9H5i7M5yTOfeopc47klzMyHQlF4izUC1n+qGn36Phyo4nvwbxzVmJFE52tYVRuoGBSJ4V1gev95ZC4DDvobFzZ7QXTNO0cMa85pO7zPQZWrk8Sz0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ilAQpXiG; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ilAQpXiG" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-3078e0dcd67so6004246eec.0 for ; Mon, 29 Jun 2026 08:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782745637; x=1783350437; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nBucK9BctEyorzwpXgdpAjl0JFGTNYaAkDM1NigzWIU=; b=ilAQpXiGF5JPzw4xd/TMUxucszfzOw046sFv4S1OrpMHXhTJGwlkyV5oAmPUm6PjRU MD8su2CFac6LeyKy26Uo0bp62ZevcVRj4Abled1N3en4dIMlXPwUwG+ufY4AKaoYy/bX gkoGY0KHw9v4oa36U6TeylV8W3n5dqB+zEv4Dsqh1/Fo9N2O7HdNnhsc3p71ARXJIG2t Hz1ulCZ9HQpoBo0m1AHViKsm2scYZiaA/koujiigbFsX8yVLWLJQii2SG6ZePM3smkWy rIYq+CRw3ifYNKYY+iOAs3cQ/cenFvZJNFpdvjii2DciwNcX19Xg2G090qocOsAEGg9z 6URg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782745637; x=1783350437; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nBucK9BctEyorzwpXgdpAjl0JFGTNYaAkDM1NigzWIU=; b=FM7OuErz6FS69UGCUYoke/RoOIuPrLucPf7uuCkV6iZu7oXKNbJtZfxN+eq8iemnkY 3fFKGv8lRkakN7U5COLM2ceRuJq9bkrEA+dxn2NkNPPTbduoILFk2zSZA3JoWvjmCXk0 55O577jDt4BSRa52Qj5OyE/5k9i5OV0MepYHQZWJjV+1hKjyvT9WJMGaLjGykwcOtjqM wFFdLvu/Ki6bGzpCZZOMJRmcWCCiX8tUsHOqla4hxrpuMpUI5iRQkaFQnxcWw5YmSFNN 0IX9FL6FP8XfMAlnPdjEl9bHS8ELZjMGH32Ha2CHnG/wG5ItX0P0BqB16Ul84TvI2SNG 3g3A== X-Forwarded-Encrypted: i=1; AHgh+Rowin0FFZTYY/7UeI/2ON+vd+718KkPzlbxox3U4pOYg9ZjrCn1d9hKkl3KQ8cd3oiok0+VtSwle728Ze0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzgk4/WP3rX4/xGOKxfsdedZK+UBm70YBbaArIukggOOtfW57ok aWmEQkJk/4+H6bUJP+zfBJ1XuitmWR1ykIMVhG5pWcCxwCGS85I54dzObHraTbux3/A= X-Gm-Gg: AfdE7ckdOhmLy1pL3mqB5ftphqQ5u/Lmo1l6revOG2YSqT951E+9ztbekz84mN2HiZH 3yzYHv0L4u1EwIpqjcxz6Pglm1oGZsk30qkNASTtoINSqcpq2l1HOpSPZSAS9IJa0HR+SDFrzbY aext3klIWj9mYllB4P36DIVycOiJuRdgbiG5yiM6BvZMZCWBTIGZse6DSqr/QKmqcazV4BfePVT /uBAw4Mzjpxz4Sd/h2AUM8dxadMpJDmo/wmEuJSf4TqkbCvaWaCBeGCqwmhkgAB9HtOnOB40+fO lZVivkBsF09fQ93VMB6t7/EyJhR4xtk7vBdR0Vx/lqHMxf3C7pAAa+Qn2TBTTidtzUQQwN5QWVZ F+XURGu0RxbZdVBmvruyWvo6GhubZvvmTnW0xnr7LdGfA8e2PNsYXVLHYgF/WumL+EOyhoPGa/w zTEimaePvd61cGCmeF2b/35b7/xq0= X-Received: by 2002:a05:7301:3807:b0:30b:ed93:5cdc with SMTP id 5a478bee46e88-30c84df4aa2mr14269685eec.31.1782745636954; Mon, 29 Jun 2026 08:07:16 -0700 (PDT) Received: from evo.www.tendawifi.com ([103.98.7.180]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ec79d4746sm14838131eec.13.2026.06.29.08.07.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 08:07:16 -0700 (PDT) From: Archit More To: lizhi.hou@amd.com, mamin506@gmail.com, ogabbay@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Archit More Subject: [RFC PATCH] accel/amdxdna: Replace sprintf() with sysfs_emit() in sysfs show functions Date: Mon, 29 Jun 2026 20:37:03 +0530 Message-Id: <20260629150703.71734-1-architmore303@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Documentation/filesystems/sysfs.rst recommends using sysfs_emit() instead of sprintf() in sysfs show() callbacks. Replace the remaining sprintf() calls in amdxdna_sysfs.c with sysfs_emit(). There is no functional change. Signed-off-by: Archit More --- drivers/accel/amdxdna/amdxdna_sysfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/accel/amdxdna/amdxdna_sysfs.c b/drivers/accel/amdxdna/amdxdna_sysfs.c index d9e359ee8182..8b4749e6c380 100644 --- a/drivers/accel/amdxdna/amdxdna_sysfs.c +++ b/drivers/accel/amdxdna/amdxdna_sysfs.c @@ -18,9 +18,9 @@ static ssize_t vbnv_show(struct device *dev, struct device_attribute *attr, char struct amdxdna_dev *xdna = dev_get_drvdata(dev); if (!xdna->vbnv) - return sprintf(buf, "\n"); + return sysfs_emit(buf, "\n"); - return sprintf(buf, "%s\n", xdna->vbnv); + return sysfs_emit(buf, "%s\n", xdna->vbnv); } static DEVICE_ATTR_RO(vbnv); @@ -28,7 +28,7 @@ static ssize_t device_type_show(struct device *dev, struct device_attribute *att { struct amdxdna_dev *xdna = dev_get_drvdata(dev); - return sprintf(buf, "%d\n", xdna->dev_info->device_type); + return sysfs_emit(buf, "%d\n", xdna->dev_info->device_type); } static DEVICE_ATTR_RO(device_type); @@ -36,7 +36,7 @@ static ssize_t fw_version_show(struct device *dev, struct device_attribute *attr { struct amdxdna_dev *xdna = dev_get_drvdata(dev); - return sprintf(buf, "%d.%d.%d.%d\n", xdna->fw_ver.major, + return sysfs_emit(buf, "%d.%d.%d.%d\n", xdna->fw_ver.major, xdna->fw_ver.minor, xdna->fw_ver.sub, xdna->fw_ver.build); } -- 2.34.1