From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ADE74534AE for ; Mon, 29 Jun 2026 16:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782751097; cv=none; b=pEFfObt9HfZICSfpDI/LqcwtMlZhYrKH2vPOp9Q9lIEGkmiW0hP1N60OMznwadXDWH3iATqYJqROqfs7pACvfavw0paA1f0g2Dw9PuUAdm5iQ23ZDwDKLCK6tKSYJ595nia93X7q2ovkwtJgHmjJ28wLpgfzAlcE/233dLkAoq0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782751097; c=relaxed/simple; bh=xS9HXkHQt65kbdNX3PEY/ixQR504OdS8n7/Y+5xz3o4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=TavYiWz5mF47yba/Um9X4Z3vf8A6Q4LyJmiawXCpiQeVqhViQAN+HBf2n4QMZYztMBWL5gDp+RsqNugoIkyn57ZEMcOc+kXoC5puI26v7jcUamO3dQ0OLvJInRiHo+PfkwiHd7PVQUWZNe5YL2Cw82KlRrL554av78j5PNc+W2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zjcx7ts/; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zjcx7ts/" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-4704d652e9cso1512917f8f.3 for ; Mon, 29 Jun 2026 09:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782751094; x=1783355894; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y+CxHy0SCXrpnemjCBAKhWexIpJlnOyaJVCHp2VG4Pg=; b=Zjcx7ts/EqreYudtfUHjHxJZm3wGEJempZOrTfWAC5WIW9tNOgwWLeiwJhSMs4sT9e j4S+lVmQLH6p51/oWstbQb78KFaGYO87aP1o0x6GOj8OcaJMUcPJ505qd1ucDaV4A8u+ rge841X0wBv8a3UMIEfwBI6G/oQdaXOTT8agLQ5X8ZjGBr9/9VmgpUDq6NMQkeunZMdx BjZrPPIyJUJYAsUKmAwprgZROcAwtL3EvDF24Vi8aN8MMasNCot1+wN5rWIPoapG+am6 XN/6fh2N6TjjIj1LDTKhE2WZsGy8M8541H4f6ChtMtO3bRdkQk9JA/kRNgP1mIu1zl0d 8UFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782751094; x=1783355894; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y+CxHy0SCXrpnemjCBAKhWexIpJlnOyaJVCHp2VG4Pg=; b=h4eiZroy8L8AjoaNnxuCuW1wEylQLqRSVjsh/9CWALk8aQTDCbpXLJC5IayAo3YT7+ G9/K6wsyu4J/iS7GUMUu8ZtzHIcQvfX0jfyL/K6WjxCt/XMNj8J6jsheBPAOS0Hixr7b 8wawb2/HRfnj7Gg8sAyIk3KljqOaBKrEDvttLIV2Okjip8+G5K0cByE/YtJOEcgKYgwD A1EuC0Q8WgJFXnXw2y6fpiffAiZKw1XHhCMgkRn7c5JL2sAsSps8ABQSCTN/9b5E+clC Sg7FP7pmVGIR2SiNLyVTDoHCXnr6BNBYTB0NY35DCr01pIwUENza49f3b66mBhxYN1LU r9BQ== X-Forwarded-Encrypted: i=1; AFNElJ+bBS9Py+c/tl/RdGZG6t40+MDTAS6/paUtmckZEg2/foNMlClQSzjwdgIK7K/SJB9bKSBcb6aT5IJSWGo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+6QAimqTlg3MeQyvGOmp1H3VIs8672BNmd+Y1/sTdTg1Sa2eB ld9o3xSi5mFuWFqXhIQfO+Bj8b2C77u81nfj1rQQXGTXL3LIv8necLUPCEWRT+ES X-Gm-Gg: AfdE7cnKFG0wiUV+O2haKdK/vYLXezm+A6c5bpMiq4cU9tWAwdTnAhPf9LCpTlSc/vp NkX2LrCK1MIfQTGMCTgIcacjdoyJ3rntZ8K1BaehwVwnmXS3UeKeCyDMc5bdBKthIasPpkgVox/ 3Lzidy63tTDMt9Crc+uFg2kU9e2tZ/iBuRxkZhjjgdwg7D2BcABTYviHYp8u7Y57yjkYfie6b7c lYt7j32tKOjF599yCBRsjI7VCt2ZzgjIrBjJm1B6eDfa2tzupZT/G+alqhROfElknQUQvYUCDbh Akftjy2bJasShjNva/PsAtnNrO9KCzRQgRSb1zknIu4Audmt3sOGdkv5NE3nwK9o1PmrIotY2A0 f9qxqEh1k7NAapmkp37dtpwTCR2WC9zR7QmJfZ1IRN9fdRSZd06qqjgkkzQ6TLrL92GVWsOpKwM szC4NSdlfel2saFFW1hHBBwW9jsY9U/WDmll7a6BOQFzdu6bmwI2FlAuoXTPvgN7IOvDdCSCY05 ZlFhd2M0NvJt5Q2hI6CcKEI X-Received: by 2002:a05:600c:800f:b0:493:b243:900f with SMTP id 5b1f17b1804b1-493b8281619mr6983255e9.1.1782751093660; Mon, 29 Jun 2026 09:38:13 -0700 (PDT) Received: from helmholtz-coils-PC.nanosat.lab ([147.83.201.139]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4730937e18dsm15765501f8f.21.2026.06.29.09.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 09:38:13 -0700 (PDT) From: =?UTF-8?q?Pol=20Fern=C3=A1ndez=20Fern=C3=A1ndez?= To: linux-media@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Pol=20Fern=C3=A1ndez=20Fern=C3=A1ndez?= Subject: [PATCH 1/2] media: uvcvideo: add quirks for per-device stream error handling Date: Mon, 29 Jun 2026 18:38:02 +0200 Message-ID: <20260629163805.37879-1-fernandezfernandezpol@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The UVC_STREAM_ERR bit in the payload header signals that the device could not deliver a frame correctly. By default, uvcvideo delivers these frames to userspace with V4L2_BUF_FLAG_ERROR when uvc_no_drop_param is set (the default). Applications that rely on strict JPEG decoders (e.g. libjpeg) will display gray bands for the incomplete portion of the image, since libjpeg fills undecodable MCU rows with a neutral gray when the EOI marker is missing. Add UVC_QUIRK_DROP_STREAM_ERR to force-drop frames flagged with UVC_STREAM_ERR for specific devices, regardless of the uvc_no_drop_param module parameter. This ensures applications never receive truncated frames from devices known to set UVC_STREAM_ERR on genuine encoding errors. The existing uvc_queue_to_stream() helper is used to reach the device quirks from within uvc_queue_buffer_complete(). Additionally, uvcvideo unconditionally overrides the camera's probed wCompQuality with the maximum value returned by GET_MAX. For devices whose firmware treats wCompQuality=0 as an adaptive encoding mode (where the encoder adjusts quality dynamically to fit within the available USB bandwidth), this override increases encoding pressure and can contribute to UVC_STREAM_ERR events. Add UVC_QUIRK_NO_FORCE_QUALITY to preserve the camera's default quality value during probe negotiation. Signed-off-by: Pol Fernández Fernández --- drivers/media/usb/uvc/uvc_queue.c | 3 ++- drivers/media/usb/uvc/uvc_video.c | 3 ++- drivers/media/usb/uvc/uvcvideo.h | 2 ++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h index XXXXXXX..XXXXXXX 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -81,6 +81,8 @@ #define UVC_QUIRK_INVALID_DEVICE_SOF 0x00010000 #define UVC_QUIRK_MJPEG_NO_EOF 0x00020000 #define UVC_QUIRK_MSXU_META 0x00040000 +#define UVC_QUIRK_DROP_STREAM_ERR 0x00080000 +#define UVC_QUIRK_NO_FORCE_QUALITY 0x00100000 /* Format flags */ #define UVC_FMT_FLAG_COMPRESSED 0x00000001 diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -451,7 +451,8 @@ int uvc_probe_video(struct uvc_streaming *stream, if (ret < 0) goto done; - probe->wCompQuality = probe_max.wCompQuality; + if (!(stream->dev->quirks & UVC_QUIRK_NO_FORCE_QUALITY)) + probe->wCompQuality = probe_max.wCompQuality; } for (i = 0; i < 2; ++i) { diff --git a/drivers/media/usb/uvc/uvc_queue.c b/drivers/media/usb/uvc/uvc_queue.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/media/usb/uvc/uvc_queue.c +++ b/drivers/media/usb/uvc/uvc_queue.c @@ -357,7 +357,8 @@ static void uvc_queue_buffer_complete(struct kref *ref) struct vb2_buffer *vb = &buf->buf.vb2_buf; struct uvc_video_queue *queue = vb2_get_drv_priv(vb->vb2_queue); - if (buf->error && !uvc_no_drop_param) { + if (buf->error && (!uvc_no_drop_param || + (uvc_queue_to_stream(queue)->dev->quirks & UVC_QUIRK_DROP_STREAM_ERR))) { uvc_queue_buffer_requeue(queue, buf); return; } -- 2.43.0