From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF4D0477E24 for ; Mon, 29 Jun 2026 17:27:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782754041; cv=none; b=bTgQ9gJykqEHILcypBH+3ZUzcFqMNxJv6o68VN1H1sT8pwiR5NAm3EZe/dOPCFbTjsV4JcwfJUa+zjqTPJu0v3cHu2hyicNtaQ4gowH0miHY+k6q3mV1dOQAl6JFYRR3KG6p/A0OGYrk8d8JIiE67J36d+jzzQvixyLKi4PsjFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782754041; c=relaxed/simple; bh=xOeZ3AAryQQpH7b3QXyw0FJI7Icm4ldkT4ekRB6O/us=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AGpezoOm5ZPcTLibiVqA3Ark5V0A5EohdZhjM5Yb4Q0ZY9eS71Eg27bb0OxBmUUAK0+YL21/1TaDs9OuItGxf3Moou6YdkWTc71hLClhikDiRZwjvsyGE/N2OTIcJN6RkO/6TU5bYRKWA83dYLHDWG5Em+ojYkBLNi+/v93S518= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lsCuMxeC; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lsCuMxeC" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-845537740ddso2078276b3a.0 for ; Mon, 29 Jun 2026 10:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782754039; x=1783358839; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Bc1x3dlPbzBDaS3MpDbrXFa1nZO4qwexshU5OtsKQHE=; b=lsCuMxeC/1fyqK7YDIKbQL9XHgNLDq0EK0YYoSNy3wo+w1Dt0vlu9ZwsaQbMteAoS7 0UdENJrlfdpqSGQ7CsrZkxrMX6I89ZtRo6eGZWBh+uA0D9eaCHeVZQgyq1Mnji8F6LGc PRQOFk/P5XC4ktd4J1lJvD0UII8OYVLuxJ0iF0Ki4mbaYuazyE9W9eGu/RIcSCmWq0YS 21a0Qo1ctaQ1LCIAyUxQAdi3+f9auDCn7dcvMJKtCoUGWpud9xKsSP6g02/Np6YC4mzo yZKK+A4uai1jIC8td/ENf4Vbs6Cdm/o1pGzziyVjOX0V9nUwgabb5MLYQ2XNoo24e2ey oRrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782754039; x=1783358839; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bc1x3dlPbzBDaS3MpDbrXFa1nZO4qwexshU5OtsKQHE=; b=mUUaqquGD7jCkEdr/wGCn27ja1kwzW+6o97z1/gIBjc596UjONCnSgM1BvDF3W7jco yGKKKpqPwTiyN7eNU/+Dx6G0x01V96pnYdtP+BiaXDrAgYdWN1IFNkYlgJzcEJt6NG3v rR1H5w1gzYgSMV2YD4+TEPngASteu1a1O2rldcc0PfBGpXrIIBMkuumjRdCEBwmXWeQN hRdsf5INgOfPDozmTHhUbC7yZdNe8yETeF6bfle6+4ELqiKWBiEXbQOJknLew3O+e/I5 Lmy4xuDBvJtbk5/HYcxdvzzNFjd9YdMhAyiUycHtAqmDEnhuSj803CdOY51b8CRQJAHQ ZHjQ== X-Forwarded-Encrypted: i=1; AHgh+RrzZhEczw8pWwjDjTAH2ogrG4RBtciUVSA9X2ZIAGjvMEdV72/WGLDQYQ9wHq5yrFBpY0XRo8Pl2TldG6s=@vger.kernel.org X-Gm-Message-State: AOJu0YxxG/IFGcWSkbLG7k1OvHPu7mIuUyp04e5tAh2mrVdzTFhlCiU8 p50alTcFtWUf4jERiMQOyun1Kz1TZYA09+d8A8Sh0fTf+nsMJluw2PYY X-Gm-Gg: AfdE7cnZAE4JwqONyyd3mDyLyXRTyRfVAPv6OCoolNJPbQ//efYpnYNLavntw59u4Te 4UmZIdMx889yfSlQIh0TJpx0+Nl9emAQSmwDhN92PdGeAP499Vjke7SRoZacck8JB1QIz+DBjFE blHyuXSwJTgyVazQ1A+cMwh7ix5TFOtZH0DyxbhPxK+r8mxRVhvV/AAy7ErK2gAfKSVXaUi32BP 5MNkOOSZS0StuM3kfDFPYUuvWg8dFW3/o96fgo6sMTnZq+tmHBzzOp+e71/Q5JK+E+ta7vtDWhN 2LnAoym1FQINb3jyXzhbB5Mg3dTabX/1WnVbyMmNe8avwOLuwNtS/OT3hIHaYkIFw/1Tb8kBaK4 7uwbJavzkO+//8mf3ewv6tdW3UUBEi8P1xCMYEag+OET/iW033qL8V1AASX3VPNmVpAt/GowZfi cgIWL2n8LEnId2ACeE4SMp15YoxhDlxNvkX3LtE7T38Nl2gt1qRH0= X-Received: by 2002:a05:6a00:4fd4:b0:845:d274:c01e with SMTP id d2e1a72fcca58-8479f2d17a2mr333793b3a.55.1782754038787; Mon, 29 Jun 2026 10:27:18 -0700 (PDT) Received: from cps-manycore-1.. ([147.46.174.222]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a039f2afsm78542b3a.53.2026.06.29.10.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 10:27:18 -0700 (PDT) From: Sechang Lim To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , John Fastabend , Eduard Zingerman , Kumar Kartikeya Dwivedi , "David S . Miller" , Jakub Kicinski , Jesper Dangaard Brouer Cc: Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Stanislav Fomichev , Emil Tsalapatis , Lorenz Bauer , Jakub Sitnicki , Jiayuan Chen , Shuah Khan , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next v3 0/2] bpf, sockmap: disallow sockmap mutation from tc, xdp and flow_dissector Date: Mon, 29 Jun 2026 17:26:59 +0000 Message-ID: <20260629172704.1302218-1-rhkrqnwk98@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A tc, xdp or flow_dissector program updating or deleting a sockmap deadlocks on stab->lock vs sk_callback_lock and has no reason to. Patch 1 disallows it in may_update_sockmap(); patch 2 drops the selftests that exercised it. v3: - drop the broken selftests (Jiayuan Chen) - drop the Fixes tag and target bpf-next (Jiayuan Chen) v2: - https://lore.kernel.org/all/20260620034632.2308-1-rhkrqnwk98@gmail.com/ v1: - https://lore.kernel.org/all/20260616091153.2966617-1-rhkrqnwk98@gmail.com/ Sechang Lim (2): bpf, sockmap: disallow update and delete from tc, xdp and flow_dissector selftests/bpf: drop tc/xdp/flow_dissector sockmap mutation tests kernel/bpf/verifier.c | 4 -- .../selftests/bpf/prog_tests/fexit_bpf2bpf.c | 13 ----- .../selftests/bpf/prog_tests/sockmap_basic.c | 52 ------------------- .../bpf/progs/freplace_cls_redirect.c | 34 ------------ .../selftests/bpf/progs/test_sockmap_update.c | 48 ----------------- .../bpf/progs/verifier_sockmap_mutate.c | 10 ++-- 6 files changed, 5 insertions(+), 156 deletions(-) delete mode 100644 tools/testing/selftests/bpf/progs/freplace_cls_redirect.c delete mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_update.c -- 2.43.0