From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69C692367DF for ; Tue, 30 Jun 2026 03:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782790408; cv=none; b=QF+hyRsKdStrX3DYUcb6tAsAIoKAtoH41caRRnPe9r+rrzoVUX9JpcYOEZVFgVbyrawj/g2wLYwRoI4pHfL40zJonSX8oK2IIuquiok6PUxs8u0jfEV1693xXmTs2zhvHzQDIyTH7JFuyW1/z0L5khye7bpXtS/MuzQYCVIzE2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782790408; c=relaxed/simple; bh=T9bDX9gaGbHwv8cmEyJ2S2GpCwO6nZDc2iOIIWy2npw=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=KVa4eU8RhTBzlBpUi4GajqiwvbEu44Q8cRcljDHrZXpd/WwHIZ5Lf/6/Qfo4oNEF/zYLIP2FdpKnYNlwq3WLJ5T+As3b55/KBRB9mG6J1wScamODsAIAdxV9YemqUdl/2mVvY5mpmMDcFIuyca/4utj1uEhv1FAoH6f7RgM5MWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=zi/AJ0AW; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="zi/AJ0AW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A50381F000E9; Tue, 30 Jun 2026 03:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1782790406; bh=0Ci8PvJxUEXJD/vTo5guO6KBvc3lMdIG3mY5xBsHIs8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=zi/AJ0AWlCR2rnSE/ztL1W34PTx+fCXehlxp7pe2aGQZqbLbQZFFsoRr60uHaTqSS Mipx8cV6fhaXDEc8zi8BAXRkCfvC7868PofqkzwxlNNHxm6bnm0fAc/bkkd4XomIR9 gEYXZTynSaUBTRhjkIMR3L9Ia36/myrJCjF1qebE= Date: Mon, 29 Jun 2026 20:33:26 -0700 From: Andrew Morton To: Yichong Chen Cc: vishal.moola@gmail.com, ye.liu@linux.dev, zhen.ni@easystack.cn, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/mm/page_owner_sort: report get_comm failures at source Message-Id: <20260629203326.fbd5714e7ec8cbf0a22e7148@linux-foundation.org> In-Reply-To: <20260629062546.141659-1-chenyichong@uniontech.com> References: <20260629014316.130307-1-chenyichong@uniontech.com> <20260629062546.141659-1-chenyichong@uniontech.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 29 Jun 2026 14:25:46 +0800 Yichong Chen wrote: > get_comm() clears errno and checks it immediately, without any > operation that can set errno in between. The check can never be > true. > > Print the concrete get_comm() failure reason where it is detected, > and let callers handle a NULL return without guessing the error > cause. Thanks. AI review has an observation: https://sashiko.dev/#/patchset/20260629062546.141659-1-chenyichong@uniontech.com