From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52E1A1DC1AB for ; Tue, 30 Jun 2026 00:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782780189; cv=none; b=UcLaioRvzQKPBVVkQ4x1dmMhPrz9dDhly1PqBGcId7kwI3apBAG1QZSXoEIHmumz5JI5jY7NiDn9MSvl3tLNyeFn4sg4Ue382xlaozdAZwgGqjo2gZEQnnHjQs+PROwhlM94L1hd/cRvHc4TzEFZycRXtaqZNafUhzKd/5YTCtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782780189; c=relaxed/simple; bh=z99q+4jS1qUXEL6QiDspninof00PQ76INtiJ8XzQErA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PdpmWv/1FDmZGJi26BozNGZThoFdV/e3JMLx46fEEVs/NNeVe0J4L0GvHGELpSFcnl2GpEzCGnp6hyIYd+aXV31CBZ3g2gmASpPy/VG/3uHcSz69e5Ia3sYZ6y6CEMC+tZTv1E0IFHjeLEMI/r0PHzQVmAGVBXLv/rVJwARHO/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SI+wfI7J; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SI+wfI7J" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-493b7612475so4215525e9.3 for ; Mon, 29 Jun 2026 17:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782780186; x=1783384986; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8EU/r7lx6aT8TqQKRkjOJMDGUCG2zOVOTTvJBrER2oM=; b=SI+wfI7JASa6HrZygwYdZH98jvnkmfI6kz84RxiFMxdJ3ib0vM4KAMC6BvFi8uNySt 6DO8Y1zAR4YnMFh7zQaxyRbtfNMZ1O7B9n6ny9ANZ/wdoKQTePYWj6d2PWDDSn8rk3iI tSya6coVpMdHreA3gdttMLoH3t2gxXmm9m2uiED37KR/prQiECf0QQS2jNsFY1IRCwzn 7HRONz11BqZ7f3B25rrh4LyEZln3BeWiI3mn+HFu3YxnZTCkN/C8+A6Ga3XoHpwJf/8x wGNJaGbvCjdM4I2oGcyL37aXhJc3UY40r10SeWdR9pAWnmM/pgolSWjriCVD4BdDZ+Vb QA6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782780186; x=1783384986; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8EU/r7lx6aT8TqQKRkjOJMDGUCG2zOVOTTvJBrER2oM=; b=A7ZNZcnatemdDYPsK0f6Gk9Cdjbd40KusfzMO2BPea+8zdZzEymRKAfsBmks+iy0lF JofoQt64RYQrntcI/CCoMxFdp5POsKCX8TqfHCukVIGnfwcXFQYde3v3lh3nJXun6TBx uUYYYN8aZATKkuYYf3/MdwlV27/1uRCx+YOQbWbSroji3yTDY3ZNI5+aLVJQVd3S7O2r L2HrLHna/U+arUOxC05p2/i4qsZMU1v8fZd96CvNuSsg33d5Yb6x+5e+hdYUyx/vhgPr /k4cQ9NWjE3FApd32ygpHyk/zrjwAcscd+kW4ttm82/CRjfgt2Bj78OnWVw/wFJUggAC dGNw== X-Forwarded-Encrypted: i=1; AFNElJ8ZzH/bK3C7ZLJx82IfxVgQgSzDWkmuvAKgWn5MbuixzRNueYOLltqROlZ/4M2yN+uYfIEi+BhOI/+QjwY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzi8eI72GD2nAYYKUQWuTdDyt1pWoPR+eKdzh+WudloDZHspNCF y+GLtfgzzObkr6/3/mWuQko3nelRaoxt1xW95b2s/1fRzh2zR7fDjfrx X-Gm-Gg: AfdE7cm9d2GCTgtXmZ8HoB9KzBtiFikpE+B/5c1lwvvvILhrdaSa+8e3DbVxKbSma9V 3PcWJqx+C2cp0EKwX0yYg6P+RyUbPI0UQH4YU2FdLTjOZHREtKLHjrUcrGzQZRD/kZFPrM9fNw9 OlLiU0Sl88GyRJCwZp5XBlx+VlbRrQemDJG/fvmWGoZFnZF1MSdDpOM+VSTSfL6iOPHsh28RFMS bEi19fVezhh4PaNsBLfBAuS7dImzkjFqjIg4I1Iv6D8j5JHH4i2HCxUuTFANnICJfDhYOl2oDST +y+SiMuJ0hABf9mSnexh8uS/qDE7FeX0Mex4U062NIx/NK3oBeV6Lurc7QwURXeD/cJ0GQW6kcG HVrW2aUZRmhviKeaNlJWTYL8ErygnSeWzm1jIZ1qqMKHzuLKsHx/g6IEbYPws/ESX0Ft8ZyQ7bj OGJ82MJvFnP1/WgN9nmwoP5NqYFwC1HuWz/KpRSmKZ8PUkAGKO6os9Fkw9Hov9tfVV+8uXvkfuy V2Yd//tGg6H X-Received: by 2002:a05:600c:46c9:b0:493:b24e:649b with SMTP id 5b1f17b1804b1-493b827c8ccmr25844095e9.6.1782780185616; Mon, 29 Jun 2026 17:43:05 -0700 (PDT) Received: from snakeroot ([2a05:87c3:2001:7400:25e9:cccc:54ef:5829]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493b8cb0896sm29909195e9.13.2026.06.29.17.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 17:43:05 -0700 (PDT) From: Stuart Hayhurst To: linux-input@vger.kernel.org Cc: Stuart Hayhurst , linux-kernel@vger.kernel.org, Benjamin Tissoires , Jiri Kosina , stable@vger.kernel.org Subject: [PATCH] HID: corsair-void: Check size of status and firmware events before reading them Date: Tue, 30 Jun 2026 01:40:01 +0100 Message-ID: <20260630004003.579171-2-stuart.a.hayhurst@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Malformed status and firmware events could cause an out-of-bounds read since the size wasn't being checked. Check the size and warn on unexpected values to avoid this. Fixes: 6ea2a6fd3872 ("HID: corsair-void: Add Corsair Void headset family driver") Cc: stable@vger.kernel.org Signed-off-by: Stuart Hayhurst --- drivers/hid/hid-corsair-void.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c index 5e9a5b8f7f16..fdcc4b8cd272 100644 --- a/drivers/hid/hid-corsair-void.c +++ b/drivers/hid/hid-corsair-void.c @@ -92,6 +92,9 @@ #define CORSAIR_VOID_STATUS_REPORT_ID 0x64 #define CORSAIR_VOID_FIRMWARE_REPORT_ID 0x66 +#define CORSAIR_VOID_STATUS_REPORT_SIZE 5 +#define CORSAIR_VOID_FIRMWARE_REPORT_SIZE 5 + #define CORSAIR_VOID_USB_SIDETONE_REQUEST 0x1 #define CORSAIR_VOID_USB_SIDETONE_REQUEST_TYPE 0x21 #define CORSAIR_VOID_USB_SIDETONE_VALUE 0x200 @@ -742,6 +745,11 @@ static int corsair_void_raw_event(struct hid_device *hid_dev, /* Description of packets are documented at the top of this file */ if (hid_report->id == CORSAIR_VOID_STATUS_REPORT_ID) { + if (size != CORSAIR_VOID_STATUS_REPORT_SIZE) { + hid_warn(hid_dev, "unexpected status report of size %d", size); + return 1; + } + drvdata->mic_up = FIELD_GET(CORSAIR_VOID_MIC_MASK, data[2]); drvdata->connected = (data[3] == CORSAIR_VOID_WIRELESS_CONNECTED) || drvdata->is_wired; @@ -750,6 +758,11 @@ static int corsair_void_raw_event(struct hid_device *hid_dev, FIELD_GET(CORSAIR_VOID_CAPACITY_MASK, data[2]), data[3], data[4]); } else if (hid_report->id == CORSAIR_VOID_FIRMWARE_REPORT_ID) { + if (size != CORSAIR_VOID_FIRMWARE_REPORT_SIZE) { + hid_warn(hid_dev, "unexpected firmware report of size %d", size); + return 1; + } + drvdata->fw_receiver_major = data[1]; drvdata->fw_receiver_minor = data[2]; drvdata->fw_headset_major = data[3]; -- 2.53.0