From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F28BD37B3FE for ; Tue, 30 Jun 2026 03:23:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782789813; cv=none; b=sdwBy21EkWUbuL5rU7tKA+T/7nI3XyqRKRhL43rmET1/GJ97TtrqQ5aMoPlUCrpSU3cUb4QfqZj2Vg+j3WZgHlJyJr5TqQokeNZetF6Nrd+UrHNxN1OX8fnY1sf6sTQ2dfZ8iAQoIG8LgjnV1eG9rfhnuqiUCeN4tKDDSu93tJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782789813; c=relaxed/simple; bh=GEWQmwoNCJmCwgrNxAvDHtsa+YfvsbHxx8LGeyKpryU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=myHyR8yevueiOnPA/gLoN/lxGAXp+Xom1CM+Q1xVUP4mDNjTzarL9QsqZdO7pGymjxxJgZ3X2nagQ3GT98UZNnLnZ7T599fzOmc0UO1cxvDjALpeWRg3ynZdpesURprTfYRJLvVsEJkKBExC+OTewnC9L8ZKj32MKm+RQMsln2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OVmNhgxc; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OVmNhgxc" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-137335bc3caso8270348c88.0 for ; Mon, 29 Jun 2026 20:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782789811; x=1783394611; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1N2TEaibcJ7GIyHQYkU2Fx6MeyHpeL+NE+JylwXxFFM=; b=OVmNhgxcu7YW3GVPLv3VsnEDcYXAhusuiEE3OBaqVQ3gBMZSKF2qQmYXsz03Qtwqrt mzGO0zfaCRt7K6V8dsJegLHb3j/HPCBrbHoUtjvK8a61XTMiiWvdVfu2v5bbsKwN+bwT RMYi3kLORfyHfUlCTknPixTLZdMp5htS2ZY/OyzuFDNZ0nFd/nKCcrap5jhvP5+i/HVr h6sVlsVvCr1J6ySpF5lw9GuuT2kfyCGDgwxwesfmfc842jlhlxetNGMrRrKw2DVonu4Z Y0HCY6RWo1Khb4eVn20oUtLhjOYGLLT3pR0InvAirPMGTL3De/zKvnm0vywQwLVK7tpX UZ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782789811; x=1783394611; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1N2TEaibcJ7GIyHQYkU2Fx6MeyHpeL+NE+JylwXxFFM=; b=GCvXh2/+iOuni6ZiKCg5AzigBJEsqKm3UPgcP1ipJV0gOseaZsW7PCNs0TQnR+RIIN PG4efPV68A1eE0X4Q30ubdYJAwoTQOIVUzeYtPdHeVnvTMUMOpXC6gpanKWmjOupCMCv xP7y5lrXAFl2IBVqSVS0R4aXWonjHIfNFt/fYtpwAeir3yOja5zZYfvrNTVnEUVrkc5+ FRcLh0+yuARCk4InW/M4UtXQbsVEarhzyDfotoqAafh2Bl6gkP72jkQGzMILlVTApXdO zAE9pMcSYqwAkrINYe46s1cGKLC1qaslJ3akRXe8py2n1+CdIyMAETjDJur88UWM6Gjm Z7Iw== X-Forwarded-Encrypted: i=1; AHgh+Rq0CzpgCF2N7l8SeBWYfhrjFTKvMM6+b4vtaAAcZGS5WgnVCYVHLqNU6wj28xWeAZ6fVS15+9QPr3v0zkk=@vger.kernel.org X-Gm-Message-State: AOJu0YygYsgq3803dosy26EQifLZYuGk0384glHaRg8zF0T75l1KQlDe 25+isYaX1BqaExkdVwF2GvgE3k35j57prnDEIBUo1HlXDgJIJ5PRdQWN X-Gm-Gg: AfdE7cnHXl7ItL48vB2PSgD9PjGs6SS07U5X1LXP6JCQnWK+9LAc7qnj7ACNBTpby73 B2Pd617iFcfEWQwFgzC30yJR7RYCqUbkK1hySLrSWQJ48DqidQnOUttsn1EWoiYtgURftmeWNGC UrFAgxkPTQ45xpPUAGZ0IGK5/tcpjK9bOp3razymqgVeg2CTZR3T5SZs9KQyNnSzdvJ//ZvOTly xOwIPc460XIRs+zXC4dyIBiFD2Or+K+vYmI5b0XmAJ1GDm/NvuuJDdZ2Op1KoN4VLZCFCD95QSi J5uJi2O6mvAsSTxWxdxduQCxF3Pjz6dzjWGL8NRaw8Zq9f1aKUNIo+s7AWQ3M/h8WJntLNqxBCL 4pgdzffF+5dCqQB4jeejD987FbpdBfpbJDnwflYJARhBQsUW2vX6OBA3oPzk011uZ/0KD0XXffn SZEO9iUrRkJ/mI4paYDkjrPfSKUV/09upKRY3Xnw== X-Received: by 2002:a05:7300:a994:b0:30c:ab4f:9ba0 with SMTP id 5a478bee46e88-30ee14a4556mr1290207eec.40.1782789810939; Mon, 29 Jun 2026 20:23:30 -0700 (PDT) Received: from raiz ([45.251.35.28]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ee2f5ed29sm2992571eec.1.2026.06.29.20.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 20:23:30 -0700 (PDT) From: Mohamad Raizudeen To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: Mohamad Raizudeen , gregkh@linuxfoundation.org, skhan@linuxfoundation.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: iio: frequency: ad9832/ad9834: use div64_ul instead of do_div Date: Tue, 30 Jun 2026 08:53:22 +0530 Message-ID: <20260630032322.5805-1-raizudeen.kerneldev@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Coccinelle warns that do_div() should not be used when the divisor is an unsigned long, because do_div() expects a 32-bit divisor. In this case, the 'mclk' divisor is an 'unsigned long', which can be 64-bit on certain architectures. The correct function to use here is div64_ul(). Because do_div() modifies the dividend in place, while div64_ul() returns the result, the code was updated to directly return the result of div64_ul. This keeps the math exactly the same but fixes the warning and makes the code safer. Signed-off-by: Mohamad Raizudeen --- drivers/staging/iio/frequency/ad9832.c | 3 +-- drivers/staging/iio/frequency/ad9834.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c index b87ea1781b27..91df7ee65bfc 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -115,8 +115,7 @@ static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) { unsigned long long freqreg = (u64)fout * (u64)((u64)1L << AD9832_FREQ_BITS); - do_div(freqreg, mclk); - return freqreg; + return div64_ul(freqreg, mclk); } static int ad9832_write_frequency(struct ad9832_state *st, diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c index bdb2580e29bf..70b310488237 100644 --- a/drivers/staging/iio/frequency/ad9834.c +++ b/drivers/staging/iio/frequency/ad9834.c @@ -101,8 +101,7 @@ static unsigned int ad9834_calc_freqreg(unsigned long mclk, unsigned long fout) { unsigned long long freqreg = (u64)fout * (u64)BIT(AD9834_FREQ_BITS); - do_div(freqreg, mclk); - return freqreg; + return div64_ul(freqreg, mclk); } static int ad9834_write_frequency(struct ad9834_state *st, -- 2.53.0