From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbg151.qq.com (smtpbg151.qq.com [18.169.211.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C36D5356742 for ; Tue, 30 Jun 2026 05:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.169.211.239 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782798684; cv=none; b=hwkjm2S3T2q3NdEdzgpev7byoPI5FNPL4OT73nZD+22ff6xMYsRLozFljIlTopzSqmVnuAwWKSeop6e4994Y/oZedIYk02BrokNxZchtRt9pYrI1Ihre3v9ppSWXP5ktZgWIKK6+RiSuDee232s2hIGxS24CWntuBuvij0b6ulM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782798684; c=relaxed/simple; bh=ODY2Fvpkl7y6MFGWZod27aU9b6TrurBqcJbCy4rwMAU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=adBANXzmZkDSqmj5ak27wiL2eTy6BLrcAfqGzgJbc9S4P/1UW8vkWM45bquZxcTPCTWR4gGuWqRpsGrfIsSRQfmSLqXj2U0jTkGRILOhWbaAF9gi0GFxdSXovAf3+ZbecIiSERJtYkf4xlVCFYlWp0upY5ESpw7DFspIoxy4c88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=YxAffdo9; arc=none smtp.client-ip=18.169.211.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="YxAffdo9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1782798630; bh=ODY2Fvpkl7y6MFGWZod27aU9b6TrurBqcJbCy4rwMAU=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=YxAffdo9q5SCwdNENfsV5CaVI7GhOYNReNevdMujBY4175oTwOCTU41A40S16PHF7 sJThs+ZY+7jmec+ZHupt7UaJEc3hrHtY5b0vUNp+9gQdzMIbjDCXHr76GyA3ksw2eO m9kTbWEStD1BAg8DP68drlxJWX/6FcaSSoB4ejyA= X-QQ-mid: zesmtpsz3t1782798625td08ece1c X-QQ-Originating-IP: //MyUL6qnOjE0dEz/rw0pFjPXSMsJQ/YJu1N7s1UejM= Received: from uniontech.com ( [113.57.152.160]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 30 Jun 2026 13:50:23 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 2814519228433504085 EX-QQ-RecipientCnt: 8 From: Yichong Chen To: akpm@linux-foundation.org Cc: vishal.moola@gmail.com, ye.liu@linux.dev, zhen.ni@easystack.cn, ziy@nvidia.com, chenyichong@uniontech.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/mm/page_owner_sort: report get_comm failures at source Date: Tue, 30 Jun 2026 13:50:23 +0800 Message-Id: <20260630055023.197943-1-chenyichong@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260629203326.fbd5714e7ec8cbf0a22e7148@linux-foundation.org> References: <20260629203326.fbd5714e7ec8cbf0a22e7148@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:uniontech.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: NitOQvt5+uyuSU5rvDCGqRmHg9ZIJhifvP6Tr4JkVcA1nPiBVZPPRtmn kLkeZQ207FCdFM+IKZx/Hx8WAAib7F6ine6avRoTC/wLLEmf+i+RRTmpjEvjV6FEsn1Oig9 fDA4n54UsfNKuT0JKebZiQ1KOwwub3V9KX3B470K+9c19sRr8LhjlZyzi0IVGZRN039F6UE 9W9npjJYfNX4dOwOarHF4HpkciYtI+UxuQ81ZCmZZIR6erh3gjHhcDAqtMLwmMr1rk7gw+W WKVc9qEmXl94QWgUK7Z4b3F2PQg51wewsJVCVmmPcT41dN1Gh1GiEIUrRzqrW2JIRGBOZDe R29uvqHyANX3Yfy7OaTNWwYb/KfG0kXfhIyhDd/yfyHz+wJgbITUfvWVomYbI1Dq7L97iuc 0wHlG7xIR9ob/mx+wxoBalt7XNORnODBe+WYLXuiaUk5h3acrj21woEqqIW8aM0KbdcN7AV lRHEDlMGdJ7x+lDO4bbmmHi7cfh9W4yfzxzu4+IN59DGHooI+hzXRp4SqWYDO/OBTSMd/2M d4CgNmxhfvoNb12HuVF0L14JNAlAeQ/nZCo6PRfnweLpz6TMQ7WZhgKPTdk5pK4Hq7MIxHp hba42iWZHsgrEebBLyP2OBwV+0CvUV34JVj7IrOSASW2Xnskx+dp3aay2dX0uhsmm449wRW /CELHXygPo7wJe2QjF41GBc5syULtVC/QZijJqhYz4SIc2ZnWZXXqCGqVjiRxFrqFcLZ+u6 rYGaDGj3KdlAa78Rd9pDOMjzZdKFu3VTLuoavdTHyLv/IgqsbBRs+2fXz7q1cfDc34dI6FR O7FPfcZTr4mTjUZ+aUt5+9zORPfdY+RbsFcfygg3zt7yxc7wvkUt1Mv/q6PN+rcKRtQ0JEG P3tZHklx2yL5Nk30IpJjcR7iX2lzjr+tPhajS4JPnZsDmiP0Iae1NZIthapS7AxXjPP/9Fr 3MjeRuY2dn6luScVIjWjLelLnAavtuAsGKa5FDDvgvJKVWjzaRARyoFcG0aXFM5bb0cFAK7 hNKH80IM2fmkrx/6YAWKcDA51skILDYIxUQFrEeb2xkV3kvzMc X-QQ-XMRINFO: OD9hHCdaPRBwH5bRRRw8tsiH4UAatJqXfg== X-QQ-RECHKSPAM: 0 Hi Andrew, Thanks for pointing this out. I think keeping the parse-failure message under debug_on is acceptable here. The failure still propagates through the existing NULL return path, and the malformed-record dump is diagnostic output which matches the current debug behavior. If you prefer reporting this in normal mode as well, I think the minimal change would be to drop the if (debug_on) guard before the existing error message. Otherwise, I would prefer to keep the patch as-is. Thanks, Yichong