From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f53.google.com (mail-yx1-f53.google.com [74.125.224.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6E513EC2E7 for ; Tue, 30 Jun 2026 10:12:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782814358; cv=none; b=oep60IRj+sEZtLunrD/K9tF3bL17pYBKhhwJ5ZMoO/wa4mHI2peBm0G7A0ZFlV8a04Wl1tV/4yQg9Cs3v8mQ0DnGXqouJ6IOcnHBVI3an5+dwS0oNCrz5zE+p0y9VWFY8ngtaFxXdTUlK9hqqmkgsCUQQUVpbKQUaGbOkIwnxvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782814358; c=relaxed/simple; bh=fpVV70lRt6gaxeu9NgkMR0EjFnDbIYv9+3uh2IF88IA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RuHFMsB1uO9gipCycAkaJuQOLHvvC0LCfnBF6CEkULSQKeKZHtDXK2C9+gzreF2Fg0DyIHujLBzZSMOJPcuoqZkv1EW3E+/OqMsoc/DKG6SfL8w/9sgga0ivGJBxpbVFiaJceS2IzUqNrugshM6RYp94+qyE8epD0Z/F602d3Zs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ahCmdf53; arc=none smtp.client-ip=74.125.224.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ahCmdf53" Received: by mail-yx1-f53.google.com with SMTP id 956f58d0204a3-664ee752958so1655538d50.1 for ; Tue, 30 Jun 2026 03:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782814355; x=1783419155; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ME3E5bLTc9knmTM+lqxIbMll01z0y4z3RLqE7f/es5c=; b=ahCmdf53tcQpDbVjnO6xYQeZqIqITEqGnTKbGSPt6OQUlf/x7W3ZMm2L5mgjrcE5Ho fIPTFoxDwA806NuteKa23Thn6h/8G/Cr5LUpPyvPu/d3LOWrXv18eD86LnF8GiOwHd5m 5J1murSrwPBT8cEuf7Mq/8dxcEeaUkGOITZ2VE8ftuUXxqvcBimd3KgFzW4jVxHFwVBX LvduVyzK41DOiCU8WQXY/glowyhOpDKZa/8QixhaIGjsVBTyj4gifJLZFo4lYP13jEm2 Ko910SOyuHj8CX4LyVh66XcUgH+5pOdJew3p/bBKjO14hrkfLaxCvtLnjBLT44nEt7KA v3Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782814355; x=1783419155; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ME3E5bLTc9knmTM+lqxIbMll01z0y4z3RLqE7f/es5c=; b=IX3pJjdWXsS+nhscL++SYUyWwcGXqFa9mrHx5KTAbWox6kNZajFPkQA3TATmoJUEiF WrhyhH72kl07g+1w/hX2Zvj63i8zbyivyIjK22SDvoTgQEVI5KFv7niGZxgFeOn24Tg6 ry/0DDPuuFx4rgy5hIz3zTBmlThy6LkCpoL/17agNHcHUS/EVE4VHj+K/blAOabyvvlD eG1JaqWwkYg9ZSlTsoQYM6JPxROo0gVeK1oh8AgM5gbMlRLJQtGUAvMvgxWwbFfY5FL2 CBORhExvMeWNMmdP4oOOQDzyeyYcSVQS+l83ZjjC1MX1GzJs1lHuML1v1blA+ZaOfjr3 5RiA== X-Forwarded-Encrypted: i=1; AHgh+RqJ3/MvCPciJGTwacNLWmv9cuvVUqb2/6+hLPMwldAYmM/ZZZ1u42cJtaJuNwQ1YMnjM14BenhaEDUGA0E=@vger.kernel.org X-Gm-Message-State: AOJu0YwZhOtMYAjn3tIyw6gepZdD62hN0AnBuoQVEWJ2TeUjco+T2v9N J0+1rk1AuLvwxkwlVu8ugRmw5b0EC6UOrjcGGnVwhwCK33srqz6cnDij X-Gm-Gg: AfdE7ckUOtUf+TswahSmfvq/Nflw5Yyf8gT19y6JBEOAgaGPkiz9FjRHaN6iMoDKuEf +7bNHXe2ixNa/K7v++dVvC1zh6Y8XxRwK6tydXikkZW+te/FTimbeT9IKPNwFJ7Lc6qLLITkOcS O3MmRB9oNvAphDpbxl+JSyiYL82u/P3OJCilmc8B1tYnDIr0VVmDop0HLZxo/E2ccALnwSDR9WH e/l5UwJAz1bjZNt1Hua35xRXkQh/fqXBH3Q7tRJP5G7veBjB159JA5MO0hwIX8Qt7qmDnZ6LYaC CbxKpKcNY3YbfLDtWteZ/3hubLOwnqto1uwTlDVmZN4UIO++ZzSN5HGJQ63p/1uMxcZwRlAzXdf aEBX7J+9X3sfrQyvMsXjzYt4K3MSPVQtFTRerA76J426AVjqAfvq9U4ZHJD5BQZ0RoamWOczyDv 1tlzfntOWKypzTCA9KYTxU51fUVQ== X-Received: by 2002:a05:690e:140a:b0:664:deaf:b25e with SMTP id 956f58d0204a3-664f940be22mr2947968d50.0.1782814354875; Tue, 30 Jun 2026 03:12:34 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6650053f901sm725450d50.1.2026.06.30.03.12.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 03:12:34 -0700 (PDT) From: Yousef Alhouseen To: Petko Manolov , Andrew Lunn Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yousef Alhouseen , syzbot+9db6c624635564ad813c@syzkaller.appspotmail.com Subject: [PATCH net-next v4] net: usb: rtl8150: handle link status read failures Date: Tue, 30 Jun 2026 12:12:16 +0200 Message-ID: <20260630101216.10365-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit set_carrier() ignores the result of the USB control transfer and tests the stack variable supplied as its receive buffer. If the device rejects or aborts the request, that variable remains uninitialized and the driver chooses an arbitrary carrier state. Leave the existing carrier state unchanged when the link status cannot be read. A transient USB error should not be treated as link loss. Reported-by: syzbot+9db6c624635564ad813c@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=9db6c624635564ad813c Suggested-by: Petko Manolov Signed-off-by: Yousef Alhouseen --- Changes in v4: - Target net-next and drop the Fixes tag as requested. - Rebase onto current net-next after the 24-hour repost interval. drivers/net/usb/rtl8150.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index c880c95c41a5..d51e43170e03 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c @@ -732,7 +732,9 @@ static void set_carrier(struct net_device *netdev) rtl8150_t *dev = netdev_priv(netdev); short tmp; - get_registers(dev, CSCR, 2, &tmp); + if (get_registers(dev, CSCR, 2, &tmp)) + return; + if (tmp & CSCR_LINK_STATUS) netif_carrier_on(netdev); else -- 2.54.0