From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FE553F0AB6 for ; Tue, 30 Jun 2026 10:50:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782816652; cv=none; b=sGKsQl8PSPc1+MKd6UckBKCrtJgvJ7aSntRAlrlxpigSSoiORVNn84+sKUmARyzxEKKqbQG98hhBo9ifNhCmuS7R1d5u4nsw+wK8gEGSbzHU+ryzr1ork2Cw+URLIQ9NYYkQTggO6klhj7FS4dyXdzep+0c+UKsHNFrRyrJdN0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782816652; c=relaxed/simple; bh=JXWm8cPallOUrZBAAumtOBuCZZmD3WVwKyaijIbKTj8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kcSEWkPzxnTObCnKhSHd2r3MfmCiK3MNQbHC4XQgxvMGB8J556ZEPKi404Gu24gH91rkA9qe+RRMcb3OV5I9mufwcz1BSLpbjWkGDlyaampc6jY43H/uF9b45eDnyo+tOi1Vq7+Ft8xSpakhPHD57e1Wgx5iQZ5s6fP541WFWhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c9CqwO/8; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c9CqwO/8" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-804e46366d7so35657657b3.2 for ; Tue, 30 Jun 2026 03:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782816646; x=1783421446; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qeV2YpaisUEbHUoB+xezAM4vG3ItfsDn3MWCwvfDv1A=; b=c9CqwO/8yfubEWwHEZrc5Qypl/4hpRTJEXacRnXTPAgTcXRo1HUsGBSGN9y+3nrLE1 QaHyz6hfGN2tntbMhCSF+fM5CVq3Kq4HWxne3SXoZ2rxqfumJsV7SCdPRjCJok5UnVGJ 6t1yTPlA/9giogQADPXq2f6KNGnxORbtzYA0IGP5JQOOSsDnh5MtD+GkFKha00P+W+FD mxKaZ7Vi7GTB/Pbdf4WnBI25RFvanwJbav3Y58wH6vjiKMnQ+srWlBj1wDzOux8SXjKM N9juYNAgm3a4B+D7UHBwVb93KN7F8wvaA5g8R5bGgL8QJNlf2HMzCuhjxnwMCoW0ZJhJ K+GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782816646; x=1783421446; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qeV2YpaisUEbHUoB+xezAM4vG3ItfsDn3MWCwvfDv1A=; b=pQhOHtynxAsSnGrrWgck8yT+7XlIlPxAl3/+e2P/xWhcX1ocdQWwzgnabOV6hdTxDm SVrgS0hbwgS2DK1jN8sUGuVGPyLrhIrlDbxQtMOebC0Gebp627gx7Q6aveAMspRJZIhf KCQdfsUJsHLqRoZll324AL/02PadLysxJZTb33x4Gq1/tZUy4BtkxzpePRu7xWGdoBPv RsuuwQzMLj9SMZGjTTFVqu66TJxWASPErhFX6E/mSJwYuZLefeC7g8F6fgHh/t2wvG3c eRT65lF2810WywmUeq0iesOqjKN5npfOQHSvIgS8z8FIlvFxU5sqZHm9i8Dl2k9+7dL6 Zz1w== X-Forwarded-Encrypted: i=1; AHgh+RpHoVzNZ/L1jcKF0yRG7mdhqPlpDIVdz4pJ/ZLBdR95hv2i7thwjyOz1AbfRkb7i89PN+TAs6m4OSNvZWw=@vger.kernel.org X-Gm-Message-State: AOJu0YwhxH1NWy+Qeb/PGi7X82yFfeQhbvoV+nRp9nA8EtCiTkh4h/do zF8gcq3R4gt+STi/UIogid61Tn9GLdicb50wP97cNz0xxhdSFolZxHVi X-Gm-Gg: AfdE7cms/h+kpB7wn+mOMOjOWXt6WxMIiRIPIZf44X/u9HvTV6OPn7y5Focz/pL94xE 6wN1M+P5Zl5pJx2FnzYOiTIBUiB0f8MSH1UrlihxbV4oLLnyeQXgwK7XdvxL/qI66t73r64Lv0H XbH2d5EUHEtnsj8PIPP9Wbj4zQblwtt5jCCZ1xbw58GZJY6Oize/4npwwxTjLaHeZ5MKXuvnDAF GPm3c9RBk6xN6UBDL0alDxqsFLKR1CkQ8MzpZY1IBtqmb2kyieTCCZVD+UpxnX2lc/Xxef1Kl7I z07mR/uYoGRTNyERKaWJeORSxCtwxcftdJpZp3kzUtCD1TRSMu8IJIswvSpwAk2Ru5VTupE3bNG kIO25Slcz2v3QiKRQJJ4p8ymZa2HBLEVP5crqtyqiV9ZmMH2wnlkCCWxEvK408WuBE26WlncuMl KjnA5zIdRWBFo2VQdJ0H3nrR8eXA== X-Received: by 2002:a05:690c:e373:b0:810:78ce:a003 with SMTP id 00721157ae682-810da315372mr35196737b3.55.1782816646110; Tue, 30 Jun 2026 03:50:46 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 00721157ae682-810e7288a71sm9278217b3.8.2026.06.30.03.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 03:50:45 -0700 (PDT) From: Yousef Alhouseen To: "Lee, Chun-Yi" Cc: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Yousef Alhouseen Subject: [PATCH] platform/x86: acer-wmi: reject missing gaming WMI results Date: Tue, 30 Jun 2026 12:50:33 +0200 Message-ID: <20260630105033.53967-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit WMI_gaming_execute_u32_u64() returns success when firmware supplies no output object, leaving the caller output untouched. Gaming getters then inspect an uninitialized result value. Return -ENOMSG for a missing object and -EINVAL for a missing output pointer, matching the existing malformed-result handling. Signed-off-by: Yousef Alhouseen --- drivers/platform/x86/acer-wmi.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c index e0eaaefb13d0..81d354c80cd2 100644 --- a/drivers/platform/x86/acer-wmi.c +++ b/drivers/platform/x86/acer-wmi.c @@ -1581,7 +1581,11 @@ static int WMI_gaming_execute_u32_u64(u32 method_id, u32 in, u64 *out) return -EIO; obj = result.pointer; - if (obj && out) { + if (!obj) { + ret = -ENOMSG; + } else if (!out) { + ret = -EINVAL; + } else { switch (obj->type) { case ACPI_TYPE_INTEGER: *out = obj->integer.value; -- 2.54.0