From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3374404BFF for ; Tue, 30 Jun 2026 10:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782816778; cv=none; b=lZk2/AyKiQR6PRA7I21DrbDmDK7GqMNmwc0mmzYi+Qc/12FUVDznIaZtcjsXNew9dBpIK20mB1detbm4qT2iT5a8ckgfMEp2QkQbZQ7ZqvUadrytt+u22i4jijJ0f+HSc98lyDKLyVdb1ye7yUZzocRgClKJK3gr9NvwnCnu46Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782816778; c=relaxed/simple; bh=ZGzt5IG+INAc0Z7HeVhKM5dtyeIxmckzQq/YLXhj7HA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=E/VuXqf/4rEgrWHKkv5VOfvtA2Dyf8zagUcI6zvRdICzbBaC89T6XxYCB+OdN0cuRdIg7SNCoiOuyTn9h6Ax+s6EeWU2b+TjR61CPwXG4nh0TKWha58T39zxtMC47y4uydlfKBuWEqDUJmYQ4BvSLOrPogP6SGlyIxRHlVtzVcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EyI0Bpk4; arc=none smtp.client-ip=74.125.224.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EyI0Bpk4" Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-664c7dc6830so1566247d50.0 for ; Tue, 30 Jun 2026 03:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782816767; x=1783421567; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BfF+iXeJWMxuPhgk04zCk6fGh3gRO2aBc22OA8kCBN4=; b=EyI0Bpk4mY7MrXdF/3pVKos2TndkWIlxS63pSWMOx/AbcRikvnstFJRGrPUSu7vRhW fFpTVtI9vsT1wZakZayymFCmyjoNvg76edEBfCiEOjL4xiwCi4WvVj+ktXFOk6eQu1Ma 2LXGUdDQVn1pkbq9CU3oV5U3XQo7ZQYb76dd8B2OkcfkSr/6y1YEr2g50nVxHv1WOKmP zBuCF8Ksnaze0WaAaa90nN2McLAaTJXAvPMh9SfA/duRLq0q3eX4QFiNfLPRuTmbvtEM jNdOLBKg/UOXMo5phy30Yqedp3n4oyHEYGTdqZzGUcO+NYv40gzF4wgX6OrQ3cWNu65X oSFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782816767; x=1783421567; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BfF+iXeJWMxuPhgk04zCk6fGh3gRO2aBc22OA8kCBN4=; b=bT31ZDzcBTlFbQdfnx8M0qGRf//u5WXxyyYRz/iVV2532K395MiGbxVo8lrsJKuqBn 2XHpwaJRvVN0Ehouiw3ktKzgu+nsSUS+caipu1rqDe+mmL2RE8AYyUVhBASilYno4SAO ZetVKfXyINpW97/xD6vNeI7LnBYNQ6wtCKtPPC5IgTP0N4YKaPPQ4+hvMLTvwlWgqKua 1ZC7QHlO5moqF+k8dX1ueeYXJS8IIOZ0Jo/OZkNLpOsKpHxXt0+JKJNeai8TocXDEzUE YLhjDBFbL7yF2fMH5zV33dU3tsr1+qE28c6MMayLMelZuNV8ZeXEBQdTYYToHa1q/Fs8 YV8Q== X-Forwarded-Encrypted: i=1; AHgh+RpognB6+Ezu4m5lATb3ohRDeNMKeSWPB+PNy9zz6f1UTabog3eqvoP9HFrpCGEuXog92UMV9F7i5B6btaA=@vger.kernel.org X-Gm-Message-State: AOJu0YzQZBIAdff3mVT6seKB5OYZtXzdBi4zNsEuopnTdHMEQQQVhPX8 prJj9skNIFeriibq8GIq916NKcgCGeuIp/YuYNquWz9LZP4tIAO0cBL5 X-Gm-Gg: AfdE7cnoDGqipQP8Q1rYd7TeiRD2vUn9t/kjAiEsgFCsvc9bEhbK9CWLi44mP/G6liY S6Qyo8mMnaDcaPcctSEJDo2/Gz4p4enG060DKkFFQrrJvmLQP8db96XmWelSkQhLGXUfqln+Wsh N6hjp3cuyxD0frvKOirBWViMpE5Yw23rwrxE4scntYCrqcJlP31a1QVlrqGqfVxbwAxLkD+wT2A oxE9U+SJ2svVK9x5O9xxMnI22smPo4lpj95DViXX+SgL1raZW6SFzysl4hhn0AaYCEAA8R7xJrI +sXd1otYSdTcpK1D8rXh0Zd2e26qKXaVF8/vlNdJsCDe2Zb3tKXVuxp5xjmxuXWZv4P7FbK0Esx 44Uj3m4gHAChJq8mbI85Ad0nI2KP8SFRKtrXfcbyOR17QxdoaunftADW0UBDAI80XHAmbvxndIU 2iOpCq80IVJUbvkVbq+YIPCWIL1FsApsz4KCoU X-Received: by 2002:a05:690e:140a:b0:664:aa09:a29b with SMTP id 956f58d0204a3-664f96e482dmr2719441d50.18.1782816767360; Tue, 30 Jun 2026 03:52:47 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-665016d577asm693402d50.21.2026.06.30.03.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 03:52:47 -0700 (PDT) From: Yousef Alhouseen To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Krishna Chomal , "Rafael J . Wysocki" , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Yousef Alhouseen Subject: [PATCH] platform/x86: hp-wmi: handle positive BIOS error codes Date: Tue, 30 Jun 2026 12:52:34 +0200 Message-ID: <20260630105234.54638-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hp_wmi_perform_query() returns firmware BIOS error codes as positive values. The Victus-S profile callers only reject negative errors, then consume output fields that are not filled for a positive firmware error. Treat every nonzero result from victus_s_gpu_thermal_profile_get() as a failed query before using its outputs. Signed-off-by: Yousef Alhouseen --- drivers/platform/x86/hp/hp-wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c index 8ba286ed8721..50c5a1e152dd 100644 --- a/drivers/platform/x86/hp/hp-wmi.c +++ b/drivers/platform/x86/hp/hp-wmi.c @@ -1825,7 +1825,7 @@ static int victus_s_gpu_thermal_profile_set(bool ctgp_enable, ¤t_ppab_state, ¤t_dstate, ¤t_gpu_slowdown_temp); - if (ret < 0) { + if (ret) { pr_warn("GPU modes not updated, unable to get slowdown temp\n"); return ret; } @@ -1907,7 +1907,7 @@ static int platform_profile_victus_s_get_ec(enum platform_profile_option *profil ¤t_ppab_state, ¤t_dstate, ¤t_gpu_slowdown_temp); - if (ret < 0) + if (ret) return ret; if (current_ctgp_state == 0 && current_ppab_state == 0) *profile = PLATFORM_PROFILE_LOW_POWER; -- 2.54.0