mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jori Koolstra <jkoolstra@xs4all.nl>
To: Christian Brauner <brauner@kernel.org>,
	NeilBrown <neil@brown.name>,
	Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jori Koolstra <jkoolstra@xs4all.nl>
Subject: [PATCH v2 05/31] autofs: drop redundant S_IFDIR from mkdir
Date: Tue, 30 Jun 2026 12:53:34 +0200	[thread overview]
Message-ID: <20260630105400.68459-6-jkoolstra@xs4all.nl> (raw)
In-Reply-To: <20260630105400.68459-1-jkoolstra@xs4all.nl>

vfs_mkdir() now sets the S_IFDIR type bit in the mode it passes to
->mkdir(), so OR-ing S_IFDIR into the mode again in autofs_dir_mkdir() is
redundant. Drop it.

Assisted-by: Claude Opus 4.8 (1M context)
Signed-off-by: Jori Koolstra <jkoolstra@xs4all.nl>
---
 fs/autofs/root.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/autofs/root.c b/fs/autofs/root.c
index 186e960f1e23..b36439f4521e 100644
--- a/fs/autofs/root.c
+++ b/fs/autofs/root.c
@@ -741,7 +741,7 @@ static struct dentry *autofs_dir_mkdir(struct mnt_idmap *idmap,
 
 	autofs_del_active(dentry);
 
-	inode = autofs_get_inode(dir->i_sb, S_IFDIR | mode);
+	inode = autofs_get_inode(dir->i_sb, mode);
 	if (!inode)
 		return ERR_PTR(-ENOMEM);
 
-- 
2.54.0


  parent reply	other threads:[~2026-06-30 10:55 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 10:53 [PATCH v2 00/31] vfs: pass S_IFDIR mode to vfs_prepare_mode() Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 01/31] " Jori Koolstra
2026-07-01 10:08   ` Jan Kara
2026-06-30 10:53 ` [PATCH v2 02/31] 9p: drop redundant S_IFDIR from mkdir Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 03/31] affs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 04/31] afs: " Jori Koolstra
2026-06-30 10:53 ` Jori Koolstra [this message]
2026-06-30 10:53 ` [PATCH v2 06/31] btrfs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 07/31] ceph: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 08/31] ext2: " Jori Koolstra
2026-07-01 10:09   ` Jan Kara
2026-06-30 10:53 ` [PATCH v2 09/31] ext4: " Jori Koolstra
2026-07-01 10:09   ` Jan Kara
2026-06-30 10:53 ` [PATCH v2 10/31] f2fs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 11/31] gfs2: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 12/31] hfs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 13/31] hfsplus: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 14/31] hpfs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 15/31] hugetlbfs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 16/31] jffs2: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 17/31] jfs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 18/31] minix: " Jori Koolstra
2026-07-01 10:09   ` Jan Kara
2026-06-30 10:53 ` [PATCH v2 19/31] nilfs2: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 20/31] ntfs3: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 21/31] ocfs2: " Jori Koolstra
2026-07-01 10:12   ` Jan Kara
2026-06-30 10:53 ` [PATCH v2 22/31] ocfs2: dlmfs: " Jori Koolstra
2026-07-01 10:13   ` Jan Kara
2026-06-30 10:53 ` [PATCH v2 23/31] omfs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 24/31] orangefs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 25/31] ramfs: " Jori Koolstra
2026-07-01 10:10   ` Jan Kara
2026-06-30 10:53 ` [PATCH v2 26/31] udf: " Jori Koolstra
2026-07-01 10:10   ` Jan Kara
2026-06-30 10:53 ` [PATCH v2 27/31] ufs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 28/31] nfs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 29/31] ubifs: " Jori Koolstra
2026-06-30 10:53 ` [PATCH v2 30/31] xfs: " Jori Koolstra
2026-06-30 10:54 ` [PATCH v2 31/31] ntfs: " Jori Koolstra
2026-06-30 22:37 ` [PATCH v2 00/31] vfs: pass S_IFDIR mode to vfs_prepare_mode() NeilBrown
2026-07-01 11:04   ` Jori Koolstra
2026-07-01 10:51 ` Christian Brauner
2026-07-01 11:07   ` Jori Koolstra
2026-07-01 12:42     ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630105400.68459-6-jkoolstra@xs4all.nl \
    --to=jkoolstra@xs4all.nl \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox