From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C2FE2F8E98 for ; Tue, 30 Jun 2026 15:09:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782832184; cv=none; b=fXLcdL9FiQXfUmCUkbQ3AVQQ7E0j+9Ym0Pp2LZ8b5Njywq9VwgtMyC/tVKxpbkMtnjCdUrwt5bfNclXLD2PlVVeSEhiJiOIoPmdyAqJzNGKketqDEeP6RHOTtBHIV5SEMK6gyHeWPWD8VBh8iiWrQfPV959IIEHCOPBGY9pwl8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782832184; c=relaxed/simple; bh=4SB7xtE7LLNsmMby+vVxbe3lzN/XHMxMCDPsRtqIgyA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=netaieAkqzyZcpcVHo25VnuTYPvPBQzCnGkt1dXV0+45H8MyiZXEAQ1kFQnAUOJtXWepUseqw2yCSzd1izTDqs+8shFt7uU2a29mkKrtepPZg0VP01Ng/1qnM5jgY2J1b1MZ3ZHSkECAM9s1ak8V1eVsvRRo37gZNhhoJv6mlPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K/hOiKDf; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K/hOiKDf" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-13981833e13so5577339c88.1 for ; Tue, 30 Jun 2026 08:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782832182; x=1783436982; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iy90YGAiyQKrVGwXUqBi9GraSvwkuFALJaJT7TVoK6Y=; b=K/hOiKDf9W3nlTQWw50wIgXstxnlMNVo8vVo/ZVPKOMVAwO0/xktJKCoPn79OTTEt+ FmTPm3iHHr1RNHWJLBArYhgyuRYXAS5E3vDHYshO0BcfVxlYUQ0A8YylXhvKMbqBp7Sc eHHRMM1OVhTaVOVQNcru/4/iEFop+PsnEl2LOfL4QuTqS+YgyEyahaIAJjesfYO/juN/ FYsPipEY62knYh3iGmDVHBMzhKNSJXPHPNmgIjlTvxZgErzhdOtpieMKHs5a1mEBwHWy GLp8iSrbV6/Dbxx28dQXrpoKfL3u3HhJMyCwCz7dgX+VfiP+3sBDNWuP8t6qLfTuL8DI /nLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782832182; x=1783436982; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iy90YGAiyQKrVGwXUqBi9GraSvwkuFALJaJT7TVoK6Y=; b=NzfxkjoQZW9QgIzMxzon4qKSteGVcPRAOexsGOnE58Wi0tjZIrn90FzSN2cNF6lwOb ZcsRL/TQmo248b3uYDJLTvrmk9SfsyrXGtnN3JKO4P9www0StVpNelvCG3TttDDeX7ZT oglyjmZJn9kaiuTOCAZkmNw3aBjVLGtFOp5+39Gz/eDP3v4NPaVm7MkxL1+lBaCxmu9X ImxVzWuobjmjWuzZHoBFBLZCccaSzJqzmPR7qNeOqsMVwEbma3F5PmlerklY7b3JrbUv uoBvzhFeI/L0/C9TrDJjl7h6T1ICOXIFSwayrjJKG+WaGJMgmy9elZ6M7yVLbVaGM/e+ nRFQ== X-Gm-Message-State: AOJu0YygGgAFG0A4fUgwGbGSYDACkl3NW3mF8GlX165MOKOppu52c+10 VVBJ956800jiF3lL2UGwEyo91BfMRcQ6vE/XHUTxBW/ZP2F9eaAtWT/JiRNzS2P0 X-Gm-Gg: AfdE7cm8vdKjt226WAgvHQq2scN1Mw4V+ySQpe8kknUqLI5s8ouJIFW8PQ7JCepdQHu nCUI38fRO5lFtTz09/LlaMNK8JgaEaniMtljmWI6WmwqLve72SPFuQXy8/OugbMzX3wIaSeGTRW bMKDAFbfC7CzOFv6huBh4KUk8k1KVL8xllsvrFQTKzLJsQJqPE0EYmY3NWiozFmq0a0+js6xtva XpVRG1v7Vgud0/WJY2LffcyH/le6v/K2qVfBV0aiY7aMYA5G8NinNMTr6wdaWgHyewkvFDaDhUo BtqQle/iK/KhtKwWblfvcsRLuAEYSG/Ox+QxlnULvHN2pjNVjjs25vZs+6CoeZIOdUgywIGUeuw OKDkv5bqMfQmCuKyTOt9mBvWl7Kd+5QXzs7WWx0YdphdHS1XRUaUJp774+4IQdpgJQ+DGLRPeFB /cqm7KVzShbOw2QAe1 X-Received: by 2002:a05:7022:1e11:b0:136:c565:e847 with SMTP id a92af1059eb24-13b2a1c05f7mr2517782c88.32.1782832182454; Tue, 30 Jun 2026 08:09:42 -0700 (PDT) Received: from amd.com ([165.204.156.251]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b2a9b425asm11369849c88.0.2026.06.30.08.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 08:09:41 -0700 (PDT) From: Paritosh Potukuchi X-Google-Original-From: Paritosh Potukuchi To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, paritosh.potukuchi@amd.com Subject: [RFC net-next] bonding: Retry updating slave MAC after a failure Date: Tue, 30 Jun 2026 15:09:37 +0000 Message-ID: <20260630150937.3508222-1-paritosh.potukuchi@amd.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi all, I came across this TODO in bond_set_mac_address() : /* TODO: consider downing the slave * and retry ? * User should expect communications * breakage anyway until ARP finish * updating, so... */ Currently, if the dev_set_mac_address() fails on a slave, we go ahead and unwind the bond and its slaves. As the TODO suggests, one possible solution is to try setting the MAC again, after putting down the interface. This is because some drivers may reject changing the MAC when the device is UP. The solution I am proposing is as follows: dev_set_mac_address on the slave - If this fails, temporarily stop the slave - ndo_stop - If stop fails, unwind - call dev_set_mac_address() on the slave - If this fails, unwind - Bring up the slave by calling ndo_open - If this fails, unwind If dev_set_mac_address on slave passes, we go to the next slave Before working on a patch, I wanted to get feedback on whether this interpretation of the TODO makes sense and whether there are concerns with temporarily stopping and restarting a slave during bond_set_mac_address(). Thanks, Paritosh