From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B175337BE7D for ; Tue, 30 Jun 2026 15:26:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782833205; cv=none; b=M7e8AHOqgWaG04kx6w7ASJz/lb0e3hu3fCRquUtY5KeWvaW4yt16wbv9y1AOpBEMPMjuxt1W+uJY7XHSgd4TRUss4oE65om2Ol0a7qbGzR3rhtZGeTgRAVxOpSivr7N/A3oh5aBtZbyZ9D1eq2BAY/VEa9gyr3U7vYe34AhnhHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782833205; c=relaxed/simple; bh=doSc5723l2PG2WxzuN3Ze28Lq5RF7ENx8sRWIhTL2QY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=k0nW/YS/rhwuzcHw2UKAKVIlkM+etjwAdPrHUDvb0n6R+w3DdO0ktswybJzDigQAKxZGXHLD/w7mmn5YdY2b2YKTfXUGnMts0H5XjCzmiUrL24qPaZfN92mcoSK8KGE/7nJmiaCJIcqO3vUNG02JNd1/Ih7laUrPo0qs+Tt3uA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nstg+tOa; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nstg+tOa" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-13b30f3d1e5so291004c88.1 for ; Tue, 30 Jun 2026 08:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782833200; x=1783438000; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=d35k5C/hmD6Rx5Ssjkeq6spgQa2fwGIsCqaARISvLAs=; b=Nstg+tOa1wJunxqH4j+NrpyIeTHVEEfilyQ/vUAG9/X8I4dnYK2LhjEHzaYfXT83so lpd+TrfwYLbIX2Lzz4eenjlOvECNI0TZj2s/E/ZcP12JkXQgtEafUamwzDzGlKG1SqOc slwvaEK+e3Gqx0QVcyvCqy5ULjD/UGgmAaM5yuSfWRz9dy2ZUlHQapzTc/U75M/nMV7K wxjJnQedPUBdO4ua42wty7llHUz7eT4Y3U9ckVWJv066CVOc76zWTwJ6m1J1mPEIiln0 lWWhskJSyt853zL2GhofrpOOfN1dfsmzeUFHSEtTlG90wF+rWcEjhhOGvCujmvaR0cYs 7NjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782833200; x=1783438000; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d35k5C/hmD6Rx5Ssjkeq6spgQa2fwGIsCqaARISvLAs=; b=l4QXmgPdaRFY6cad4CaiMPy3Jdoc4lFmTX6zNMCO6G+4qJeTYmtVaLiNWlpo+BuPZQ OCGvQpOfTgsWDhNp1wfE9Pj3lSue9AMTGl2Hlqv1Iy/3g8rLRp+DnyPn7tqJuM1fAtv1 dU3zehbv/zFuV5gq7LFkyKkXN6zKB5yFddO0v0y002D2PHpbWXEdtj2h1Dwzpg3CMy7z WF8aUguBt6O6amvoH3UAmeYSk05BCL3ZWLO1Z2nTugGfRU4AJMUdYKfnUthT0NsQURrE vBhIp0z7U6OLWTzOYMmdpD8WH1fXzSKtM2L6x+HwOnltdkFnaYJXSBKXJHPfoIbDKhFz GXPw== X-Forwarded-Encrypted: i=1; AHgh+RpWsFAwKfTz1+yX36Q3LQhag2dLoXQeQzZ2OrFHeTqsZ715rxVGCzVWtpYvqKexxYzcEfOLUgnml5WW07o=@vger.kernel.org X-Gm-Message-State: AOJu0YwSgqc7Y2IFkp+VIRy6mhDHDlN45vc4bZ+2zUXHZIPf7CowjWQQ DvXvktTjBnzqzLgj08BImPba8ZCP+1U2kSKfKVF6bR5gkLXPdu5qqj6o X-Gm-Gg: AfdE7cneQV68x00Qi7VVpSu7CrK0Kps9YusDyvf/TN/ZBzq6eVgFd67zlFQ+LhDMTTy IOk20A/Rcz0q0jMPnej3xf9wxJxUSFahlKzenjGxEDBnTF0DxKhPQ1GsCGVaEUIJHoXh+c695zT TQnmC7CPtR9+FhbV6lU0sZVOR8kdkhgfUEC4tIAY18ZWBG4Xwpiam4TUiMk7L64pVhrmOcX/B7y FP0p0ddHdNB4ZU+Y6SHjQI7XQGXPgAmcmTi4qSnqR3+C/dLE4H5diMCWPOqiCl3vGBHsXSDfhtH IuXUrrlpOl0WqJbOh8pdLzVjn8jIakPSxbCMjjpzGujcBCF26PAGqHbO2gu0BVx9vzfFYktpg4L 5qUj2aq3tGcik7F5wPHVWjInbu5mRjB8xEPrRJLlzGv3xicnoxOXoEqddJmujj1R3gdAcJrqHQa UEu1ZpLisSTapJpREWBmL2RpxY17HYsHfOF7o3dyHFWgXi X-Received: by 2002:a05:7301:46a0:b0:30e:d6b3:ba54 with SMTP id 5a478bee46e88-30eea0fc2bdmr1153386eec.17.1782833199855; Tue, 30 Jun 2026 08:26:39 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ee2fc21casm8995033eec.10.2026.06.30.08.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 08:26:39 -0700 (PDT) From: Hungyu Lin To: linux-media@vger.kernel.org Cc: vikash.garodia@oss.qualcomm.com, abhinav.kumar@linux.dev, bod@kernel.org, mchehab@kernel.org, konrad.dybcio@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hungyu Lin Subject: [PATCH v6] media: qcom: iris: use disable_irq() during power-off Date: Tue, 30 Jun 2026 15:26:17 +0000 Message-Id: <20260630152617.568-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The IRQ is registered as a threaded IRQ. Using disable_irq_nosync() in iris_vpu_power_off() does not wait for an already queued threaded IRQ handler to complete before returning. As a result, a threaded IRQ handler may still run after the VPU has been powered down and access hardware registers after power-off. Replace disable_irq_nosync() with disable_irq() so the power-off path waits for any in-flight threaded IRQ handler to complete before returning. Fixes: bb8a95aa038e ("media: iris: implement power management") Cc: stable@vger.kernel.org Suggested-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Hungyu Lin --- drivers/media/platform/qcom/iris/iris_vpu_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c index 69e6126dc4d9..538659284c7b 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c @@ -236,7 +236,7 @@ void iris_vpu_power_off(struct iris_core *core) iris_unset_icc_bw(core); if (!iris_vpu_watchdog(core, core->intr_status)) - disable_irq_nosync(core->irq); + disable_irq(core->irq); } int iris_vpu_power_on_controller(struct iris_core *core) -- 2.34.1