From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 597F93DB30A for ; Tue, 30 Jun 2026 17:13:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782839638; cv=none; b=Jc+sp5khhyrjY3Gz3IRk0j/0gS0n35/2ME90N2uzCOayK7yklKbycxIPkB9KFYY0n80Zx9Sl+FcdqeZAztpCGj9FozpvuKHRvVb/xxWC0psc6vGamqxzAk/zSoXLm086sDQW4qD2h7aYacvxPZeqduOGSDomvX8rfKg2IIhkJm8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782839638; c=relaxed/simple; bh=yIX1bqDOZJMk4FAwTaBF9FTRFIItyzhNRj3qdfFr7GM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AcnJEo20UFmZULYZmQ/iVzwx0hVYaZorn0fe0VHDUsBCYGB+Rz0MQaeplbtEgSTqmP5XvQoM7bf2bQBcveaFS6PNmn7VOx2/EmOaZ0aZctdkVCQDH4nYkyYFibpfipuGPt95PfNXV24rmyLM1n8VUhwxkS4r+M5GLqyIut8B5Ms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KgBaN4hq; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KgBaN4hq" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-30edfd9cff9so1863215eec.1 for ; Tue, 30 Jun 2026 10:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782839635; x=1783444435; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LAEwzM4GUMJjKZDLNdDkTnGBKY8hW57ikhpmi3nBjbI=; b=KgBaN4hq8AXl/2Tw8UygKtGrj9ErqtvCXOaKXk5xLtTPbza8Dc9mRiZGWyfmDMXjS+ l1Xrncroy7k8CI8mQzMShu8b8F8qrIdyObg/neJhyYWAb9pEaLX3/lEju0b7GVoqiXHf nN93jNSfahGGL2//7tYSunaAmiQciS8AyrVUElvDP4TaJV1TLbRfPA6YyUrlRNVPIiuy QQQaa5DeekFdxr5qesUCeFKSmzDgFGsIvQiXh1UBAYNhKGl/TY+gcOdfkACMMBMBurYB hgd2XL8qJkIQOmLFSqyX+yyOsS3a9IyqMQPySOtiTfVYJV24f7ek9ITCLUzDH1uLXO0d LKzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782839635; x=1783444435; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LAEwzM4GUMJjKZDLNdDkTnGBKY8hW57ikhpmi3nBjbI=; b=mUpo36C3V4kDrBth0qvsh4ngd5EEWDqE4LBrnUcvwg6Nt04Pro6o4avPkNbWKN7VNr T+DEPSKHKC8ZpsTrjEmDPIARBRx25OB3wr5C2Vs+A3Lf3aGQu9ZRb6pmF+1rVm7tEKNE 3MtLkxoZ9hPZFNEAkQ/J8YJXKhd0uRcv4Ju8VOqcEXyL0KRas19ePLIwrw/xLeFLp2pS deQs8DMjVXXk5G5xfUEm0mQjmKTqVQqyR0Cb7oRTU4LBsXLL6+M6dyP7Dn+gqAPoTdpG oFVz8OLthTHoaQKxsms1432DQP0Rwq9L80XbCVVnDMI8JZDury1irUAA6U96teMSQtG4 /Uiw== X-Forwarded-Encrypted: i=1; AHgh+Rrn/DMlCkUGtnnZKfSg9KMxyq6DleElHIIiDn1v0ifWIjE/IYwxdyI62tWRUGUmqEbnq6pttAl7KmQ7qG4=@vger.kernel.org X-Gm-Message-State: AOJu0YzAbpXJHcjBQBhz1sDFiEQ1w/++uZ/JHWo7/Y0UaCGkyz3GWQ3z MHVIdbu2/Fs3VQhy7Hp/Jo9gAEOvJ6M2cLfqyb9GM/4j2OX5b0QG9BKV X-Gm-Gg: AfdE7cliK1BuC69Kxzh+NeiVjLoZgXU2TdZF4zk8rwLKa121UV8Jvhldm1pu0IjpOrR 8PbTlnyj1Q0zBu5LziSskwhEbwwKx4lTCRnnupaUfccBHeEOnHjy/RVJJ3iQlif1JZEW10cXSGR B5bRWomHUxBka1/M8tmSgzrmzWSAtAg6scfiaw0LhR6S7f2jkEaugSCBYbZJlJ7vPvGCm+awhuo LAZxwXVuTYU67PW4u6zUS5dhHAdv8wLUjEaQVnCIKX1wrp0M6xZhPySjGa+P9DycxnssfFC1qKx koxh1TgAznTTKIc04q96kEtILpY8AdX1w4KjyOpSFHeBWVrxwaoK3V965CBxRrvNBkt4TsHIXi7 +veNkkX+3V+h1CKWrKqWZ2ycE2WLye66MDOkHXMjRy4k3Y6TwQ0S8mYNd4mjrKw9WZkYVBqLwjC SFYXYt3sJPKcj85b3R03lgwg== X-Received: by 2002:a05:7300:f68d:b0:30c:63fb:ebfd with SMTP id 5a478bee46e88-30ee134194emr3279885eec.19.1782839635185; Tue, 30 Jun 2026 10:13:55 -0700 (PDT) Received: from ahmi-PC.. ([2406:b400:28:6260:79c2:f49:197:de9e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ee2cd21bcsm19639864eec.0.2026.06.30.10.13.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 10:13:54 -0700 (PDT) From: Narasimharao Vadlamudi To: Kuninori Morimoto Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Geert Uytterhoeven , linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Narasimharao Vadlamudi Subject: [PATCH v2] ASoC: renesas: fsi: Propagate platform_get_irq() errors Date: Tue, 30 Jun 2026 22:43:33 +0530 Message-ID: <20260630171333.36396-1-ahmisaranrao@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit platform_get_irq() returns a positive IRQ number on success and a negative error code on failure. It no longer returns zero. The driver currently stores the return value in an unsigned int and returns -ENODEV for all failures, which loses useful errors such as -EPROBE_DEFER. Store the IRQ in an int and return the error from platform_get_irq() directly. Acked-by: Kuninori Morimoto Reviewed-by: Geert Uytterhoeven Signed-off-by: Narasimharao Vadlamudi --- Changes in v2: - Mention that platform_get_irq() no longer returns zero. - Add Acked-by tag from Kuninori Morimoto. - Add Reviewed-by tag from Geert Uytterhoeven. sound/soc/renesas/fsi.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c index ae86014c3819..6be6587e1095 100644 --- a/sound/soc/renesas/fsi.c +++ b/sound/soc/renesas/fsi.c @@ -1992,7 +1992,7 @@ static int fsi_probe(struct platform_device *pdev) const struct fsi_core *core; struct fsi_priv *fsi; struct resource *res; - unsigned int irq; + int irq; int ret; memset(&info, 0, sizeof(info)); @@ -2007,12 +2007,15 @@ static int fsi_probe(struct platform_device *pdev) } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - irq = platform_get_irq(pdev, 0); - if (!res || (int)irq <= 0) { + if (!res) { dev_err(&pdev->dev, "Not enough FSI platform resources.\n"); return -ENODEV; } + irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL); if (!master) return -ENOMEM; -- 2.43.0