From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A5E547A0C2 for ; Tue, 30 Jun 2026 20:24:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782851062; cv=none; b=gtxkaxWcbRB1Rn0C8Q5fZoIFwuewwN1d4E32h99A+TnzesKhayh3xpwC0YRNSWB3rv5gYEY/R3R4nmtn88MFIJv5eImrTJiq/vGPfhR27MQnMdUY+DXTu0qsYDG6BGFWzaBKRa9a/th+8RIXlC2zmbvqGlmsFDVCDs1ZPAEQ+mo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782851062; c=relaxed/simple; bh=rX/RmbqUohtiBxDsve+PGfvPFIzDy/imm3HVJgnA0m8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KNQQqP+y2JqsceVggBgv1hM3v70SGzq80nuuZHn0WZP+E+EE64WOGfehaSoOdxawUVAI3+QfrxQM8vAewYr4hSZH/4FCI3MQhhTdtrxh94EBIUND+W/7Ie8LYrhZQO3STU9X26/H59EW5+EXdtTvLF9F5caDZxFr4y1ziBjr9e4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UncaTx1R; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UncaTx1R" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c96cb024ee0so1061893a12.1 for ; Tue, 30 Jun 2026 13:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782851060; x=1783455860; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=30ycfbV8+VNAs6mHK0aeUIXi9pLDga+rOmgwe58coW0=; b=UncaTx1RcwlmQl5C3YnUM1WMVigDUoCt9+EdhHx8zVyKpC5UmGyXT5QEa9Pkwh63/n toBSt0H/0xMZ8XXJsMIQxxt1N3LelLJJ71WA0siviL3OuhvF1mxeDMD/Y/3OlCq8NKSD TGiO1k7uhPSQFVApBp2RIoKFiYIdHU073XXfM0Mi5X4Tv6GPjNbWaRPcyHSy/DaWRoOs uzKgtFUYLGuFiJ6GOtctCoNshmbL+1fkHgKMB8Fjd2bO0qdaJq8DywbQTAdewKKkuqsr C955FQTuBEcmGmJd1SBwa5UlD5WPh/Kj4SS6NkyHVM5rOipA0KZnN4LtP2WLruvpC9Ta IUeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782851060; x=1783455860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=30ycfbV8+VNAs6mHK0aeUIXi9pLDga+rOmgwe58coW0=; b=cEWs/1z/LGuXUlE16IpGRXjjB5rvOcnBGfpdLOQL4RBM9aL+dO/ROZxZVSXGg7EBaK RrpC/Jg6kkonB926IamH4QbiPikQtKUCkiE9XIUZ/cMh7pgsvLiI2la3d3NQczDcMHEX UC3PLu2HF1ZuJcC+rZ6sStdcnKv36tlQvtzfc7+L+pQoEQvBnuTG5H8P8fBX4YtbWfxa Ar537/bxn4uR4btz0sfQDwdasoXv1jy1ldi7qT4OmNw6/DqKqCLw08P6tVXiN4b1UzRd ATWKsaF5hJBJjG8qPbcPBSzE8aK9PZedgy04szSAgYxHhKeeWIkQBMWgLwjDBopYNkqV Og2g== X-Forwarded-Encrypted: i=1; AHgh+RrlO7dAYu9Ul2IvvczxHh2AbaZM/jEenq87VGeXpKoBfmy05RgcNV9iTxtkrZ4Lmfb/mPKDxKFXTtdOqOY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyk2JroASaeviXesmtwmu7PFFoCO6wxtItpi5vcq5hq8UkpuUmi X+n0fXguv+d+bieDLVtB2pzuFUay9NFyo+iKxKnt30VKK8gV3ct1xFYq X-Gm-Gg: AfdE7clwZ/hpOwcZ+PPUd+QXfkLYFvVyVyUVoLCtOsLskUoA63i473mHz04sToo4KBO znjPaSazeK20mWDHoWtGiVvNj3ZGr229JB02VFJEhuXBIF90mHU2Ly20dovIOmlF+vCzbvhNMQs AyIq3gPgLqin2nCILyg/m4UdVaNOLYwrtzEUh2wPspKkuQzrgikK3g7HO3ghzerPSOj9B0tmkev M2qT7hwKduzHwuwconq1/88qNYgGOUahf8kjieVln2SBUm7QXYKWtvbMGglvTqw+2meE5nxrvt0 iVfLM31sU0te+vsr1yXb8tRlucq5UnmU09+v4kZnNPXAO32XuHpad2pyCsf5LTHzt3Xzi/BGPUO R692ZFt2lOzNAt5H/f+2PvDaWd6Wlw6E8S/dgcpmq/6NUKoC/HIV/LHyW6gVEI/0qjBRZuX3K6J xGCI17aCtoieoAR5RO/15KS08vZMBIBBLyPYkHDc/VlrCbiqSHKMAk4Ofwk4Hpmm1TGC8GicdVo 64+XJs++Q== X-Received: by 2002:a05:6a00:2290:b0:82c:6f07:299f with SMTP id d2e1a72fcca58-8479eec64d6mr4285120b3a.14.1782851059735; Tue, 30 Jun 2026 13:24:19 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a0337121sm2688854b3a.44.2026.06.30.13.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 13:24:18 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/5] ata: sata_dwc_460ex: use platform_get_irq() Date: Tue, 30 Jun 2026 13:24:12 -0700 Message-ID: <20260630202415.234463-3-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260630202415.234463-1-rosenp@gmail.com> References: <20260630202415.234463-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace irq_of_parse_and_map() with platform_get_irq() in both sata_dwc_dma_init_old() and sata_dwc_probe(). This is the preferred way to obtain IRQs for platform devices and provides better error reporting. Remove the now-unnecessary #include . irq_of_parse_and_map() requires irq_dispose_mapping(), which is missing. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/sata_dwc_460ex.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 2bcb3ac5ae21..215b5a65527d 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include @@ -226,7 +225,6 @@ static int sata_dwc_dma_init_old(struct platform_device *pdev, struct sata_dwc_device *hsdev) { struct device *dev = &pdev->dev; - struct device_node *np = dev->of_node; hsdev->dma = devm_kzalloc(dev, sizeof(*hsdev->dma), GFP_KERNEL); if (!hsdev->dma) @@ -236,11 +234,9 @@ static int sata_dwc_dma_init_old(struct platform_device *pdev, hsdev->dma->id = pdev->id; /* Get SATA DMA interrupt number */ - hsdev->dma->irq = irq_of_parse_and_map(np, 1); - if (!hsdev->dma->irq) { - dev_err(dev, "no SATA DMA irq\n"); - return -ENODEV; - } + hsdev->dma->irq = platform_get_irq(pdev, 1); + if (hsdev->dma->irq < 0) + return hsdev->dma->irq; /* Get physical SATA DMA register base address */ hsdev->dma->regs = devm_platform_ioremap_resource(pdev, 1); @@ -1126,7 +1122,6 @@ static const struct ata_port_info sata_dwc_port_info[] = { static int sata_dwc_probe(struct platform_device *ofdev) { struct device *dev = &ofdev->dev; - struct device_node *np = dev->of_node; struct sata_dwc_device *hsdev; u32 idr, versionr; char *ver = (char *)&versionr; @@ -1173,11 +1168,9 @@ static int sata_dwc_probe(struct platform_device *ofdev) sata_dwc_enable_interrupts(hsdev); /* Get SATA interrupt number */ - irq = irq_of_parse_and_map(np, 0); - if (!irq) { - dev_err(dev, "no SATA DMA irq\n"); - return -ENODEV; - } + irq = platform_get_irq(ofdev, 0); + if (irq < 0) + return irq; #ifdef CONFIG_SATA_DWC_OLD_DMA if (!device_property_present(dev, "dmas")) { -- 2.55.0