From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 270A1477E23 for ; Tue, 30 Jun 2026 20:29:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782851384; cv=none; b=N48I686fb4wv9m7cTxT3L9fuBRBOHy/4CQsCujNNLiVD9hiv5+zAV0jadVkub+EFVU0VoyoGSdADEY/j9V8ro323o9X3+AaKm+WdpGa60rIFjBRwSi/UZ9Bc/J0Qydsy6xhyJMuPvZSky9FEcJUbCXEOdCL13O9DI05L3XrueU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782851384; c=relaxed/simple; bh=T3hAAuEcnuvOxgSX7BF+epZ+XdQfUSblgvEQCfCRlVs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UZRKGFINNSGKZo/Zm0WZoUJg7vzt0Pu6xCulQLhKjhKEZH35YYMW/Yqp7bwOZFEEQtYw4JGAJthX/OXVGNISFCUpprmDZceAg88EydgwyYF1IbS5VyuBBb8jXcNAFwVBMOsANotmNx98VcNEf+MPqBoZu5ESel4TVf8tChSme4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HRQeK/n7; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HRQeK/n7" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-8eefd4a8057so32761186d6.0 for ; Tue, 30 Jun 2026 13:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782851382; x=1783456182; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=VHkAtPDzDj99Aof3Amn7WPi3kL41U0foNenjtplF7UM=; b=HRQeK/n7/VLAMsi8Hl7MNCKzK4OFtvquRBgqzZMogyg9Fz0wBEB6lfg69DBfWm/2Ae WV8geQfBVl8Lnc8/Oxy7Y++MercluriXRhNoiRb/+FOzxu37zd+jNTL8HqdoyZXEqayb PtRQTsPkL+J3Z+297pcyHyBIVF9jrXloywrj3tXMgb1BJdqEVz/mFPulzTNyLSZzJMqB 7aLgNipQkRe0uCQsyjIwuljQcaABELVFxlLucKeSMUsTRWAj3V04gor/84hASDltB3E3 hZoCHCDLar66AVVpEpEFygTltbPRtOmGb5zB2HPB78o9VHD+gYq/bSwgclHoa/NlYoQp BSHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782851382; x=1783456182; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VHkAtPDzDj99Aof3Amn7WPi3kL41U0foNenjtplF7UM=; b=hmJ+amU752tfAm6/Rb2e/bOuuDliHsLDAYnFdYhwO+aZKmrzbiiOPyTPB8MYvKAkGH l8UjyUrlY9Ox3jJrXsukilN71wudkzs0HZejP/qbC2hN6qHwbZembGJogkRMyu+crMPy ak2zA7Z0MAAtcXqBkVqunwNg3I1MZFqBA2rQaU+CqfAGJD2J9avylFfFUdnPpXaEco+h MeEnxoOpeKZvqiBQmrXRQwM0OuPVmxamMvNvaJhwbdgEgxciwEE+QEsbf5/k/a74Suxa TqKIcUAL0wjyAcAKVYgTDw1eYwKjkAg2ZwXIEkuSuGEAH1K7PMkzDexpsxmbgRqwKFHz Wigg== X-Forwarded-Encrypted: i=1; AHgh+RoKCnlr+P0eROtHVn1zN1LTrGvh0XLEgInJrMRoFzexFOOe7wBzxupmLVzTtHmGJRjJoxEByhPvqbuRxg0=@vger.kernel.org X-Gm-Message-State: AOJu0YzrTG8TDJXsQbaRymPBZuXCqptZy2femc+6x9UApwhS7h8R8SpH tNYzAUOZYu5uQZj52TtJuMI+Z7ODm/1FkrMY5zUUUoR+j43kCfZeSMKP X-Gm-Gg: AfdE7cmo3O3srW4PqB1PBoh/cmlye5bmmsmkDITtvF3v1Vybl0RlGNk0QVVpxuEWS6A YRuwyEpxFTsMgtJ69WCUPkp3sxvh+IRBqGQ4bNTagvZGpDGguEwL+YrEnUgXZmZ/nLR+Xn2Ysju VpIzLZVUtPM+tsW9A4xoO4KlwEyq67K9rpdEOKFvQIcUNHSm35lVdh79pO0P443WRsmbX3RuCzQ xooFsb313M5e6ZQEVhV2OCpt+v6B6I2pBthQGrKNUs53XmwkoEreujGRZNSSovQHZvqfT20VCky O9EDTiH6i7d2rXmu46oBO424cMa4ztnl476KjnGMCSGHWT9RUwdqGdyg572Gt2jZalxSUFHECx3 JSu4tEUngJ9IsA1oJCW7B4dVZrhi2d5YdQSgYFYn8REC0yeYAjbDHrUpvBeZzehXlSHc/2WvDpE fHZ/gjh3sb7/nmlDlsfJXKuyIAd3LTdw== X-Received: by 2002:a05:6214:4508:b0:8ce:f1b:74ec with SMTP id 6a1803df08f44-8f1ba49e96emr78192396d6.25.1782851382096; Tue, 30 Jun 2026 13:29:42 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8f1a717edc7sm32006346d6.36.2026.06.30.13.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 13:29:41 -0700 (PDT) From: Yuho Choi To: Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, Rob Herring , Siddharth Vadapalli , Niklas Cassel , Frank Li , Qianfeng Rong , Koichiro Den , linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] PCI: keystone: Fix OF node reference leak in init Date: Tue, 30 Jun 2026 16:29:38 -0400 Message-ID: <20260630202938.1877632-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit of_find_matching_node() returns a device node with its reference count incremented. ks_pcie_init() only uses the returned node to decide whether to register the ARM external abort fault handler, but never drops the reference. Store the lookup result in a temporary variable and release it with of_node_put() once the existence check has been made. Fixes: bc10d0ad540d ("PCI: keystone: Add support to build as a loadable module") Signed-off-by: Yuho Choi --- drivers/pci/controller/dwc/pci-keystone.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 278d2dba1db0..f1b27aed488d 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -1389,13 +1389,17 @@ static int ks_pcie_fault(unsigned long addr, unsigned int fsr, static int __init ks_pcie_init(void) { + struct device_node *np; /* * PCIe access errors that result into OCP errors are caught by ARM as * "External aborts" */ - if (of_find_matching_node(NULL, ks_pcie_of_match)) + np = of_find_matching_node(NULL, ks_pcie_of_match); + if (np) { + of_node_put(np); hook_fault_code(17, ks_pcie_fault, SIGBUS, 0, "Asynchronous external abort"); + } return platform_driver_register(&ks_pcie_driver); } -- 2.43.0