From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA548135A53 for ; Wed, 1 Jul 2026 05:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782884014; cv=none; b=c9q8n+eNVYM1aC67YOkWLWkXqXvWp3qxMCDRmWqpNmPBr9SlFUfmSIOqWUX5SLwVzBQXnGUezd5QiXgPIxZ6WE8r0rOeLy9RtqTH1mqYSmHLVSKt/anZzbEAll+GIo5sYCQsJJhQmWD5hYJvZAVZrfV1c1L01Hay+TeicYuShww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782884014; c=relaxed/simple; bh=Rk76DC0WOGgSQVZqS5fz2rpO2lkySjM4HI5SiqskFP4=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=ieT80PBJd/zUNaq6UxZIaG+jenKD2mOZgwWUh3TkgMjoNOIMi78fERsg3uqwMV6Wlnq3dRMhW8umotM4Q4mUI7HWmP3RHgIYaFmcqpbyGoUB7C9ph07eS964STW4P8RjjG9yh5++PlfKFLppckWScx9KdIDwioxofa4QIaahRbQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=AWvtcZHz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="AWvtcZHz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11E1E1F000E9; Wed, 1 Jul 2026 05:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1782884013; bh=e8x0DVh72346v4T65zlhFNs55tqSgEr6iUQN+gRodPQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=AWvtcZHzIS2f1Cz8Ls7N77oIWgF5XOElmjHIPsbBdQ+CcyM6UdcSEgScBL2T3WKJt 7pdbEd4uS1oottAlHKYpp/Ncu2yOp401whXb0V9YucSMlbtqjfSJ8L0LZh7ln4rDuR VYxjA2ytOJPJfb1yvIxjwv0lew/fcm3IkGp1kM6M= Date: Tue, 30 Jun 2026 22:33:32 -0700 From: Andrew Morton To: Vivian Wang Cc: Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4] riscv: mm: Avoid spurious fault after hotplugging vmemmap Message-Id: <20260630223332.534218a41b2f574de327e4db@linux-foundation.org> In-Reply-To: References: <20260630-mark-after-vmemmap-populate-v4-1-febbc15da028@iscas.ac.cn> <20260630211100.5c8f09c607595fbb5bca0a74@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Wed, 1 Jul 2026 13:01:15 +0800 Vivian Wang wro= te: > On 7/1/26 12:11, Andrew Morton wrote: > > [...] > > > > btw, AI review suggests that there's a missing barrier in there (a > > pre-existing thing) > > > > https://sashiko.dev/#/patchset/20260630-mark-after-vmemmap-populate-v4= -1-febbc15da028@iscas.ac.cn >=20 > Interestingly, whatever thingy that is sending patches into AI review > seems to completely strip the message below the "---", Hey, what do you expect for $2,000,000,000,000? > which made it miss: >=20 > Changes in v4: > - Rebase on v7.2-rc1, drop dependencies > - (No code changes otherwise) > - (A concurrency fix for mark_new_valid_map was sent independently) > =A0 https://lore.kernel.org/linux-riscv/20260629-riscv-mm-new-valid-m= ap-ordering-v1-1-60d8c10c6292@iscas.ac.cn/ > ^--- this Cool, I grabbed that. Same caveats: riscv maintainers, please? > I've reported "being able to read below the cut" as a feature request to > Sashiko: https://github.com/sashiko-dev/sashiko/issues/306 I'm not sure that Sashiko would grok (heh) this if it was above the cut.