From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFE2B394793 for ; Wed, 1 Jul 2026 06:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782885956; cv=none; b=X+tE1bsHy5lU8xmaHtgpeVyiqFqgOrFmm6jB5n2/qVBVVRrCEBHl5osDCmyppNCMSqun/cc3qjj7WiQoCfqBGeZHZzpXSUgI8xr9TMuSUC3xedDyKMr0AklpPWcLvffeGr1OnSAkNNo88OQyy0Ix7XrlMIygAPOwWE5Qwl/QKxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782885956; c=relaxed/simple; bh=NCCuaWYH56yc4jsljXsw5WSLi4PnaOm05c4E0yC9dIc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r4+WYnjpud7BHIQJoAMkAziKabnKO2ao8YYf2LleaYBzhTKnzS6K8LUx9BFkNDH66gvN0LwY9m2K/rFdYUvSCanFv1sjDCxuCmvLLvY9qxvMBtLGlYKXPZguWr7egJ+twqOBQBnGYk0S6CSnmG0wAmgHg0XNvbMayWliIJHC7AA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PVsHKBLx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B/EwUtyj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PVsHKBLx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B/EwUtyj" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6615lZww154293 for ; Wed, 1 Jul 2026 06:05:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3hzOvvQKWdguYtkPt+A8OQtsnHMjfxs8678kX7F8cLE=; b=PVsHKBLxQM+zMQde pQQfduVNwjXCTfsMXMLExDZzFsdxaNB1XpfVT+/Tl8JTpaP7xSAPkawxAz26bnU8 p9C9HhcPINArAGEPmQLppk5w6p8OwuDr9TL12mVHQ15FVUILo5S07OHlhDpNfGNY /SmA1wqARsyjSpQp8B+F/AidHBYorsm/09Cy/HX5NW/U5Oqj4KnI+2KbJsdg9FGF m2Vw/1lLJGJ0qdloWvxY9B8gzyBtyawIam58eJ7WpSZTXiRzH+qMp95piLp2DByl XzvLko4W+ZJ0Jtp6WgytLTxnQwpOcimIYssWMdcFDVHBKOUT50IK8BlKHg8oPNzN GElFXQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4j912nj8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 06:05:51 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8478a1ec69fso385526b3a.0 for ; Tue, 30 Jun 2026 23:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782885951; x=1783490751; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3hzOvvQKWdguYtkPt+A8OQtsnHMjfxs8678kX7F8cLE=; b=B/EwUtyjmZF+0sKHlUiwmSSLN6xmfX7C83sMzK5eApg7vDA74Qw+y8pscdHGnUYa6T kzeIr8tC8m4ACkK7mvRmc8suD63zgRBzUM6iMve7QwoRMNhLW49isN/3Z8hOxJLIkDCG OxdvPV/pVI0egmuI+Ap3IM1vmzBP8Pt3IKNysyknHj+Dc9XWc2vrFPkOOODFLuUzY00g dNU+l1l6QfLnrSYpmxOZwUtqYtfb6P6zjiAzPqawNYOO5qazkUyQPtlmE6EkxB2b+zSE jSf+1fpO8vSHYXhgv2SxwbRr3Nz/lpXNA6xnwPJO3l3jXhmiLRRffXYYxrwixPNCPsVt koIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782885951; x=1783490751; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3hzOvvQKWdguYtkPt+A8OQtsnHMjfxs8678kX7F8cLE=; b=fdgShZeCLPKOAocUN5OoPOwnKQIzKs2IILZQWbGED0a/SRM5Zoh04X7bs04A+Th/c6 2VKzeO809Tj+qWXdx52ReYpRhjZRF9ijGRnTH0G5sg0cckOj0yF+HHPq+5aZlzfmT0OK s9PltgQAzmmbzvRkOMM6KYsLppFCezyBcMoQ9j05lJmBfxje4yzK4qgpr/Pm3o5Uqexb aj6aI2rbQFGlx8R1vzZfktcmd+Ky4Vr3iNaFTBkScIykhJpk/3EL2nnjGosNBckeO1pL a0NRjrYDCGBjSEi5cJm55PN4nmeh+K8/FdY7FEOE3/WvrAWUk0w1dTnJLqEAgF669yZe Qnmg== X-Forwarded-Encrypted: i=1; AFNElJ8lR3SbwEjio2MwKjoMozyrtNKMtJsHMH4GjdYzw4LoUWJi54lQpfSStVWSuCBr/gSwKQlIHhNV9Twj41o=@vger.kernel.org X-Gm-Message-State: AOJu0YzZgBz2Y+53wyX90QA0QtV1e9cGfR52gOjqyictiehDFoWxB1lE y1DbJjgF83pdoExKxgEBWvLveQ6K+2ykOVJJ/rtri5kgQK7z3ePAlveaW89naAtqIF/dNkIq+GP N+Bo6BGjD+bs0/1Py8YH0SbnaO6jY1+S20k+6BxVCnKpRAkI0DcvL+suACt/zK8ABKto= X-Gm-Gg: AfdE7cl3oPVxSpIxfSvS2z+kShGRCcgEBlcdJe+bev9R0mqDgPUTh1ytOt1D4O4JsBn TAZxDa0Va6EDjUcx4WmD/PcYjhkFTvt1tYUvJNl1E6OiormMtMebkgtzXxSRWPFx9SkdmpUPJbm IqXe48WGfGyHjTGSinKab+AA4BZewudC5/4XRMBgnrJKmK1WEbAhRnXiimLEgylIllyipcjj8wY egbw2LRh3z7+8GGz22Ojip85OO2gmvtH8YmGW4mO/rJ9CbgcsFhGb+zs/ZM5ekt2UlOpw7o2ZPu tbYau8b+VGd6saxJgiPFh8Lbp+jvJz1ttcL8msKlp+ilYa26Ua5dP7Axg4wm6MNcgWQcPaebDvC iyhDXu5ftnqx2JfwaScVmep/JSJy4rYfOo2mkHZBN7L3/Z9F9WA7nKDT0e9G8MLW+CptWHJx56w == X-Received: by 2002:a05:6a00:2d96:b0:842:4982:82a with SMTP id d2e1a72fcca58-847c08af565mr183085b3a.45.1782885951147; Tue, 30 Jun 2026 23:05:51 -0700 (PDT) X-Received: by 2002:a05:6a00:2d96:b0:842:4982:82a with SMTP id d2e1a72fcca58-847c08af565mr183048b3a.45.1782885950658; Tue, 30 Jun 2026 23:05:50 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a02cc6f2sm3317658b3a.30.2026.06.30.23.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 23:05:50 -0700 (PDT) From: Jie Gan Date: Wed, 01 Jul 2026 14:05:03 +0800 Subject: [PATCH 2/2] coresight: tnoc: Fix clock refcount imbalance on platform remove Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260701-fix-clock-refcount-unbalance-v1-2-321dc63c1f90@oss.qualcomm.com> References: <20260701-fix-clock-refcount-unbalance-v1-0-321dc63c1f90@oss.qualcomm.com> In-Reply-To: <20260701-fix-clock-refcount-unbalance-v1-0-321dc63c1f90@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Alexander Shishkin , Anshuman Khandual , Yeoreum Yun , Yuanfang Zhang , Maxime Coquelin , Alexandre Torgue , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782885937; l=1478; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=NCCuaWYH56yc4jsljXsw5WSLi4PnaOm05c4E0yC9dIc=; b=xIWQ1o/Enc3LrxgE+zJBk+Rq2NAbYnrCtsgpWAbMHgw9Q/m2Yolfn4OfKYdQgoB459di45I0T xveurW8Df8GDxHms5/6I2vPiBmPd/tUExKAOFXO4ddefJo/7hVne1Jy X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-ORIG-GUID: XooUJayp2pt5DIE31ykkXOvr3bSYpQqj X-Authority-Analysis: v=2.4 cv=ftfsol4f c=1 sm=1 tr=0 ts=6a44ae3f cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=4fW1H2bpnNfDCpRz6dIA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: XooUJayp2pt5DIE31ykkXOvr3bSYpQqj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDA1OSBTYWx0ZWRfX6xusbQWvqrti UYgCHZTaFzEBAfpufUub2KVbFQ8bv/ojHBLOWrjWXmcoAwXQexevOl2BNHL4KLbYA6IsPTny4L1 A8gILjspU1ziFja9FUDux+tyvelkelmOBx/B9i21WASUiMhNMVUIfOiLyW6j6DfTG/8h1XQ8X6+ E7BJQ2R18zUT0HKRZx/hXfP57BvE8qwHD63//MRemMKB0aANjxvbjX1kJwnPxc7rj8r7KwWh3Ro I3J/plgVTImj5zR+fZJaJ9xwbOna1sQpMhrah7gNH0lZoE7weHLFpeAbmPq8TYHuSEserMxyrPz ZyJVX2vKtNROoB9q/dL8EbkVSsK2rxD+j0Pfxsl1XpGxpEsRpc5at8EJUN0Qegzu6/u91KgdNJX Y/YVr1S+rMEtoXqkrbv9nZP57PA0b11TZiO7L2RNglWvWfk2wdgHxzTlsvIpLVKuzAkSmK4A/CK ZzNwlKOEECUxyxARkxg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDA1OSBTYWx0ZWRfX+xpZiAQYEgxO 43G9DI2p1X0taOqY1fYiCnRphvlGGIpnBta9277IFNnXEd6JiQ1tlhYaXGFX+jbdrT3aOwUy06w 2lS47i5s7PzUer2YW+ejV7sAw8HMPE0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010059 coresight_get_enable_clocks() enables the programming clock through devm_clk_get_optional_enabled(), which also registers a devm action to call clk_disable_unprepare() when the driver detaches. After probe, pm_runtime_put() allows the device to suspend and the runtime suspend callback disables the same clock. During remove the device is left runtime suspended, so pm_runtime_disable() freezes it with the clock already disabled. The devm cleanup that runs afterwards calls clk_disable_unprepare() a second time, underflowing the clock enable refcount. Resume the device with pm_runtime_get_sync() before pm_runtime_disable() so the clock is enabled again and balances the devm-managed disable. Fixes: 5799dee92dc2 ("coresight-tnoc: add platform driver to support Interconnect TNOC") Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-tnoc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwtracing/coresight/coresight-tnoc.c b/drivers/hwtracing/coresight/coresight-tnoc.c index 9e8de4323d28..a4ac0eb02248 100644 --- a/drivers/hwtracing/coresight/coresight-tnoc.c +++ b/drivers/hwtracing/coresight/coresight-tnoc.c @@ -300,6 +300,7 @@ static void itnoc_remove(struct platform_device *pdev) struct trace_noc_drvdata *drvdata = platform_get_drvdata(pdev); coresight_unregister(drvdata->csdev); + pm_runtime_get_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); } -- 2.34.1