From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41B56361DD2 for ; Wed, 1 Jul 2026 01:54:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782870857; cv=none; b=UY7Ew/dH69cjjpzLWK9IvOm5J9sqvtW2BrSQjy4u/mG10ZYZsK13m8uwtSxhD5EjE25mysmHT3ZtfCAvzXKMyz1uC+EPI9oZscK3ztTWWs5PonW5TbFkKUqz4zqoEP/wWxyYrX7ciiOvtCf1NB3+mFajX1ldopQ2W06LR/TxLqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782870857; c=relaxed/simple; bh=/ryGcxx6Nu7BXIs0Li0gmKHu5V51HhlktJvdbFAeafo=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=E8o5N/hEwZvrzMACQVByGRQg+q1HuZdQ6eXHFIe+nj9CoCka0rTWvHjpZ2XMcTyOu0kKPq4kdtxdqHEb+ngQzLn+0UTB6UaYqGZtmgPbHybxov9wO9TN5sdWruVx16fRutxTUlcntqlSulEMRdgdwa2S4yMwF+UqfJoGf03ug7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GfmhXF3L; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ClBCiEFb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GfmhXF3L"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ClBCiEFb" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UNLtiN3416682 for ; Wed, 1 Jul 2026 01:54:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=C0Nt8/qawZeMhk1o8C0hBJ gi0bwQbxoP3TJUKy1hBOs=; b=GfmhXF3LLHIIqhsHDRDt9eyfsltliPJqARJy/8 8BCD2S2QXGMy7V6HDDmalzKyR/OCfP70/mtTX9FvJVQYz7z18h09Y4r7NFkkBPma ++IYdjn9Y9KJpdIRPPDAfhruNQNfJzt1rpwFJCKeKLKI7r1LMTLOXDSXh/FCOS27 U8uzll8GY5Jok9pE9OS1Yqss0FDkKODnukyXRC6hJkomFPtDCtT0gvzpHMVOaW+j nEyJXI8ms684te+8b+J8NdCvCA8JgcEMIUakyscY1GrcVBejlM6nLP0RqP6ax7f3 skkCWvg1OOKhFm4jjE26SRcEFxDK4oLUqlPQHWF1bptG7rwA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jtqhmbu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 01:54:15 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c9e994869aso1811635ad.0 for ; Tue, 30 Jun 2026 18:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782870855; x=1783475655; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=C0Nt8/qawZeMhk1o8C0hBJgi0bwQbxoP3TJUKy1hBOs=; b=ClBCiEFbIpVhHEdOcuGRACVPhzUECOvIhw42n5C0yI52P50uswl/4aitxcV/KU/rYN hnN5hN+k8YQsJoqviR+kcsj6yO25vp3M5SI5kyObYZl497DBHmtUlJVlPj8MFFsp4QYB YIG38qYkrDqaPt8G/an84LgLNR7JAGBYAea/FnOeV0hv13CtiB+G6AUaPb8cNGwQ0g6a B4ZIWaooHNmqsPqzuUQom2cXRhpKprAhtOuXundMrXyNNhCBBEyLWnjTEsi2hFWwJmNC CZYhNF1I33tTwJ2obBThTh8t8ehBwS6hWtChJ8WNJ9z8PGEmLjgbkrtkg5WWwomXV2OC WeuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782870855; x=1783475655; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C0Nt8/qawZeMhk1o8C0hBJgi0bwQbxoP3TJUKy1hBOs=; b=NlC9XMbagBtiteVZ1PXwJN2IFLE72pp/Ugd25P8FQCLNub0eIhX5vHEbms8keD04c3 RtBIJIxzvOD5E3uBWUcOIpeISk866+fNkk3hEH0Lec1Ty9UCUFJk/hhSASFU4qbIgtOU DByR/CkhpqF/RBTr+xu3My+bf46ZC8XqyMLQcbIX5WKaPxwuMx0+1w/Q85J0JoDgiW2S ynFF4N+pQ5ujwpOro+iKTLZT3Etvfkiw0Pu/K2gG+hyqR4JYMQrc6yNOLMYc2aK3qIha v99m38mpGKayZlpc/5c4q0QDSA8PnNxKaSbVLZYQAHLa1tfNqJCWVufCGbgnD5fEabj8 2PMQ== X-Forwarded-Encrypted: i=1; AHgh+RoxCvnyazh4VfJAePP+HwHMGrcEokdyldVFdMSOiuONN6dlHfLd8N1vg9MAKk4IzpANhlp9QDidORdFdTY=@vger.kernel.org X-Gm-Message-State: AOJu0YxCSt1MjmS1anZeSil1lfQNEw39V/wB+NZsFGQRiDpe/9rPMlOH We8pN2ESncWjcZYdBpwOCqEgjMdA0bnxvG5XnDuetyboF46a3lmJdCZ591HxB2UsHCx2St+jee3 rMTeOr4U85R4NB/5MtMceEmeakMLva3kznfWS9/mgMufM36LMKZgT4j2I6at6GcdDHJE= X-Gm-Gg: AfdE7cmjAZIX7FVLuBwzna20XJTqkR/Aov1PsV/mIe6enO4KZdzVrKEkaUOkUq9todn W4xZJy1IqVeY87VtBwecNPmLqpHU8BzxACCxs1kr99iByoGxfGZTjwApSfZx5Igu/5fecc1YSi8 ogYUkkffBDwMCUirG6dSm3ibeJ1Gmt8t1SwGyXn1LbfxLYKTBcuw2wImZt6EoDs0KLK7+r2g3rH 1iKzgeMJ3gMGRnpsp82yZ0ofFQlPWddBTR5H1F5jRHoVkO7PFqusYiHsBBzmr9wTB0HW5C6u87J 6cC2z/+2iN4uMLmirdf9pCiUz7ycE3DmqDOP1upkVvf09Jp4CKSuJbxkyqzhwV1ftgMFxFzSxtI oruRgaEF6OwAvqX1aPg0qzK+eqKPOiqfCA6qe5n8h7FqtUiKeOQqmb8S+cByAIbLP23aw6rMdWg == X-Received: by 2002:a17:902:e750:b0:2c9:deec:f564 with SMTP id d9443c01a7336-2ca2d79cf0fmr54119935ad.13.1782870854751; Tue, 30 Jun 2026 18:54:14 -0700 (PDT) X-Received: by 2002:a17:902:e750:b0:2c9:deec:f564 with SMTP id d9443c01a7336-2ca2d79cf0fmr54119515ad.13.1782870854181; Tue, 30 Jun 2026 18:54:14 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca37a7102esm23040315ad.6.2026.06.30.18.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 18:54:13 -0700 (PDT) From: Jie Gan Subject: [PATCH v4 0/5] Fix traceNoC probe issue on multiple QCOM platforms Date: Wed, 01 Jul 2026 09:53:40 +0800 Message-Id: <20260701-fix-tracenoc-probe-issue-v4-0-aefab449a470@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIACVzRGoC/43NwQ6CMAwG4FcxO1uzlTGGJ9/DeIDR6RJluAHRE N7d4cmDGi5N/ubv14lFCo4i228mFmh00fk2BbndMHOp2jOBa1JmyFFxhRKse0AfKkOtN9AFX6d GjAOBURLLpkLdWMnSeRcodd/08ZTyxcXeh+f70yiW7Qp0FCCgNqbQuSi1NfnBx7i7D9XV+Nttl wZb7BHXeggcCq1y5FahRfHDyz68jP/xssVDLkhoKaiUX7x5nl/e/qeJZwEAAA== To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Jie Gan , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782870847; l=3766; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=/ryGcxx6Nu7BXIs0Li0gmKHu5V51HhlktJvdbFAeafo=; b=/UXhHbIqXN/AyUqRrNk0GJChbDZcuDbq6hv4Cytm1eI1Q9jmtBCfevqm9yhCqTQN05nlTBvcU 7TbZgLFeyBFAp7hmUZncgOhPmTYNBzvcpK69v5Sd3wv5zdGBrwGYlo8 X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-ORIG-GUID: jQtLokiVACPZZ-mv6RQJ5BYQuEgcVuCQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDAxOCBTYWx0ZWRfX41hZSqRjb+hL rC6XzQy3kdKuEZbp5ftveYXbeQgFsjoeRr2CEEdOLsApn8pTh4lxDirUulGmHDJWBAklbTAH4a6 JOFTCwJnazD8VwNeQo08HiFp0yUwKsTSlLe2WZ6F56eqEHJlyzbS7ABXTdRMzNFvOaNKAo1FPUk oGa3dlc07QNm9YJJsisDPbBAdvyPh1IPLUblGeGY3BUStN1PpyniQ8U4m4CoLqPTwuivfrJSXSG 20aqQR+n2MZ3kHHI/o9whD97QDXd04f/UNe8JR+nP/5htpf8dbkSPSpew6dT69arH/TiCDZWP69 EPczyJqKouG6bnfC8Kb9EmMOpn4H3oxgks/zCWfVctTOQwbpbZsfhOXeT0v8oNqu7BOhcTQaHkx 5k63UpsAz2We6917FAaRD9mbpoSPRNRbkPPnhWD2ZdLomb+Kgdsq2OOTI2pXzW9LdrNVagfyzQJ L9UCqH1LQuOl013SAVw== X-Proofpoint-GUID: jQtLokiVACPZZ-mv6RQJ5BYQuEgcVuCQ X-Authority-Analysis: v=2.4 cv=LIZWhpW9 c=1 sm=1 tr=0 ts=6a447347 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=CPxOtKTflHPnepyb4PMA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDAxOCBTYWx0ZWRfX8gaODMMCfawV r/ROD7MsjiLAvh0IibIQ/tG5BiTTuqHYi80a/Vn3FDombh4Nlm+Pegu23XPF1zWz+gHO+q8zFHc wChWW0g0bVgMxLAOGfdziFGZNDeV2BQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_06,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010018 The CoreSight TNOC (Trace Network-On-Chip) binding so far only allowed the two-string AMBA form "qcom,coresight-tnoc", "arm,primecell". That form forces the device onto the AMBA bus, where the driver must read the peripheral ID from the device registers during probe. On several QCOM platforms this AMBA peripheral-ID probing fails, so the traceNoC device never probes and its trace path is unavailable. This series introduces a standalone "qcom,coresight-agtnoc" compatible that describes the Aggregator TNOC as a plain platform device. Without "arm,primecell" the device is created on the platform bus and probes through the platform driver, bypassing the AMBA peripheral-ID read while remaining a fully functional Aggregator TNOC that allocates a system trace ID (ATID). The series is organized as: binding first, then the driver support for the new compatible, followed by the per-platform DT fixes that switch the affected nodes over to it. - Patch 1 (dt-bindings) converts the compatible to a oneOf and adds the standalone qcom,coresight-agtnoc form alongside the existing AMBA form, updates the select block, and adds an example node. - Patch 2 (driver) adds qcom,coresight-agtnoc to the platform driver's match table and renames the itnoc-specific names to generic tnoc names, since the platform driver now serves both the Interconnect and Aggregator TNOC. It also restricts the ATID-unsupported handling to qcom,coresight-itnoc only, so the standalone Aggregator TNOC is no longer wrongly covered and correctly allocates a trace ID. - Patches 3-4 (kaanapali, sm8750) switch the traceNoC nodes from the AMBA form to the standalone qcom,coresight-agtnoc compatible, fixing the probe failure on those platforms. - Patch 5 (glymur) switches the node from qcom,coresight-itnoc to qcom,coresight-agtnoc. This node is actually an Aggregator TNOC (its tn_ag_* endpoints show aggregation), so it should expose a system trace ID rather than being treated as an Interconnect TNOC. Signed-off-by: Jie Gan --- Changes in v4: - rewrite the commit message for the patch 3 - patch 5. - free the allocated ATID in remove path. - Link to v3: https://lore.kernel.org/r/20260630-fix-tracenoc-probe-issue-v3-0-7201e1841e94@oss.qualcomm.com Changes in v3: - add standalone compatible for AG traceNoC device, allow it to be probed with platform driver. - add fix patches for sm8750 and Glymur platforms - Link to v2: https://lore.kernel.org/r/20260624-fix-tracenoc-probe-issue-v2-0-786520f62f21@oss.qualcomm.com Changes in v2: - address the ATID issue reported by Sashiko. - update binding to accept arm,primecell-periphid property. - Link to v1: https://lore.kernel.org/r/20260624-fix-tracenoc-probe-issue-v1-1-bcc785198fc5@oss.qualcomm.com --- Jie Gan (5): dt-bindings: arm: coresight-tnoc: Add standalone qcom,coresight-agtnoc compatible coresight: tnoc: add AG tnoc standalone compatible to the platform driver arm64: dts: qcom: kaanapali: fix traceNoC probe issue arm64: dts: qcom: sm8750: fix traceNoC probe issue arm64: dts: qcom: glymur: use Aggregator TNOC compatible .../bindings/arm/qcom,coresight-tnoc.yaml | 39 ++++++++++++++++++++-- arch/arm64/boot/dts/qcom/glymur.dtsi | 6 ++-- arch/arm64/boot/dts/qcom/kaanapali.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8750.dtsi | 2 +- drivers/hwtracing/coresight/coresight-tnoc.c | 37 ++++++++++---------- 5 files changed, 61 insertions(+), 25 deletions(-) --- base-commit: 4e5dfb7c84012007c3c7061126491bbc92d71bf1 change-id: 20260624-fix-tracenoc-probe-issue-c6429da28df4 Best regards, -- Jie Gan