From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 023E53A48F7 for ; Wed, 1 Jul 2026 06:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782887017; cv=none; b=mS2uPiXLKid7ahMT7zNlj7liKS08DQZFdnyo9UI+D2UfzcTKnH6aPO5PusU1iXbkcD+8zzMRQhX3IDBQz4nryIWxjLUrh2+/LF6AVrn40ri6MHHLWLP3h/n1ZTkZR2Q/OSqwGLTKF1GzrXYTSqToF6hCPGLsZidYWyiYtBIHlA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782887017; c=relaxed/simple; bh=zhThVOahHelMd7gWF2H1MLhLvB1TPP3rfvXmeKhDX1M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DcOu3E0oBurH4Di4+r0opwh/KfV4vq2sgpTUgwrAP15OrGf2xEqGItQ/rLtokWXC12ZKUzi+Ip3q//c73xT0LYEy4cGRFDN6Z532ADA6ElK4z6xcW5zuHHa8vOiyw3AXyGB+0eZi6Am+MTsNrdwVuLHB1iVoGMbL3ZiA3v52euY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fakSryMT; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=m3NavdXG; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fakSryMT"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="m3NavdXG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782887014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Dn4YpE+G/XOCOtl5iA+urnXDlQSVOY4Y63+Aj/OoE04=; b=fakSryMTw78Oudukp+7XadgPcmRoCKnOEbNpNZJPGXbcQl8lGLRoGBwGyuTKUX1NcFC8g7 HiRUwFvbNKQTO/exkUIHeSULRVGS/9dr604Ofc0WLrmiHLClsTfPGvPsblkwck3MyGAaWG 6hDtKmo4HBuYoVA5QKLOGLSJ8VYMf0A= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-JNYkwt4LOVyGosFbmOTVCw-1; Wed, 01 Jul 2026 02:23:33 -0400 X-MC-Unique: JNYkwt4LOVyGosFbmOTVCw-1 X-Mimecast-MFC-AGG-ID: JNYkwt4LOVyGosFbmOTVCw_1782887012 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-475b0b4e8d5so185744f8f.1 for ; Tue, 30 Jun 2026 23:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782887012; x=1783491812; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Dn4YpE+G/XOCOtl5iA+urnXDlQSVOY4Y63+Aj/OoE04=; b=m3NavdXG+rC34zLGrUXNt5kO3UYS79WP7F8tOiAkf0SBjV/GvJSK4hViIbW0cgNM1i ITZizaVN2W4ehN/gAm6/vOVjQJj4L2IFmMTsKGHaYAyn7ZIUIqCkA7Sf1+X9Z8MlHd2g 8TXZ1VtZWAQ3h7Fr9Swmz4YrDeCvmt7TWQVPt5sOKorXWCVZXhVLeM5OSLULyUJ32gJE C8bGzd1NeXxarhkezd2ZPgynrtRLSUXlQFjbi95TcKgAs3SnLPB+S5qK6v0I6uBEc04y JTCsZ09gUnRv16J4UwU2ycWkEokmBYjZQ64DbxrVSOm3O7y21E5DmubLbbscwvcufIS2 LdpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782887012; x=1783491812; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Dn4YpE+G/XOCOtl5iA+urnXDlQSVOY4Y63+Aj/OoE04=; b=Lhk+AQj1PY5wTDu4gFrseH9bvVGNOOH3apzbCBnaHswCN7LR0GK1n8Xip5FDNFyb4/ N8UKZe4Jg65/9FlfD/6nJVtAgCpEl2gGAjNDdfw/z3ew/3TKP5KH5L1tl2ZNj2nfThtF n9kwLuzc5vkmRlTe59oBMKKlRfHYV6o6THwRSMlHIfST6y3rr5a/OkAA+g4l/Rh5FNNF rgibN4XpTHmz64FOvzbJD4r47zfXsLlUr4/vt/wBc4sb/9dyPfbGBzyfMNvHpc+lYcJH +XYCUa469hZ49YI1dy0PXUQNljSwNIgYFULIG50+MQDPKnfI42FFk9hsj/etiewj0rJo cOSg== X-Forwarded-Encrypted: i=1; AHgh+RpyOrfIHUu/2TGjBhzNS38YljN2AQK0jdY2X3XVJ/NK2+wnPJK/KIeT9E81/DMT5l+CvBFPskkROaeKFmI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzh1FtjLfiIKk2fqOM+a6rguTlhZYUtH0YzpwyoDRop4fDWBcMI 4a0G70D3ofFYQHozZ+ibWjxm/sZV2CDomP3XOSG0JfmyLtrjh2X79oDzD+KXIF3A6yhjV8TJk74 kF5Wl3RiwlyvkCn2oK+bf5eXFoejdJ8FOy++bZMqYbgTWl7wfQpDh3ImTGf4noo9Qaw== X-Gm-Gg: AfdE7ckrxTvmxxpG0kjDV+DQWswLo6EBvs0iDk9hX5dU+SjEia/hZIMOnvsV+oRZrJU 8b6w4/4679/xjZ1fbM4nryNlZH15tjKkPAZztwdG76IIoRwjs3QnAPRIq+TrwRmen2x0N1E9f4B GmwVuUCe/1zpj6LVKYROI1OfsPeWG4jL5vCRyUenLfqriEDoEExMe9b8cGCIoZo8HRq27zQP21c LeVmV163GcrFoGIhWmg7LuyaHlZygePjjKhBwvZtYigbmzNVogpLbgXuFI4tHbzboZ/UAJp+DqV gg8qW50NNNziDzGcKMpKdN4OZQEw7dP6jJBlJw+SIveqG1TvwXMbMm/uDgTjBlORWJPw X-Received: by 2002:a05:6000:e4b:b0:472:d154:facf with SMTP id ffacd0b85a97d-4775a100e73mr312404f8f.42.1782887011718; Tue, 30 Jun 2026 23:23:31 -0700 (PDT) X-Received: by 2002:a05:6000:e4b:b0:472:d154:facf with SMTP id ffacd0b85a97d-4775a100e73mr312378f8f.42.1782887011304; Tue, 30 Jun 2026 23:23:31 -0700 (PDT) Received: from fedora ([213.175.37.14]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4756797a8besm14858051f8f.35.2026.06.30.23.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 23:23:30 -0700 (PDT) From: Ondrej Mosnacek To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim Cc: Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Ravi Bangoria , linux-perf-users@vger.kernel.org, selinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] perf test amd ibs: avoid using executable heap Date: Wed, 1 Jul 2026 08:23:21 +0200 Message-ID: <20260701062321.517351-1-omosnace@redhat.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Making [parts of] the heap executable is dangerous and is blocked by SELinux on Fedora/RHEL even for an unconfined user. Replace the malloc() + mprotect() combo with just mmap(), creating a private anonymous rwx mapping, which only requires the more commonly allowed "execmem" permission under SELinux (things like JIT or regex compilation need it as well). mmap() with MAP_ANONYMOUS will give us a zeroed mapping that begins on a page boundary, so the result is equivalent to the original code even without a memset() or the page-alignment dance. Verified that the test still passes on a machine with an AMD CPU that has the "ibs" CPU flag. Fixes: 35db59fa8ea2 ("perf test amd ibs: Add sample period unit test") Signed-off-by: Ondrej Mosnacek --- v2: fix mmap() failure check (found by sashiko-bot) tools/perf/arch/x86/tests/amd-ibs-period.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/tools/perf/arch/x86/tests/amd-ibs-period.c b/tools/perf/arch/x86/tests/amd-ibs-period.c index 6a92b3a23ed7a..32713f8fcd5c8 100644 --- a/tools/perf/arch/x86/tests/amd-ibs-period.c +++ b/tools/perf/arch/x86/tests/amd-ibs-period.c @@ -46,7 +46,6 @@ static int dummy_workload_1(unsigned long count) { int (*func)(void); int ret = 0; - char *p; char insn1[] = { 0xb8, 0x01, 0x00, 0x00, 0x00, /* mov 1,%eax */ 0xc3, /* ret */ @@ -59,18 +58,11 @@ static int dummy_workload_1(unsigned long count) 0xcc, /* int 3 */ }; - p = calloc(2, page_size); - if (!p) { - printf("malloc() failed. %m"); - return 1; - } - - func = (void *)((unsigned long)(p + page_size - 1) & ~(page_size - 1)); - - ret = mprotect(func, page_size, PROT_READ | PROT_WRITE | PROT_EXEC); - if (ret) { - printf("mprotect() failed. %m"); - goto out; + func = mmap(NULL, page_size, PROT_READ | PROT_WRITE | PROT_EXEC, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + if (func == MAP_FAILED) { + pr_debug("mmap() failed. %m\n"); + return -1; } if (count < 100000) @@ -93,7 +85,7 @@ static int dummy_workload_1(unsigned long count) } out: - free(p); + munmap(func, page_size); return ret; } -- 2.54.0