From: wangdich9700@163.com
To: perex@perex.cz, tiwai@suse.com, wangdich9700@163.com,
wangdicheng@kylinos.cn
Cc: david.rhodes@cirrus.com, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] ALSA: hda/cs35l41: Use scoped_guard() for fw_mutex in cs35l41_hda_bind()
Date: Wed, 1 Jul 2026 14:51:06 +0800 [thread overview]
Message-ID: <20260701065108.596046-2-wangdich9700@163.com> (raw)
In-Reply-To: <20260701065108.596046-1-wangdich9700@163.com>
From: wangdicheng <wangdicheng@kylinos.cn>
The rest of the driver already uses guard()/scoped_guard() for
fw_mutex. Replace the manual mutex_lock/mutex_unlock pair in
cs35l41_hda_bind() with scoped_guard() for consistency.
No functional changes.
Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
---
sound/hda/codecs/side-codecs/cs35l41_hda.c | 57 +++++++++++-----------
1 file changed, 28 insertions(+), 29 deletions(-)
diff --git a/sound/hda/codecs/side-codecs/cs35l41_hda.c b/sound/hda/codecs/side-codecs/cs35l41_hda.c
index 64a5bd895fd1..818ea8e3f8d6 100644
--- a/sound/hda/codecs/side-codecs/cs35l41_hda.c
+++ b/sound/hda/codecs/side-codecs/cs35l41_hda.c
@@ -1482,42 +1482,41 @@ static int cs35l41_hda_bind(struct device *dev, struct device *master, void *mas
guard(pm_runtime_active_auto)(dev);
- mutex_lock(&cs35l41->fw_mutex);
-
- comp->dev = dev;
- cs35l41->codec = parent->codec;
- if (!cs35l41->acpi_subsystem_id)
- cs35l41->acpi_subsystem_id = kasprintf(GFP_KERNEL, "%.8x",
- cs35l41->codec->core.subsystem_id);
-
- strscpy(comp->name, dev_name(dev), sizeof(comp->name));
+ scoped_guard(mutex, &cs35l41->fw_mutex) {
+ comp->dev = dev;
+ cs35l41->codec = parent->codec;
+ if (!cs35l41->acpi_subsystem_id)
+ cs35l41->acpi_subsystem_id = kasprintf(GFP_KERNEL, "%.8x",
+ cs35l41->codec->core.subsystem_id);
- cs35l41->firmware_type = CS35L41_HDA_FW_SPK_PROT;
+ strscpy(comp->name, dev_name(dev), sizeof(comp->name));
- if (firmware_autostart) {
- dev_dbg(cs35l41->dev, "Firmware Autostart.\n");
- cs35l41->request_fw_load = true;
- if (cs35l41_smart_amp(cs35l41) < 0)
- dev_warn(cs35l41->dev, "Cannot Run Firmware, reverting to dsp bypass...\n");
- } else {
- dev_dbg(cs35l41->dev, "Firmware Autostart is disabled.\n");
- }
+ cs35l41->firmware_type = CS35L41_HDA_FW_SPK_PROT;
- ret = cs35l41_create_controls(cs35l41);
+ if (firmware_autostart) {
+ dev_dbg(cs35l41->dev, "Firmware Autostart.\n");
+ cs35l41->request_fw_load = true;
+ if (cs35l41_smart_amp(cs35l41) < 0)
+ dev_warn(cs35l41->dev, "Cannot Run Firmware, reverting to dsp bypass...\n");
+ } else {
+ dev_dbg(cs35l41->dev, "Firmware Autostart is disabled.\n");
+ }
- comp->playback_hook = cs35l41_hda_playback_hook;
- comp->pre_playback_hook = cs35l41_hda_pre_playback_hook;
- comp->post_playback_hook = cs35l41_hda_post_playback_hook;
- comp->acpi_notify = cs35l41_acpi_device_notify;
- comp->adev = cs35l41->dacpi;
+ ret = cs35l41_create_controls(cs35l41);
- comp->acpi_notifications_supported = cs35l41_dsm_supported(acpi_device_handle(comp->adev),
- CS35L41_DSM_GET_MUTE);
+ comp->playback_hook = cs35l41_hda_playback_hook;
+ comp->pre_playback_hook = cs35l41_hda_pre_playback_hook;
+ comp->post_playback_hook = cs35l41_hda_post_playback_hook;
+ comp->acpi_notify = cs35l41_acpi_device_notify;
+ comp->adev = cs35l41->dacpi;
- cs35l41->mute_override = cs35l41_get_acpi_mute_state(cs35l41,
- acpi_device_handle(cs35l41->dacpi)) > 0;
+ comp->acpi_notifications_supported =
+ cs35l41_dsm_supported(acpi_device_handle(comp->adev),
+ CS35L41_DSM_GET_MUTE);
- mutex_unlock(&cs35l41->fw_mutex);
+ cs35l41->mute_override = cs35l41_get_acpi_mute_state(cs35l41,
+ acpi_device_handle(cs35l41->dacpi)) > 0;
+ }
sleep_flags = lock_system_sleep();
if (!device_link_add(&cs35l41->codec->core.dev, cs35l41->dev, DL_FLAG_STATELESS))
--
2.25.1
next prev parent reply other threads:[~2026-07-01 6:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 6:51 [PATCH 0/3] ALSA: hda: Use scoped_guard() for remaining manual mutex handling wangdich9700
2026-07-01 6:51 ` wangdich9700 [this message]
2026-07-01 6:51 ` [PATCH 2/3] ALSA: hda/cs35l56: Use scoped_guard() for irq_lock in cs35l56_hda_fw_load() wangdich9700
2026-07-01 9:46 ` Richard Fitzgerald
2026-07-01 10:03 ` Takashi Iwai
2026-07-01 6:51 ` [PATCH 3/3] ALSA: hda: Use scoped_guard() for open_mutex in azx_pcm_open() wangdich9700
-- strict thread matches above, loose matches on Subject: below --
2026-07-01 6:49 [PATCH 0/3] ALSA: hda: Use scoped_guard() for remaining manual mutex handling wangdich9700
2026-07-01 6:49 ` [PATCH 1/3] ALSA: hda/cs35l41: Use scoped_guard() for fw_mutex in cs35l41_hda_bind() wangdich9700
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260701065108.596046-2-wangdich9700@163.com \
--to=wangdich9700@163.com \
--cc=david.rhodes@cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wangdicheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox