From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3D223BED38 for ; Wed, 1 Jul 2026 08:16:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782893783; cv=none; b=pTTuPnQJj+e9gOEq5YcwMGL+VTRL00wTdqs/HG+acr8fXq7dbtLkYFHThrc2TZ/4oemYIYrOo2GpYNBOYqtiYqJO50G+LAFZAxO3bdNcKVUCQhKbgFKB5RwVKYaYUrg3JA79Mxmfzw5kQvP5hT6lzSO9V5+S3iL0hBG16W9brQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782893783; c=relaxed/simple; bh=177yDnaR9yPvT58j2LfyrOVRkGL76Chc8Mj0N3D33Xc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gPZHp9js776OZGfblarN2tH2nEUW0xMXggFkGo8SbcJVWiGPNkZa/jvcdm9pRMsjTNEWhX+OEWlsrQN4LI+Rj/JJ8kZ+ckC4w4xK9CA6BsBx2YEML6Dg3CgLb4GruTjSqFJxea7sCm785myxxLA9k7oE6KxW3fioGiIclz4YFe4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kjIp1lIa; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kjIp1lIa" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3804fd3cf71so180225a91.0 for ; Wed, 01 Jul 2026 01:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782893781; x=1783498581; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sw4CMyJ7o4eJHTpqYUHzkvZXiVgvqV7kRPHSd5Gk6d4=; b=kjIp1lIazDuiSy4r9tE2SA+CRp3loAP/8OzXrA9ebpQLgXWhvIiGuFFlsi1jhPeVPh /SVjNircpn5yDOEdmN6KzF+N5He6tXsf2UsBCPysDETpqp/jNsp61IviJs9ArjsR9alb a3wsuzLAyZ5+WihmeIqRXAUSfg4faNaAlVrhrjI9JlGMtN8Z4RSQLc9R9+Kv9Fo/rSmp 0gGy3uIjYNuOVztTp1mSnoZORyMB4dVL/j4gxcUZSsSJoTrw8kP7hwkEc2noZIKI2c02 D2QHw7VAppYcFoxiAyS9SVPtm/JTlPcsE43ObLajDznagMl+87+7lVCi3v0GTvcPMDUq ST8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782893781; x=1783498581; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Sw4CMyJ7o4eJHTpqYUHzkvZXiVgvqV7kRPHSd5Gk6d4=; b=S2y2gkgKJmllbwtyJ1wOcRjo0ziO6f6v+vdhIJg/ICNcYZiW7mpE5tXbxeCvjTFnfR lRxBf6KFMHp8pFT+O9ANEpbTAvCt2Wz9lwxcZLNImv2Z9v/bMZWSR8kc3TPsxparNfvd 6tbbX/xjEZU8iXZh4nsQnFhbLf1wHptLiWt9wd8yim8NJYXTYjjeRe7mBgkQhFgSMifd IgaFlG4bPaaHXspKct5SXO4rQnedD/Ynd2NGQrneplgNWrlZaRzv4YHYPYXmQV/tSJZT wRZZxdr0kmny/Sg2Tkr4VW51tW372kdeCsBq66Yy4jcSZgcS0ACjcSXWyk8qD30wKCaT spsQ== X-Gm-Message-State: AOJu0YzaYL2ZLqACHVFKzGRiws0/ZuvmZ6Fxv/eFdYXuKoC5lb86Ldhk xdwI2573/X4peSVuE77tfp81ZbKB4S6786o2j+Zz+KXRGjnjrDhcUqeH X-Gm-Gg: AfdE7cndFTLEmc77G1fu9vs0yX/ZA9EB2cpELM1tSTaX5Bg9yuO8p8X747qA4f4njO0 uamdUJJepVebaQOb8FQg14NqZzzLnvjigIwvUNaPzkvTo1djrZJ5fdh+hbhj8/E19MkvhipDqe4 E2DDmPxwsnATedK0rCqWaEawBObJt0mUEw5d5vYzMDoURB+QPfcoetRMXmj3AyPsDqaoJOkLVH6 5ztpzlERGRYxfj1IIqrfTQNSJiFf6n3Hs8FKsaHpRRMr+jSChIHpwLS1RiUTtA+d1W/R4ooeR4y a3AMVYCji5qYqFVGpHKLOCiuACjWfhqVZYEL4yrdEn/U4yJwInB6AqUI5Gjp/hw0aukaGEm8qKf e/hlgrzT/2ucIoAaIH4iNoDfy2h1s/7OSI8NZJDVDCNulhVGuZ0mzktnRoYG/1KdLDFnJc7VJxb akJZeee0XRdt87odoh6MwxM/Zj+OM= X-Received: by 2002:a17:90b:3dcf:b0:37e:1ff4:44c0 with SMTP id 98e67ed59e1d1-380aa0f4adbmr625565a91.12.1782893781227; Wed, 01 Jul 2026 01:16:21 -0700 (PDT) Received: from amd.com ([165.204.156.251]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3809641c894sm1364627a91.11.2026.07.01.01.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 01:16:20 -0700 (PDT) From: Paritosh Potukuchi X-Google-Original-From: Paritosh Potukuchi To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Paritosh Potukuchi , Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH v2 2/2] bonding: reuse neigh_setup from slave neigh_parms Date: Wed, 1 Jul 2026 08:16:00 +0000 Message-ID: <20260701081602.3185086-3-paritosh.potukuchi@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260701081602.3185086-1-paritosh.potukuchi@amd.com> References: <20260701081602.3185086-1-paritosh.potukuchi@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit bond_neigh_init() currently relies on the slave device's ndo_neigh_setup() callback to obtain a neigh_setup() handler. When an initialized neigh_parms instance already exists for the slave device, reuse the neigh_setup() callback stored in it instead of invoking ndo_neigh_setup() again. If no neigh_parms instance is found, or no neigh_setup() callback is present, retain the existing ndo_neigh_setup() fallback path. This avoids unnecessary ndo_neigh_setup() invocations while preserving existing behaviour. Signed-off-by: Paritosh Potukuchi --- drivers/net/bonding/bond_main.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index e044fc733b8c..d2e4dae4e97c 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -4719,7 +4719,7 @@ static int bond_neigh_init(struct neighbour *n) { struct bonding *bond = netdev_priv(n->dev); const struct net_device_ops *slave_ops; - struct neigh_parms parms; + struct neigh_parms parms, *p; struct slave *slave; int ret = 0; @@ -4727,6 +4727,14 @@ static int bond_neigh_init(struct neighbour *n) slave = bond_first_slave_rcu(bond); if (!slave) goto out; + + p = neigh_parms_lookup_dev(n->tbl, slave->dev); + + if (p && p->neigh_setup) { + ret = p->neigh_setup(n); + goto out; + } + slave_ops = slave->dev->netdev_ops; if (!slave_ops->ndo_neigh_setup) goto out; -- 2.43.0