From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64133425CC4 for ; Wed, 1 Jul 2026 10:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782901796; cv=none; b=F3CSUqCYbwAQfVP9SnrvsarVCD/AfhHOkA5blplHs6J9rBVw41EWhx/+vZdlh3VorkbYK2aooFjUhJ3ALmAGbJG+40E7HJlFMURRKeLwoyY56lz0uS9oJchhuTG6JTl0I45DnH7IwnPRhQXvCYnqHEZNvyEk0dGVU93hLgZQ6NA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782901796; c=relaxed/simple; bh=a4U8rQ9U8yPwro1DPxYVDCbokTGOt/Po5BbZSokWPDU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ddCnYxx7X1fVXuPyAvUUOSgn3twg2FFlcGLJH/+GC7jV6+/eJuZB2BjMgAav4JmAZpNWKGEXq1IzjO8OQ9pgmQomak+D6kB7UbMB1We+SEkPjyBIQmA46UWcxKFA1pr9oLm4i0L6orPpfXXZqphqIfBSuwiboSVvomCdCxFP4zc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N8Q7ocsO; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N8Q7ocsO" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-30bbe98c3f0so1092244eec.0 for ; Wed, 01 Jul 2026 03:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782901792; x=1783506592; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZZMCWACMwzKqJvaEkw4AdQSHyt0FLtQuCecBrJDnzH4=; b=N8Q7ocsO7YPB/s30r3aaiduEm/lQCavQR0yzBOYgPwcF8qPqb/D5B0FDxQpEFRiiPL KAunb0TgCuPRSxC1D4k02yfJfmRvgsk2mCUDdbyJDmBthdgVoH1xbeRtZAmeTD5I5ONG 3EHMTjjiQe9WYzLZHPpz+FpP5cHY1pIQXdVPCxvrJ+orD0RrhDSyJr0YaAkGO0omh3OC mpOpXQ4IR/oozN47aLlsVkoU8DXSicZwcstYhVNsncfICdFmLvlMK+agNLBMcUDswSDT wCSt/ni0BxsscUjdtyUZq9Qf5fsxmAEsU6pAGfBr4G8MpviJaQ1FsbwiCpIQwfOIMxsD +ShA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782901792; x=1783506592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZZMCWACMwzKqJvaEkw4AdQSHyt0FLtQuCecBrJDnzH4=; b=pP/uBaFcEJJvPX2J1XQfhh9gb6WvXJbSHvlLwW3QrH2MoxhHse2kj1WMhWuwbxUQ6b nY5Ie1j223HXb4K+/+n+M93/Q6tHRwUmiRb3enhMTUAx5UzBVtu48YBpGikciFoVGJDj /ZGDJ6YYsDqf3+qPJfRNBbSdcMQg6C7DGaplUOWm06JGgEqVR4vMSi0PF59WIa5GmV70 /Wsm4Rif7VXJ4V/eLrIXvaXGtznilq7md3v82JgO/+DF18OPKsxB3cohrJ6B7GRBTmWA HDVKrTAYIbwBQc/bO9r0aw5fg8uKly4L9AUJxgOZM1pDHTHIRDst57396s3YiafQKRkE imOw== X-Forwarded-Encrypted: i=1; AHgh+Rrlt7yJ2m+ExIxLXRqyLjzTzfQHKLyc5c8Z7IzAfzfhiJYZt/f5klcHAQuZvBx3pQSMB8BDs6JxaopLkU8=@vger.kernel.org X-Gm-Message-State: AOJu0YyEz50Ha2VRRM9MODdSewY6ETaBzs6EAJfNlBh+CyhyFRu0JXMM 8p2V/XptJNxHWDffucvTilFVy8Ro9SMrJB718Stb1wWArqHj7IcTes2TxeH8+rV+RMQ5+Q== X-Gm-Gg: AfdE7cnikRQ7qXVO7Ny+dd/5ZL52lg5g4Y0ISGtH1qjlVrtzXwgYZUTAky0DIZRFIbG 2rdK2PTLzsZOIJMNfzfMfice9y7DOzTuxwxUM6D0agf3gyjkQyLrz7hSfWH2EBa5CuoFCJ6DUIz FGzQk6sWzcYZnbIyUUx1g+YRot/+JeiYZ3JfPxPR1MYfkqxJHTsiXrXFAU3B4dl7LgQ8vYSzsTV Bfj14x5xdHunsnVynogxU5+RQ5Q2P24VwQBP9isuMF5b3Oif3TYYBOyysliSON4RUbuYYpz25YY ZG6idyHypc8eXqwmxXQxwAcl5/gMGd0Fjw3p9V4Y8UXehNxS2hnfxPCuUYhSI06PbZr1m+SoAlp qb3qhleQKVE1+eGHtrloNvAcZZLap0I6JRbOAFtXpcfZYq5ydoSLXtlN81Kz559hjDeICT9LlOF /Mwulv9aF6a7T/zMfjgC4mPko= X-Received: by 2002:a05:7300:fb8c:b0:30c:9f31:b604 with SMTP id 5a478bee46e88-30eff294ff9mr1275666eec.25.1782901791971; Wed, 01 Jul 2026 03:29:51 -0700 (PDT) Received: from nbai25050028.. ([2403:8600:2090:6f:c5d7:7505:b0e9:be5e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ee317095dsm27602019eec.15.2026.07.01.03.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 03:29:51 -0700 (PDT) From: Aniket Negi To: Lorenzo Bianconi Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, aniket.negi@airoha.com Subject: Re: [PATCH] net: airoha: fix MIB stats collection to be lossless Date: Wed, 1 Jul 2026 15:59:44 +0530 Message-ID: <20260701102944.246106-1-aniket.negi03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > Maybe better mib_prev? Ok sure will update. mib_prev is cleaner and more concise. > Since now we do not reset the MIB counters in airoha_update_hw_stats(), we can > get rid of the for loop there and just call airoha_dev_get_hw_stats() with the > provided dev pointer. Even better, just rename airoha_dev_get_hw_stats() in > airoha_update_hw_stats() and move the spinlock there. What do you think? I am aligned with your suggestion, Since after removing MIB reset logic, there isn't need to iterate over all devs on airoha_gdm_port. This will simplify the code significantly. I'll refactor as follows: 1. Remove the for loop in airoha_update_hw_stats() 2. Rename airoha_dev_get_hw_stats() to airoha_update_hw_stats() 3) move the spinlock into the renamed function. Best Regards, Aniket Negi