From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 657883FD969 for ; Wed, 1 Jul 2026 11:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782904354; cv=none; b=hhTkwtG2nig4U4DHybwx2jGC8BEOcdEEtEl+tusUN9HAqHj1fZzVm7hHbSc1REyR0xU4fQb9Ss2U/qTeQHiRuZgTlsMC3ZozjvyiDe9ZvLPUimMvPwHemGm8J9EDBRk/hIUTyEgYppaZSKCZurLXC0fq2ogHCy1fITn0WyRBlug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782904354; c=relaxed/simple; bh=aeXVj6xt4QLaE5ZubVLapizM3pMzsZveZsZvA4exgZ4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=LrSbbTgCeiN6XjkP4K4s9GiGw47W6YrgovPmqje1JNOx7AXMFPapmDPm5eIm+KK/ts7wbo0rru6cnNnp15m3XT21w0IWwZYW86w6J8tG5dcZaU3LwMHhI77W3oJ2y0rTrTxTot+ba3fmBECE6mQ/De9qHazNpfTYkLPldmUR6kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R4Ob0bBk; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R4Ob0bBk" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2c74383c93cso4333465ad.1 for ; Wed, 01 Jul 2026 04:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782904353; x=1783509153; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SWJtxV4Ta72iy42vKEzWLu7hcuhePMIVVuTHVh0+3Bw=; b=R4Ob0bBk3lEKb4xAyIkFLcf5k31lef9NAc2PGKv1DNcrGEITFCYCwWHkLNti3tpgEZ zZVvnk3UdaGD7XEaWdVGGIQBPmgXCnUasW71a452uO7F+NEGmA+M/g8UPZvOOs6wzFVN TejK6oZnF/Yf4r1/7T7XvxqYUA+VFMNr4CgKzS4sCm6gJDWKsT3jbgHjASr2j9lVmeZg V6KS6cpI6zwDSCkP58GgCk3DiQHe0xaD2yw/ZuSPU2kIZn3cSC5DTTJWm+4w94gslM4S Q/0CS84f5cin9tJEY1U2R42YHRAsk/UsDmhaJ/OIuD/jwgn4NILEFJkWFIj1EgM/82rG 5+gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782904353; x=1783509153; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SWJtxV4Ta72iy42vKEzWLu7hcuhePMIVVuTHVh0+3Bw=; b=Ys2139bTsofjUgtTWLMhhUFXnbjn1hQnXYn9XeOaZ8qZjE1cSQAMbPu59Lh7AOWutt I2eqq4qyZQdRcTtyHYQMa6mkWh/QbMcuFXJsWc51DXyP7/W4wDHIMqLudYYs7sat0wuQ xlDIraz4WPlo5jijPkNVrhutI6sCI4AnTdvMO6Jtf4PVPLgZmLxwd5JCFa2mNSj7gqKX +VVuP3sRzNXnS9LJzF2QyWTV6eDjRdeSLv4s220VKHSm913oRY9j+a41Fp+1aNdjtJWF HwbrA2rVAGhhDv2FkZB5eVZMMJW9Wty0jGAf1+Y93HTIqfoboQeXLqV+GX+er4iPw12+ siOA== X-Forwarded-Encrypted: i=1; AHgh+RpxYSI8lmqhw1F6xir0LnPiNi2PPYxS/eXEjK8ql2oQKiM3oCjeBQJegqQTDVxT675EEv/p/GoyQPAXP5I=@vger.kernel.org X-Gm-Message-State: AOJu0YynckOejUWf1x2+g1AsONWkqvBX9aFRuD9xRAX2ZSb9PKpNi87J 5UrXgpDgCKQs3lX2KT+bdeiyIHSuQr3917PW7BV5UL5MBPL2K8VufRQ= X-Gm-Gg: AfdE7cmmHK4cOgXr1qs1vjKZmwDx/vm23m3Mg4ZNlYJwsBlu7FHvDf02goReXsBOBO4 kYknKJ5bKQvGweWWzZTy3uOvHUi3T0R0VQsHvnz7599lhexYdX7E0Of6zWDpb5y+dJCL841WDWy 42WdXaaPx5MqZoxIraNNJ5yDterB/Ks1l5DMmexrZMzYcSrGeEJwxUkEr+gO97aY81Ln8Xq1HZO RWyitPntDMUc1//jZmndgxBDnF4bzSMe3unGNPm6qscbkL3lXD52jByLOuOBDkAWmpOYLkgLwiJ TtjVK9Bkrotzt8rj6lw/8ZWEChhwEVIi4BvSzFTWpOWQUwKhdc42mGJuALk+j6u07q+WuP+R/xe fdQo0JuggerogcYkioSCrOD5yMJ/CyqmxwQ7IZMBdtXu7tACdqkYcCqmaJHzLDJoMQMSPvQOJGw TeFBaQMg8nlYilZLBdKRMSCJ58B9W88wxjQFFDuor5TzUPbiFn8LTXvKNEs6yLHmwTtFwpV6A/L IdMtMvmKPFjDUosXv8fTb/cHURbRPwyAgh6O89jfewXDY/4zQ== X-Received: by 2002:a17:902:d4cd:b0:2c9:bd64:8c81 with SMTP id d9443c01a7336-2ca7e6d9f27mr12395735ad.18.1782904352730; Wed, 01 Jul 2026 04:12:32 -0700 (PDT) Received: from localhost.localdomain ([14.5.152.27]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca37a71053sm30977565ad.8.2026.07.01.04.12.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 01 Jul 2026 04:12:31 -0700 (PDT) From: Myeonghun Pak To: Michal Januszewski , Helge Deller Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] fbdev: uvesafb: unregister connector callback on init failure Date: Wed, 1 Jul 2026 20:12:24 +0900 Message-Id: <20260701111224.48646-1-mhun512@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit uvesafb_init() registers the v86d connector callback before registering the platform driver. If platform_driver_register() fails, the function returns the error directly and leaves the connector callback registered. The later platform-device failure path already unregisters the callback. Add the same cleanup before the final return when platform-driver registration fails. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 8bdb3a2d7df4 ("uvesafb: the driver core") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/video/fbdev/uvesafb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c index 9d82326c744f..ccc9dbc25813 100644 --- a/drivers/video/fbdev/uvesafb.c +++ b/drivers/video/fbdev/uvesafb.c @@ -1907,6 +1907,8 @@ static int uvesafb_init(void) err = 0; } } + if (err) + cn_del_callback(&uvesafb_cn_id); return err; } -- 2.47.1