From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E1293FD946 for ; Wed, 1 Jul 2026 12:16:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782908195; cv=none; b=rO6TqfnqDNuS2TPKIl3IKKdcP3OKpUODbRs8VOA+vefQOIYMwzK+Q3KqSs8py4HzlyWUn6h1Pq+hYX1SfuwphxXRTXNBJQ/CHD83FwmwX1vEVt6ncn10W3S/ba2vZ8q4O89q9gIrx9Qyn/LbljVQ+DPoHi43J3b3/Hyg3vEo+Ag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782908195; c=relaxed/simple; bh=obE/b2q8qcrlt5PUa6k2aHlJSkiqEXB5r2KcjRfVFPk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=LraOslyDK5Hsv3Uy5KPHdScRThaVvEq8pDF9Rq3biqvmzLeyOBVf6lvDzlvSBYSAndjiHPaVDCtFb+mtFW/0BJFKih4xF7puS95ept/quRMRaJPc1O0UeXz1WRHKWVCx5OrqPcL20jBc1cUULefYSvANHG3EXdjSksnU26WZWtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=apv7xM2d; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="apv7xM2d" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2c825c88744so4602545ad.1 for ; Wed, 01 Jul 2026 05:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782908192; x=1783512992; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FefiUA1QiWl4Hiij9NEBlfC5wi8+6dRKuxnJt8tS554=; b=apv7xM2dU7EBm+eJRqWpFpYF+fgLZGFwbVw/lY9T8kxfSNfz26SPJ6J/0+4nfEndcd Axv0Y7mvdQSXZN69HPfpXeg86hoBPIlrAnz88vaxjzWG9R9ug4r1Mfy70LW1+jfK3onA onCbd493GSrsnLlGNWdoeqjRDkw0u1TFPk3HyHYAVULEBdRQRR9j4tjC+E19e+PZnEjw nK+SgcDaFO8iJsQBIIt+IiaseKGuIN925ANtdvfigCaWFmaQ1qePZqKH5dyoD8n9xaF0 u1LBGzp14zhmUTIb0wPT2njm5SazFU21M2jlYOy5//TYfAXuDYeo7z+qlBbmPa+3L7zt oQfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782908192; x=1783512992; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FefiUA1QiWl4Hiij9NEBlfC5wi8+6dRKuxnJt8tS554=; b=GMf2pjaHynon3xz2inKQXsKa2gxJGI2CAesFBCqnCWpwZ/MtxP6UPP2bNAk+BBm+d6 K3IH4CvJA8c4V6csmBfCp6dDy65q70EEeRtPjNCDO5Aru95Z/Le+aV+Jw6KcsvgrrDvr DkujB30agA3+Mr3SUuuCFr7HmyPC4YCeVift6kIQFmCkWFHVOjx9lddlZZkxa0HlPPu7 8/Bulib3r2qlcmx7WiRtgO6jmRUTbInzj5/GiYwGrPDqVG7WWwREoqVO4D1N3w1VaOyd ZVwhj931S9PCXffJmyOn/yUkJbKaIEssqmfguCwpSsO03hqN6NeA5emFwKDuMoGqnKAH qhtg== X-Forwarded-Encrypted: i=1; AHgh+RowOoDMf5qF5uMMrQCTUNuWJ6DnCjF5ZNhL8iJkJ2U9zce2DaavRywAwdPA3plaTf5sOGLei4gniM9GS/4=@vger.kernel.org X-Gm-Message-State: AOJu0YzT1HjADI7bS2/mb6LHvNTPVwGifVCRrKCAd/l3HKk9rgDO6A1S H5UPHgZfqIXGEcxmy8Kgj2gbwHCJhI3EWByLNfSDWYTiighau7+s1mM= X-Gm-Gg: AfdE7cmdtVwCd6e+m1/Rn1cF+Zx9eDA49wTqzRUPdi4rxxTZwmvQ6Q+PScs2ryXPpIl m/5cLhTkC8BaVIuVaRZL/mvzbdaM5cRCpj4iYJ7zKSiRR1lzNlNgGSFnPjslYx5/6AzllmCd9pu cLfXbOgX7D0drUv+zSf0l79WqVSUT53W7Xohryezg/jk/Y01JoDOLQ/SRTFbqJo49LxszU2UimA yfyUtZg8LI1YLbAYXBRO7hPw79hm016TOkDn23CCqQN43zd1QeLHHp8zSJyooyoR4yJRDOoNisp phj2u25gfJdMo7oEGN0OvBEzwZffHt74eyGshiwfgsvPE1K9NFnpVWwS1c9uFJMNbCXMUeJUnJO fwsPPpw9/+KlqONvmHgifrWTgeriJnTGOV+mfg5H4jJ6yjTa1rv+uclmJgmZc0IwYZ3XnGnurNi uRvryLcQ3wd8pW6RmEfebSbY8xyxSGk736/wTKEbmkC5KPCqzaL/qgBufPRAgP+RhT/GUqFWCXS i+WJRDGR66zHi6LWocM8jvxp6bG9hB+9URpDFouiceRmPam0A== X-Received: by 2002:a17:902:e851:b0:2b4:5aff:de60 with SMTP id d9443c01a7336-2ca7e7579a1mr15832145ad.22.1782908192336; Wed, 01 Jul 2026 05:16:32 -0700 (PDT) Received: from localhost.localdomain ([14.5.152.27]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca3828c2e8sm31114115ad.43.2026.07.01.05.16.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 01 Jul 2026 05:16:31 -0700 (PDT) From: Myeonghun Pak To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] usb: sl811-hcd: disable controller wakeup on remove Date: Wed, 1 Jul 2026 21:16:25 +0900 Message-Id: <20260701121625.96815-1-mhun512@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sl811h_probe() enables the HCD controller device as a wakeup source after usb_add_hcd() succeeds, but sl811h_remove() removes the HCD and releases the driver resources without disabling that wakeup source. Disable controller wakeup after usb_remove_hcd() and before usb_put_hcd() so the wakeup source object is detached while the controller device pointer is still available. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 3c9740a117d4 ("usb: hcd: move controller wakeup setting initialization to individual driver") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/usb/host/sl811-hcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c index 4ae47edd4b8b..b044977f6f56 100644 --- a/drivers/usb/host/sl811-hcd.c +++ b/drivers/usb/host/sl811-hcd.c @@ -1591,6 +1591,7 @@ sl811h_remove(struct platform_device *dev) remove_debug_file(sl811); usb_remove_hcd(hcd); + device_wakeup_disable(hcd->self.controller); /* some platforms may use IORESOURCE_IO */ res = platform_get_resource(dev, IORESOURCE_MEM, 1); -- 2.47.1