From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48521391E51 for ; Wed, 1 Jul 2026 19:27:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782934068; cv=none; b=UAAnjOs0tgV2yIs9aA4UZRrrva74EeJWtpraBu1Ch9LtCN18infZ8HD0EBFBm+XHo8lwHQaLEwVBwpCKjtdWi5oP5gLoBXblwj51aYHzuLfPe076l6ge6Y5Vzh51E3Njq3G+4EVcF0aVHcNH8VvpWzeJtEYvPZDKhFMUurHolds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782934068; c=relaxed/simple; bh=wTDfiSoZQ0eSpb8jgaFejD+z6JVXcc8fmJWHGyFu11U=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=B9zi6yYX+UFOMFEw1vy4fbKhm/C7ZBQifnY1XqxQmY5afQ5gW4xOrJA0qga/lFBDO33zaqJ7EgwR9+uwwbbOPGoGSSekxJK77RoGZtcGBgxf4hJoJOC43S/SJLwSd+c2MXhbe84tiTfCppa7cXHvSabnOMdUrJRBOsy9ZlLSKT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=W27ryESd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="W27ryESd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8116E1F000E9; Wed, 1 Jul 2026 19:27:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1782934067; bh=gt+A1Wr/G1h4kMqCbndYt8VkS1q16uqqs8XxNPh20sI=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=W27ryESdogM0DUhuoe4CFNiTEnfMsAf7nIapQUhol3l26zWPsJG4QpYAYOUBEeFcT G1oVKlXUp7n7zScO85y5bE2F4oxPbyLSNqtZ+igp1RjLYNby6QRHFtm1l1eV7PZom4 5ruolwLIppEy/azavW4HVkC3DXz1+iDieQ3dARC8= Date: Wed, 1 Jul 2026 12:27:45 -0700 From: Andrew Morton To: Zi Yan Cc: Usama Arif , apopple@nvidia.com, byungchul@sk.com, david@kernel.org, gourry@gourry.net, joshua.hahnjy@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, matthew.brost@intel.com, rakie.kim@sk.com, ying.huang@linux.alibaba.com, shakeel.butt@linux.dev, hannes@cmpxchg.org, kernel-team@meta.com, sashiko-bot Subject: Re: [PATCH] mm/migrate_device: pin large folios before splitting Message-Id: <20260701122745.2bfab3347691b658fb93f601@linux-foundation.org> In-Reply-To: <78C557ED-3CF3-4558-9BA4-C43B30E63F67@nvidia.com> References: <20260701140638.840773-1-usama.arif@linux.dev> <78C557ED-3CF3-4558-9BA4-C43B30E63F67@nvidia.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 01 Jul 2026 13:02:10 -0400 Zi Yan wrote: > LGTM. Like David said, the comments might not be needed. Thanks. I like the comments! They may be uninteresting to those who are already familiar with these things, but they aren't the target audience. How are others to become familiar, if not by this?