From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FF6634252B for ; Wed, 1 Jul 2026 14:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782915685; cv=none; b=OTeI96GZEDj+xrzjk5Z+6fDGWv6ywer3BTNe6v7vlBr7zgHxaLoOwuc7avE3po2RdYPx+zw6yEQUhNNgHWZQTakR65EWrOwH5iSclsllujc9b0bQBusCRUIn4UtfX7uFtobmbOfwjbd/VieEWtJzNsWUGr3ma9baLNnG0RnCZSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782915685; c=relaxed/simple; bh=ipUR6dbEPBmy9uhq14GIyEe4KQRS624Rt/8LIK2vngM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZUW3E/MuSYvZJQkAe25dAsOTCIyC89eh2Z14wNOIj1KwaU4XsCCZUYfMofFVj87CGSzMqeS6xj4HkDlIcypbxGpiGSTDXy9x1Z1IWD2jRh2t82c60ZEKJl7Sw9RrcVo1CXUktUfzu+HO+zqq3VZzdYidoZCPpgZw8JYtayNbqFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M5V+xAr5; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M5V+xAr5" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2c9c9916f75so3439235ad.0 for ; Wed, 01 Jul 2026 07:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782915683; x=1783520483; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=geZt5mwfxGU7cGsWcrOJqyhUil97cE4hab/MkWGmHSU=; b=M5V+xAr5Ml0PlQFgEZ5X77JUVwsSdGRdqy6IdlfBmuHD+D8zybMbOOIMt9Dusfdy+2 wWAZ6TOKLOEq1bF7phX40KQA48wyDpMlEkXk84qt/VaaisDLgKo3wboECGvjCQ07otNG v/9/NwztKUTK/2tfmugu7gGoQWbbuUZst4VjBXGCupHpYPfRA9KVMOeZG2jOh0F70gfx Tr9rAI64XH47bjQjWetmJEIf3fzqrr31FjvIeqrexEd9HQNLNaMbvcXnO/i0Df4ElvWG QPmuJ4mD4XrRuIkNI/Io9MEVwky+vY9diSExymFKRC8c4PQYAL0IeEXqoQdjxtpHNz2Z YbPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782915683; x=1783520483; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=geZt5mwfxGU7cGsWcrOJqyhUil97cE4hab/MkWGmHSU=; b=UjtW+CqKRSwyAIFwicDCqVcY/4643h4KzSjUxUzbtZzKQ05ZzEtWBNk/595DST7q5g 8TYo45RjasJikS9M/erapzd5tJpfKJ45+r1PafbQR6DWnKDI3EcHjCjgF4ci07HknNbf 75a20k1fRMT/XZXWvedtUCPstdppvqrWxggzv333VZI3/QL9bTpDNkLA8U5MyRjGuK/g 22oACVDOcFw8vCQzRm22Qnwuwq8rXuYl5bVqicFRBWtOcWxgjWPNryP6Lkt07JpDWQVR fmIUAGOU8J3H7W3YO2rKiZXqvk0n8ID1TIK8dxv1eJ//6y+UCiFuc8vU/LA0ixNCsdOZ 0FAw== X-Forwarded-Encrypted: i=1; AFNElJ+QQy3Rw4KzMiq9A8SEWd3pBu+Nwm9v/GZn3WUSbUneLJR56kdfNGkFiODY4nHqSHR8huE0YqmHMOsaR0w=@vger.kernel.org X-Gm-Message-State: AOJu0YzQl1o8IHXEY0eAQw8uem8x17pVqcZxYP5iAA/4jgyqDvrCRLjy knPd6BtPEoZbxR+YhqVVyPl1dDtdJU8eR1kNMBm6sDOPAG1pqiVPM+6R X-Gm-Gg: AfdE7cltqw4XEjAdpYTL2atrQQ1XL7yav7vd5nHiUQGH5M/CoiVoAtYV4pOWEYbDwwf z5aeBhOmERghZJzriOyYHdxA0ABuPw8puBI8og8KT1pxAzn6/gsXwerd5+thHKVxGYXWZap2s27 I5lQThfkQXrhhqLWJlTtNh/rug9A8EanICjF/i/0qtO+PKxMxkRKGi9RNeJmndgKWL+Au65NK9B e1KjHU2ergwsK1GwGx2XdiTQDzOjgrKUa8DYfn523WtjKCbvmdmdqopuJ0E/A3b2xhKoEL/4PEU AVjwWvyNwaPqqWwSQ3A+dK3IJx1nEpXLcknSFMZoliQd8MmIY43PNbX4y8jvQ0ZKOz6JsSjMvg8 gOUserdvnRxP4pvFVeeZTeK1RUJVjeFx9IFCeRdi3OS9tlbKEYyD7vdaEorjm5/fxOrF6ThZCXl NWrPE9WhKlXT4HwdRAxaHRcY/0OhIyK4EQ X-Received: by 2002:a05:6300:6715:b0:3bf:a0e5:999a with SMTP id adf61e73a8af0-3bfed41d909mr1937140637.48.1782915682831; Wed, 01 Jul 2026 07:21:22 -0700 (PDT) Received: from DESKTOP-DK6PUT8.localdomain ([124.70.231.46]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c9e32ef8e49sm383894a12.19.2026.07.01.07.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 07:21:22 -0700 (PDT) From: yizhang089@gmail.com To: linux-ext4@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, libaokun@linux.alibaba.com, jack@suse.cz, ojaswin@linux.ibm.com, ritesh.list@gmail.com, yi.zhang@huawei.com, yi.zhang@huaweicloud.com, yizhang089@gmail.com, chengzhihao1@huawei.com, yangerkun@huawei.com Subject: [PATCH 5/6] ext4: write back partial-zeroed edges in WRITE_ZEROES Date: Wed, 1 Jul 2026 22:20:08 +0800 Message-ID: <20260701142009.1510104-6-yizhang089@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260701142009.1510104-1-yizhang089@gmail.com> References: <20260701142009.1510104-1-yizhang089@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhang Yi FALLOC_FL_WRITE_ZEROES requires that all blocks in the requested range end up as written extents with zeroed content. For unaligned edges that were partial-zeroed in dirty unwritten or delalloc state, the buffer is left dirty while the underlying extent may not yet be converted to written. As a result, a subsequent SYNC write to this range would still trigger metadata changes, which violates the semantics of WRITE_ZEROES. Fix this by calling filemap_write_and_wait_range() for partial-zeroed edges to flush out the zeroed data and ensure the extent conversion is complete. Fixes: f4265b8d32c4 ("ext4: add FALLOC_FL_WRITE_ZEROES support") Cc: stable@vger.kernel.org Signed-off-by: Zhang Yi --- fs/ext4/extents.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index c34505765521..c083703bf704 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -4791,7 +4791,15 @@ static long ext4_zero_range(struct file *file, loff_t offset, if (IS_ALIGNED(offset | end, blocksize)) return ret; - if (((file->f_flags & O_SYNC) || IS_SYNC(inode)) && partial_zeroed) { + /* + * In FALLOC_FL_WRITE_ZEROES mode, edges that have been partially + * zeroed must be written back to ensure the entire zeroed range + * is converted to the written state. In SYNC mode, writeback is + * also required to persist the zeroed data to disk. + */ + if (partial_zeroed && + ((mode & FALLOC_FL_WRITE_ZEROES) || + (file->f_flags & O_SYNC) || IS_SYNC(inode))) { ret = filemap_write_and_wait_range(inode->i_mapping, offset, end - 1); if (ret) -- 2.53.0