From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08907257824 for ; Wed, 1 Jul 2026 16:57:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782925067; cv=none; b=VjAVmxFnsF6j0ZLTAP7IazUnJ16ABaYtOi2HmWCYxQgL22S4CvYbnVznfq9k01eF0KXNAeMtDT91RpwHsj62WDf3y7j39Ecwzot1j/cN1PC1U8KjAvmbx0ZtVzDVFLgwezOoWD/a7O3ah912aO5f0aicB268K8oaMb9yZdAoqXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782925067; c=relaxed/simple; bh=6PGejTPeLLDG8hx6vm4TtHzVTfDxsv9weETSNmwDudM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AJLuq7s37sFIMBSMyOIKh9lh9ZwCEfeYFGDFuLI7Ae/eT2BD6Vg6oy0CEprlA9Jm/PLzSIWDORin4SRIG4Yte8CE4U/OHJORF262nFgKWTlERqC9bBGhYcogRyJUCX5rXsTkc7capBHgJxGFT8WppPL8580DLfjvmsONlERuuxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=Xc1Nsy3v; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="Xc1Nsy3v" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 6E7C040E00C0; Wed, 1 Jul 2026 16:57:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id eZNWrhC4CrjC; Wed, 1 Jul 2026 16:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1782925048; bh=D7Ux8SvwXgyrbJIRqj3C7tDh9Pxj7i8inIMKgMzpWiU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xc1Nsy3vHp6PaNdjT+jQ70baAzX4p0TzIG/CZnSa4VJvncqiqcWp8r00M2QgYVYj1 Hq+WWl7zy0kCyJ6ET9ynDbm5VBGFYZBbuYgEqWeUtCKtzcSjtc+XFomqX+4EvX6J7f eGEKuKXSpYqmcp5/B6tDriB7INwwiTDgTlvcj5oC7HO29LhN6KwhhZN857Hnu3ANsn 3EZCFSgsT009K+Cd0akgIRBS2y1BbiBZabaIitPRlR7z0l1Xcs3LrbIc1kA7gXUGew VEO7PMQ7Y/ICPpKWQcmPPoOk+r0nbmWlolymnaiNIQxC0k09VsJWUi4xJblCr7/zDl 3cCOipvEK7p0b9ajEE6czHcij8cI/TgXvxxVLRkWPfZaAUYVRT0v3DOqLHY84hOUIn pRP7A3bVIqg1bzfurbYh6tl2l7Ooov5xKq1565GYLV/lFTv0ok7J0ZvLoYifnLc8EK uF7DfYqHbh6q4m6yJpse5NSjExhBV1qa6XEEz1mg1JQcRMSZ9hrJeu4QRRrZjnMyJ0 w4nqXOA/uLEiNuwUo3+r9DCsAb+P7ZCpA3o8RPMvBHRFZah2zwWwEy5G/M58Zc+4Em JoJX4xpoRceA5lj13t5Fpp7kkMSb4wBdpKhys5PayFjiyfP+SPmOwhNpZk7dhgV7D4 ET6HPJNim2jox8ei73kXaqys= Received: from stx.tnic (unknown [IPv6:2600:1700:38ca:c00::1a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6DF9C40E01B4; Wed, 1 Jul 2026 16:57:17 +0000 (UTC) Date: Wed, 1 Jul 2026 09:57:14 -0700 From: Borislav Petkov To: Pratyush Yadav Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Pasha Tatashin , Mike Rapoport , linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH] x86/setup: do not include kexec_handover.h from asm/setup.h Message-ID: <20260701165714.GAakVG6p191JTJ0nJS@fat_crate.local> References: <20260701151536.3068791-1-pratyush@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260701151536.3068791-1-pratyush@kernel.org> On Wed, Jul 01, 2026 at 05:15:33PM +0200, Pratyush Yadav wrote: > From: "Pratyush Yadav (Google)" > > x86 asm/setup.h includes linux/kexec_handover.h. This is because it is > used by setup.c and kaslr.c. But this inclusion is problematic. The > header is included in many places, so it results in the KHO header being > propagated there. Also, the setup header is used by realmode code. If > KHO header includes things like mm.h, it causes a big dump of > compliation failures. This is exactly why we are trying hard to block people from using more linux/ namespace headers in the decompressor code. Please split it and put only the bits that are needed by the decompressor into a header in arch/x86/include/asm/shared/ and use that in the decompressor. There are examples there. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette