From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BF80431E68 for ; Wed, 1 Jul 2026 20:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782938829; cv=none; b=Ra3DlfzyXSmBU0ufWJVrnH5Fo/P6KW1EE+vGBTyGoLML2DiOj0ZnImNzUdxK4h3eJVhnfEK0aAqrkIDTRQoCgcUUlXM2OGzg3RQjxGDi2uRx2DL5hOD6JrCt1nbcEkot3hIz7eTrQVRW097V3FrO+L99wh0pC2pOzWX4IssLRfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782938829; c=relaxed/simple; bh=vELs9u5VOAbmW1e3Cfx2GxddH4WvNUaBwf0SQbMS4C0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BX/GRN12Fjx+NiYGxAdrIULixV/JFNqtmGKIfIePEIxb7ZkvI9bL049C4yGd8ShGVZkMvQtSTL+D+lJpJ+hsBbIQ4nmZ2Xrul5fxFCqtjoE1OORgBbhv5yQrIX8kr59DUAvlhIRmU9d4awgVbqWyZrUVUMyjN9OHs9jIYrYHue4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=C7MVCdKI; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="C7MVCdKI" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 64F4D40E00C0; Wed, 1 Jul 2026 20:47:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ADSUZm13yOCQ; Wed, 1 Jul 2026 20:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1782938816; bh=9DZRvVZl98blze4dH738SldPTBajzvNlA9enkx5HNIY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C7MVCdKIQwJBnVfm7mPnS8PAwg8Y1NoZYuHElYGyAKM7fc+mxdWybKjpHwB8Mzpj7 KclOVs3gcHxvdMHsPAj8iH8SNPTWp7B0Vhab9XIHYE6emHehyMKHFp55OoI6O4whFN dZuVNgXvXHKj44a71aB1w2P2jj5RnKtz8T7bn6+qI2mIxTwc7Z6xlCDax5fC8pvB+v 2AjPuYATyrrM16xtVMFNfMedmTu1U3JSRkUc08UTlOIzC85dGDcZvdWRpQhaQevBUp Edy6Wpp7pSCohtn8TKAmSbm6+pLcyCp483eA4gItw992xn/7LkY/zhZ4qnCpaF2hfP j4TmDGAeHfgAYuUhcpHQFh9MplY5RHZKFVbjriD26bmvJqrIk1w4xEQgpwhOEId496 uAhlywQXu0lqi90BD+wQsFC8Mt+RwsVUPLQf1OiDxNAzTHUse2qefnINugWPLcA5wG mbUWK27MIqklxtgx/t/3EbeQgPVgOZHhye2doLhUjIGapdertqDCuHDj05D5NLhqHr mIbu4r68mDwYkBwBfv49iqHCCHUdYXDMdGSJHeEQzK47bM5VghW1cGgdep/P2JmfnR Rbd1lOVSWh7c904tEBDe0W4Mtv4jWb4uFGzXbkuasAvAAEs7tJluKPHfayUcPIgDEr dZ2b9K7+94deC1hVIAG0ZPjk= Received: from stx.tnic (unknown [IPv6:2600:1700:38ca:c00::1a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C4B3E40E00BA; Wed, 1 Jul 2026 20:46:43 +0000 (UTC) Date: Wed, 1 Jul 2026 13:46:40 -0700 From: Borislav Petkov To: Mauricio Faria de Oliveira Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH RESEND v5 1/3] x86/asm, x86/boot: expose inline memcmp Message-ID: <20260701204640.GDakV8sOK1cu-0P4Bc@fat_crate.local> References: <20260630-pvh-kasan-inline-v5-0-52afc979be81@igalia.com> <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> <20260701184014.GDakVfDhIgaIKurzTb@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Wed, Jul 01, 2026 at 04:57:57PM -0300, Mauricio Faria de Oliveira wrote: > I'm not sure, as Reported-by and Suggested-by mean something different. > > Maybe a simpler statement would do? e.g., '(Thanks to David Laight for > noticing the return value difference between inline and regular > memcmp())'. That gives credit while avoiding confusion with tags. The Link tag already points to the review thread where we document who suggested what. We don't document who gave what review comments and suggestions for the simple reason that that would be intractable and the other simple reason is that they don't belong in the commit message. Changelog comments belong *exactly* under the "---" line. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette