From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90F623E8C70 for ; Thu, 2 Jul 2026 10:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782989819; cv=none; b=WytYt0su4KtWsI2JF7s9wPiZyuo1K/opEmltlslqv0h549WawaTuuF3+6VCC5qrIHS9efuMhIDvLw+4ah4f2sskDM/O19Sx+sJFIDVIxU3JicLd7jaifCeeOKAqWfVVOM950TLjrtRA2VECNTAJEuMyVDL149F5G8kF6Io0laME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782989819; c=relaxed/simple; bh=4RUGcMFAUmz4WZn+oUeIShFgv+Faz7ysyRFbheUvpog=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rKb1sOkXvkpKpY4ICcy5gv18QNAUhp1Nbn8RHze8QJt9lb/GixE9dD6x50ySWzclNqw3pOZuSVJx7nJgKFDzeOOE19HEGuslBUBVOQZ2FpVPdq1qW51c3Qb0xSJL3u0F39Luk2Dif4Ap9skJ7RDDC5z5ruXuamzsXdNEQPFJhvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Jpo+ZAJ8; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Jpo+ZAJ8" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-493c19bad03so13438035e9.2 for ; Thu, 02 Jul 2026 03:56:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782989816; x=1783594616; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hgDVuxY1KD6XzliacX6/nWGKC8dFyYuIdBWxcG4BfyI=; b=Jpo+ZAJ8J0ohAOznIpjaJx9QapLTTz9WSbfw0aAK4pl3kRzertMCwyZCvKk3ioYfPN v/CYy060g9IHd+bRfZ97K1Qaa4WIjN7XS6rjV/9z0S6vK4meqWmYo1waSi/YW+CBEvlg fKhLm45vVJammtWtnLUMiPIbU/jIz6tYLxAbXWkYHC0UN3UOPrKPrAql/unAKcF6VmJp /kaGXi90anAFreopJFN1FSYbNVUfkctMtvRtejzFClUSy9lG7RQgQxG9Vh1Qwm4RibUC Ul57cqfRamBiTwfdaWJ1t2estSM+/yP9iioe+QjJID5I5Ih3W6k2N53X25GmcRyvGAvh BJTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782989816; x=1783594616; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hgDVuxY1KD6XzliacX6/nWGKC8dFyYuIdBWxcG4BfyI=; b=UWCNn7MVqnxfNwu9pbYa9YEDM7djmCxngzuFSvYVe/IV2mc63u7oGVdhkMZeDa0xF/ bvxFRlQrckL9vpSXv5DBcCPxWzbiI/9Ein2BmqQUPkMdFdJ9JETQPxoRv+6Npsz7mwqw 640FgA+91yCMZ+5RFm73T2Tc8d7wQqNpf6ToOhlOniKKtPbsGJG5QsYaTyC2LDU5qKfN BwpPXtZQawUWxEjIrXMUtrYBPyF7gjdv7E3nbeoWfMnxejyr3LS1mvNpPE6isU4ItL7w JouwZagZ1k+PKLqp/pSOC/PAffVBtQ2E+I63aTkG4cJQcguaFVDZerPGt0p/n5i+xIQs 7B4Q== X-Forwarded-Encrypted: i=1; AFNElJ9hl5AS8E0l8/3UwcypqL6oQ0mXMEjdd5K2kViRv3ceHwfpAw1FAk02Yh+h5s9SKYnGJF6wd8Rw89Jta44=@vger.kernel.org X-Gm-Message-State: AOJu0YyKTNXdZ/J8SZVwu18ppTO4drJQrl3qr6oeTNsokwpCzZUt2gtX 57Ws6Wyhr8+83fGLKcTTXAt6vwWFw3vg5OWTllzXEK8HANNm0jLdaGdifzOH6KY4I6Y= X-Gm-Gg: AfdE7clWleyH8JUp4cwWmxVzl94sN9WTUtx/afxzdpkD/lT5AAGa2Tyy0R5PEXQgKZf jht+shIx9e5zacvYbgxpaWw+h6dIwizd3Ze2pZR5qVD1lgyZFJeXA1vM06BMXNaPmPUbgy/ldu5 SvXgKMweVAkBycmJlactDl1wcsgFS62rpTlH9huG976DzA3uFm+4z+X7exG9anueXDYFSlxmgg/ L8fhrGADKGaxW2jgtYcrcwsdVFQiNWG4IkMEW8bonyTV1N3BUnS3S4PJ1/bruf7U3HpKirjF3Vl X1VSQc0fVESBK1ctD1dt17KATNhUA6gAqWSD/YK3VlLsLMhjVnJbU0c+Cxsf0NBn+kAh3kttrDg J6faZw/zxG3uVu59wsgHlsJswd9lJRYGJASvVmvJD96eFSqp6/lXRYKjQhs1LYiid51qgj4ZZ/X qEffhRRPkXwQ== X-Received: by 2002:a05:600c:c3cd:10b0:493:b7c8:6530 with SMTP id 5b1f17b1804b1-493c2b56d6dmr58237385e9.16.1782989816159; Thu, 02 Jul 2026 03:56:56 -0700 (PDT) Received: from [127.0.1.1] ([151.41.178.17]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c6372a31sm42649685e9.13.2026.07.02.03.56.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 03:56:55 -0700 (PDT) From: Valerio Setti Date: Thu, 02 Jul 2026 12:56:41 +0200 Subject: [PATCH 2/2] ASoC: meson: aiu-formatter: remove pipeline reset from prepare Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260702-fix-24-bit-i2s-playback-v1-2-bcd3a43fe32a@baylibre.com> References: <20260702-fix-24-bit-i2s-playback-v1-0-bcd3a43fe32a@baylibre.com> In-Reply-To: <20260702-fix-24-bit-i2s-playback-v1-0-bcd3a43fe32a@baylibre.com> To: Jerome Brunet , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl Cc: linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Valerio Setti X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1340; i=vsetti@baylibre.com; h=from:subject:message-id; bh=4RUGcMFAUmz4WZn+oUeIShFgv+Faz7ysyRFbheUvpog=; b=kA0DAAoW3kuTbdE6AQAByyZiAGpGQ/Sgr43tFvQDLVWfktUEH2N4EZ4yRZb+Gfs4KRffN0R+h 4h1BAAWCgAdFiEEBJfe+3B1JuEzYMlw3kuTbdE6AQAFAmpGQ/QACgkQ3kuTbdE6AQD5mAD/Qntp SFISL2mv7knxonSk71KphYdR6KENd59KnmN+luUBAP3VB++RaKUjr3VxQ0tqKnyc3ANTCrvX31+ XLiMN8doF X-Developer-Key: i=vsetti@baylibre.com; a=openpgp; fpr=0497DEFB707526E13360C970DE4B936DD13A0100 'aiu-formatter-i2s' already performs the very same reset in 'aiu_fifo_i2s_trigger' for all relevant trigger scenarios. There is no need to duplicate the operation in the formatter. Signed-off-by: Valerio Setti --- sound/soc/meson/aiu-formatter-i2s.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sound/soc/meson/aiu-formatter-i2s.c b/sound/soc/meson/aiu-formatter-i2s.c index b4604734fe88..cb554c2e7ce4 100644 --- a/sound/soc/meson/aiu-formatter-i2s.c +++ b/sound/soc/meson/aiu-formatter-i2s.c @@ -13,7 +13,6 @@ #define AIU_I2S_SOURCE_DESC_MODE_8CH BIT(0) #define AIU_I2S_SOURCE_DESC_MODE_24BIT BIT(5) #define AIU_I2S_SOURCE_DESC_MODE_32BIT BIT(9) -#define AIU_RST_SOFT_I2S_FAST BIT(0) #define AIU_I2S_DAC_CFG_MSB_FIRST BIT(2) @@ -55,11 +54,11 @@ static int aiu_formatter_i2s_prepare(struct regmap *map, { /* Always operate in split (classic interleaved) mode */ unsigned int desc = 0; - unsigned int tmp; - /* Reset required to update the pipeline */ - regmap_write(map, AIU_RST_SOFT, AIU_RST_SOFT_I2S_FAST); - regmap_read(map, AIU_I2S_SYNC, &tmp); + /* + * Pipeline reset is already implemented in aiu_fifo_i2s_trigger() at + * trigger time. + */ switch (ts->physical_width) { case 16: /* Nothing to do */ -- 2.47.3