Re: [PATCH 2/8] dt-bindings: mfd: ROHM BD73800 PMIC

[Krzysztof Kozlowski <krzk@kernel.org>]

On Wed, Jul 01, 2026 at 03:41:34PM +0300, Matti Vaittinen wrote:
> +description:
> +  BD73800GW is a single-chip power management IC for battery-powered
> +  portable devices. It integrates 8 buck converters, 4 LDOs and a current
> +  sense amplifier with ADC. Also included is a Real Time Clock (RTC) and a
> +  32.768 kHz clock gate. Depending on the OTP configuration the BD73800
> +  may also have interrupt controller and GPIOs.
> +
> +  There are also different variants called BD71851 and BD71885 which are
> +  almost identical from the software point of view.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: rohm,bd73800
> +
> +      - items:
> +          - const: rohm,bd71851
> +          - const: rohm,bd73800
> +
> +      - items:
> +          - const: rohm,bd71885

items:
  - enum:
      -
      -
  - const: rohm,bd73800

> +          - const: rohm,bd73800
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  # The GPIO1, CLKOUT (GPIO2), FAULT_B and EXTEN_OUT pins can be
> +  # configured to interrupt pins by OTP.
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 1
> +    description:
> +      The IRQ number. 0 is GPIO1, 1 CLKOUT (GPIO2), 2 FAULT_B and 3 EXTEN_OUT.
> +      NOTE, A pin can operate as IRQ source only when the OTP
> +      configuration for it has been set to GPI.
> +
> +  gpio-controller: true
> +
> +  "#gpio-cells":
> +    const: 2
> +
> +# The GPIO1, CLKOUT, FAULT_B and EXTEN_OUT pins may be configured for a

Missing two spaces (indent) before the comment, although this should be
put into description. I understand it applies to each description - it
is fine to add to the first one. Descriptions might be used to generate
user-friendly representation of bindings (PDF). Comments won't, so
comments are only to explain the binding/schema syntax choices.

> +# specific purpose (like ADC input, 32.768 clk output, fault indicator or
> +# delivering power sequence to a companion PMIC when multiple PMICs are
> +# used) - but also to be either a GPO or GPI. (When used as a GPI the pin
> +# can also be used as an IRQ source). The pin purpose is determined by
> +# OTP (One Time Programmable memory), typically during device manufacturing.
> +# The OTP can't be read at runtime so device-tree should describe the pins.
> +  rohm,pin-gpio1:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      Indicate if the GPIO1 pin has been set to GPI or GPO at manufacturing.
> +    enum: [gpi, gpo]
> +
> +  rohm,pin-clkout:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      Indicate if the CLKOUT pin has been set to GPI or GPO at manufacturing.
> +    enum: [gpi, gpo]
> +
> +  rohm,pin-fault-b:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      Indicate if the FAULT_B pin has been set to GPI or GPO at manufacturing.
> +    enum: [gpi, gpo]
> +
> +  rohm,pin-exten:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      Indicate if the EXTEN_OUT pin has been set to GPI or GPO at
> +      manufacturing.
> +    enum: [gpi, gpo]
> +
> +  # The CLKOUT pin may have its purpose overridden by OTP configuration. It is
> +  # possible the BD73800 does not output a clock signal. Hence the optional clk
> +  # properties.

Same here

items:
  - description: foo bar

> +  clocks:
> +    maxItems: 1
> +
> +  "#clock-cells":
> +    const: 0
> +
> +  clock-output-names:
> +    const: bd73800-32k-out

If this is fixed, then drop clock-output-names. Otherwise should be just
maxItems: 1


> +
> +  rohm,clkout-open-drain:
> +    description: clk32kout mode. Set to 1 for "open-drain" or 0 for "cmos".
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 1

Best regards,
Krzysztof