From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A00D439021A for ; Thu, 2 Jul 2026 07:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782975990; cv=none; b=FfKPIu4+rf4HYnqovUcDlkwvrRauDtIRMIDlsaDzeFmUQHpAh3R3wLzFDqF02T7C9v0/9wpq8SJ6bP0PeDii7un8n7JAEqfe1WISLADZ/M+h+kQOAuBe6S7sx07Vtt6S9K7OFXqEOUDR1sjajSZwgyuqKbJOp7a4QS58GMxpkIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782975990; c=relaxed/simple; bh=S3WGUr8EbUDnzRnDQdiXuU7JQ5VvK/xEqOqJ6Y6XO6c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aAMnmZya+qlWIwF41u1hK87GyDRGKunl7SbicpqLX5NBgVn3Zj/TnGDSl9r2+3l2haKlFxgYnpzSEvUuxH7/zqJDIOovgwlEwxZdMWqxdNcBTcOwQ/eohZbgW+U2BgKb1mV/XrmOF/zMyy7pkKR8XYGEQsakpxaEuK1rGymZluM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cuSmWjCT; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cuSmWjCT" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2c9d87b1f9eso14254715ad.3 for ; Thu, 02 Jul 2026 00:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782975988; x=1783580788; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TXokKAA+ArLkoRHycPsFI7+9fMpYzVXji7Up+eouGtM=; b=cuSmWjCTf/kNavsWd8nVKfcTjiiS8lRodzDmkZoC2mSOEtOuhNA4eHE3Q7Jd1aB5Lt hqTI1TuvnWwY0hY+SVjfu2eBaJapV5fX9npyu22MP4+CmdHoFpBW7tE14y/wF8OlMiCi 89A+irj8xabpdynW1a1l3iP93/iZU3IRIHomqg8JngaLbX7FTfCtmLuEoOCPbXbIvrg2 lvq8wdr+fKnlvxFulkD5EFlrNIo4MgPlYdNGR9EukQbSkJV0XsJpDkdepVyEg3KrGo3V UkrE9rO5mLP8nY4yBW6v7afLdpIEXl+YJUma5gjFwB2bCCQ3AuyFav5330iIfsDy2Svm oR8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782975988; x=1783580788; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TXokKAA+ArLkoRHycPsFI7+9fMpYzVXji7Up+eouGtM=; b=awxrmiSkTBbOt20McRCmaKS3PE2EereeegZ8rFgUt4fw0vGsy+VXppjRQURupyzAEt YALifnE4rwjMS+EW7yMy5/72cQHuJaszWyrIqIqRlMiTOYpvplhEjEv9qrmAcWWqvsTp VYDxawaNqME6TdIPMRaKUqUHD68F+g6W0NhQhcmxw9S/h5jRQ58Anss7qQVMhWuGcLVM ouviv/xm6DHXu4d8SMIFdbxTRseXFvK5+hYZu+DT3GOXcHJs7kDv4HFGpG4Et4sO5E8Y dH3MP+xYYnzEJzAwFx0poq6rgpl746NF29taa2iAH1U2ykEej3kjKjFki2OQ8NZNmD3B lPlA== X-Forwarded-Encrypted: i=1; AHgh+RrBAXleFiLSbh1CCOVnYkSxAhV/VOqrwlfrC2mqWO2NXpgYPrYF+o8gK317sksI0L57zMzNbu8VRHE23hI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh7bZxEELyqd/oNh69oryh9lkIk4zYBIAJO0LBCrjTX03ZYwC4 YeT2q+MjNGiuKjSP8vYWsGqllcs8YLpJ8j5szjlfza4jij9Kswcu0BEy X-Gm-Gg: AfdE7ckr++RWprJnglfVQHg9jUWNhMGSnmn5cs0UUMSEHsRwnYYNyT7WJy2xW4qwF6Q WBzwxfqMVPVMZvm6X/LPCITYo6sBZzCyqp2bwD+NN6jp3uZLSOeXLTM/LO2WfYUSo7S8OIKXAF2 OkBnPXJtDu1Rx3HZDBDaslDGvcm0HJnsKexkZcD5TfChCdiXhooD60e3hVTDvxASUaMtxdeE9Ex cLQh99W29B4OAois5Mf1QHX64GH3tmu9NeYJxc3sVt12jlbYCrJKkx9aFygKDiAcC1Xpl0MUyJc CjF0mKmb7EUrEXMjtbermbpe4gpAE64gI2Sau7QJarLw+iw/jUpifSp8M0LcJ69GPZoGH3K7kPS P/gea5G/2ymS5WeA5lU/8lu5lP9PvTOfwC9oobd55T1HAfGRItvAcPAOBeVbhPL4HpgIiC6idAe L+Uw2xK2OVi5DNQIr8M+S+J3ui/fbTmfVDRyTWFay2X0w+0CmVDxY6m+aFXo3L7v/T4SwnLLohj wdgCaCdQWo= X-Received: by 2002:a17:903:4b07:b0:2c9:97a7:3286 with SMTP id d9443c01a7336-2ca7e885535mr52880375ad.40.1782975987679; Thu, 02 Jul 2026 00:06:27 -0700 (PDT) Received: from [192.168.1.45] ([45.64.226.42]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca9a9124f2sm8865035ad.33.2026.07.02.00.06.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 00:06:27 -0700 (PDT) From: Prashant Rahul Date: Thu, 02 Jul 2026 12:36:15 +0530 Subject: [PATCH v2 2/4] staging: octeon: Propagate rx initialization failures Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260702-staging-driver-octeon-panic-v2-2-2c2b6ae086dd@gmail.com> References: <20260702-staging-driver-octeon-panic-v2-0-2c2b6ae086dd@gmail.com> In-Reply-To: <20260702-staging-driver-octeon-panic-v2-0-2c2b6ae086dd@gmail.com> To: Greg Kroah-Hartman Cc: Shuah Khan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Klara Modin , Prashant Rahul X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2879; i=prashantrahul23@gmail.com; h=from:subject:message-id; bh=S3WGUr8EbUDnzRnDQdiXuU7JQ5VvK/xEqOqJ6Y6XO6c=; b=owEBbQKS/ZANAwAKAWw+kajX8DhtAcsmYgBqRg3pKPU/Eb7ha/Pj0JtgokCQ0htEd2WYP+cJm INWyTzTf1GJAjMEAAEKAB0WIQRS5esR6MP3hQs0SsxsPpGo1/A4bQUCakYN6QAKCRBsPpGo1/A4 bbkWEACF9T61MrDL0qHo18dU43ZLlyKdH0M4K5IFECvTmRs8ZqfPM2SyrwcLNj1Pej04WPHrzNy zf+134eVcNrdJhu6xT2C7sN3WhswLLje734BmImWOZzzEUwI2aqIFPcal841Ne5nTBjZuwQt4BS FIjKs/KvJbYbVxMsWGzNOVpLq2DvvC4TxzraHA3f+CWj+zZ6mezniMIMke2cB75zCPVatGdsXO1 W/FnKKsqhYmgiztyY0unCiPbuh+gRyY7k9UwR5L8iOjEuHi78PAOXHvrC06zqkKnwjlXtrcaulq riLqEKpR0WBtXVovKsjvvjE73w64e6sS8Z1dYE96D8WO92UcMxWduJNyaCLRuFgNt27zzvuZRpE I7yjRx4qZMN/fOWFrEVn0Qyl7P3+eVYMDRPho/Cm5BSV43ftfAC7tri+hGtjnXrDZssGrp1fkhH wSyWy3HTZpBal0qcOrqVYvrJfNZYd8ZGjIqppkxMwOLCInh854FeSh+O22g7FkOzIarR/Px66Ye mc9FQKfXjBMzZYHBtckIa59VU8qp5re+wvpxl5Zcl1BDYhSR89/YOrQkUCiwVqS6Jt5mSDfzVQ5 WDXbG4JuYHrC7l6HVEUa9Id/qpWvQvpjmkK/pzrR+m3mgbbRKj3FL5j8zuVQanVQJCz0jQ5zT3i KG3sr+mVHFNsvrA== X-Developer-Key: i=prashantrahul23@gmail.com; a=openpgp; fpr=52E5EB11E8C3F7850B344ACC6C3E91A8D7F0386D Instead of calling panic(), log and propagate the error upwards for better error handling. Signed-off-by: Prashant Rahul --- drivers/staging/octeon/ethernet-rx.c | 18 ++++++++++++------ drivers/staging/octeon/ethernet-rx.h | 2 +- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index cd36b5ba6f6c2..66e7253d484de 100644 --- a/drivers/staging/octeon/ethernet-rx.c +++ b/drivers/staging/octeon/ethernet-rx.c @@ -5,6 +5,8 @@ * Copyright (c) 2003-2010 Cavium Networks */ +#include +#include #include #include #include @@ -445,22 +447,24 @@ void cvm_oct_poll_controller(struct net_device *dev) } #endif -void cvm_oct_rx_initialize(struct platform_device *pdev) +int cvm_oct_rx_initialize(struct platform_device *pdev) { int i; struct net_device *dev_for_napi = NULL; struct octeon_ethernet_platform *plat = platform_get_drvdata(pdev); struct oct_rx_group *rx_group = plat->rx_group; for (i = 0; i < TOTAL_NUMBER_OF_PORTS; i++) { if (cvm_oct_device[i]) { dev_for_napi = cvm_oct_device[i]; break; } } - if (!dev_for_napi) - panic("No net_devices were allocated."); + if (!dev_for_napi) { + dev_err(&pdev->dev, "No net_devices were allocated."); + return -ENODEV; + } for (i = 0; i < ARRAY_SIZE(plat->rx_group); i++) { int ret; @@ -479,9 +483,10 @@ void cvm_oct_rx_initialize(struct platform_device *pdev) /* Register an IRQ handler to receive POW interrupts */ ret = request_irq(rx_group[i].irq, cvm_oct_do_interrupt, 0, "Ethernet", &rx_group[i].napi); - if (ret) - panic("Could not acquire Ethernet IRQ %d\n", - rx_group[i].irq); + if (ret) { + dev_err(&pdev->dev, "Could not acquire Ethernet IRQ %d\n", rx_group[i].irq); + return ret; + } disable_irq_nosync(rx_group[i].irq); @@ -518,6 +523,7 @@ void cvm_oct_rx_initialize(struct platform_device *pdev) napi_schedule(&rx_group[i].napi); } atomic_inc(&oct_rx_ready); + return 0; } void cvm_oct_rx_shutdown(struct platform_device *pdev) diff --git a/drivers/staging/octeon/ethernet-rx.h b/drivers/staging/octeon/ethernet-rx.h index 6093694326cb6..ff3ed3d784a4b 100644 --- a/drivers/staging/octeon/ethernet-rx.h +++ b/drivers/staging/octeon/ethernet-rx.h @@ -8,7 +8,7 @@ struct platform_device; void cvm_oct_poll_controller(struct net_device *dev); -void cvm_oct_rx_initialize(struct platform_device *pdev); +int cvm_oct_rx_initialize(struct platform_device *pdev); void cvm_oct_rx_shutdown(struct platform_device *pdev); static inline void cvm_oct_rx_refill_pool(struct platform_device *pdev, -- 2.54.0