From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00572390212 for ; Thu, 2 Jul 2026 07:06:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782975999; cv=none; b=RR622zF1aVHp/DvPjZaCa5bFwKpXg2cKOm3HAy0cvNr8B1aUVreQjBPYDatnq5XpGgC+v9QEk+uqm48S60UTHgS/uPm60UNNsuToEaSFtyp9EfNQJEr3Cr0pYZEgNSyDXh7mUO3T/cHeMCaw8OxmwVVVybPTfM0l1ilfORVC/WM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782975999; c=relaxed/simple; bh=qwCY0nFaOJCUvrmLvadCEv+mpvx7nZJWCKGrLiomDdU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TY8LU3oyXpcaN+rmNxz6CbD5Sn/u4IUO3pNAG2ieGZjfXlvbdTcCJub7ShFPvfObr+AkLdSKUcADyh2+4UwcekktmCICiXmU1v4tE0HgJY/KnaWspy+HarP0jBfbN2pIqVqNdzklBHeF7Dm98kebzhqPDnIW87TAUI/DByzkGc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KWbNFCko; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KWbNFCko" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ca64989e64so13155735ad.2 for ; Thu, 02 Jul 2026 00:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782975995; x=1783580795; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4qLH8TGZ+WUlwfUH/GXvctqR+GIWLJhWorLHDQ/+QDc=; b=KWbNFCkoBbKPGWOmsk4Aip3kalTMjmvXsg6cE50MIJIb/JLpl2RLHb4akecbaJFVcD DbwpUFwB2n5+hzGHQIFkOsl2XTmfpzuj9hJenEpM791/tBh2HSYMd/LDwhKI7abK1Mj8 KybbU6BojBgI7v1fAKF96+BdjC8p+nBlI6l3RlL0Ew6uOuaHjS2gV83vITxBf6UkfJb5 o8e/M+FVaygg9UaNx8ezelDIq5J5Vix6mb4g+yjBiI3iwJq6zkIJ+AEN3IiDTduY3pVX LLAxpKZWYsPhVpaQ3oiY5RF1cZvQoe/njSYnueDLjpCJA/umvN5LrRyBKGOtdJ/i4p5u VJQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782975995; x=1783580795; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4qLH8TGZ+WUlwfUH/GXvctqR+GIWLJhWorLHDQ/+QDc=; b=KQ0KnP3r18ZryohcqvnOWc0CPBUp8smvWGj2fOgV82eFa2LLxvFqkV4jxEXMI50FFh TSobGISFzqBoOgTJzmKSdeOBUbOQkHbVIR3ec/vQYK+Fs3MYaa298BuoJkFH+A/9T1T8 JTZzpKLT6KF/LYXLVFS53GdyrigSFZlgMIuC3nR1mVv+NFhKi8h7zpWwHNE9ElSBitL1 o0pOsfcDnWBaJLMzA0VWy8vhCYjMYkuXyuEz+vqSQnlWBzIvqXAHcdxUGRRLzqX01Q/8 Z+163BHCXqsb6smOGXMHzCKiVbQ1+jNXZugyVhMj1cjJG+FKR69MHBcBBH2HiuP8vtkl nrJA== X-Forwarded-Encrypted: i=1; AHgh+Rq5RPHCA0FabVZLle8xuxX9aywYAIj888KzISchvUWskxDeVi9ggIEnDdYR+zWOqat+y/lhW5dfnYmz8IY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2kNB0sQfclVwComUOap+zFUnYGA5HYWUXWC7pTpdyrvPhdRXf ZoiUw4z+5+zyKZ1H91zSXxL902uPCBwNTXQZw38PfLdQ7Evr0AkRUpix X-Gm-Gg: AfdE7cmWhgbdU4TvYyk4KQluHP+2urw37mxnaFw939tzjPD0g+TKCuMu4SgKg14m7AN 11AFo+T7yOjTyMXQZbhGvuHoiS2XV03sRgn7yc1vFVDIBsN4INXaIu3DjuekIOgqq3Eb4gFKY02 5BsEdzTp2eu1q//bZUwgWB90GUP1A4WFQt1DWkA+4Rw0+xKJBYTEEQ5k0uD9ptpO4v6g9Cth2KC RSSHYVfOMtk7gVRGZ+lqJLY+mdPA+575jLT0zQWq19FRi+2Ri98KfxDuQO+/ENyMZqgu67O4R4F o7kuWueh1anuKVYAHM0llLLMvgqdip8z4LMNSXV1MuVZ5eAz07l8UBdtR96pwtMIncpTTP4x9Kk Ku+Yzb70qqdUzbZbuGxZLC/F/Scwv5nQts+A9yM8M1kFWWia8Wk5fhANT7t3rsuShpOX+51krjN 2ah0jhEZm3d/pb6GWnu853kUgD30aTuihtT9dZdIilujXcSvK8rZJ5ojoGzpbncHHEUuKktXkvX z3QMln2NJ0= X-Received: by 2002:a17:902:d490:b0:2c9:fa37:c666 with SMTP id d9443c01a7336-2ca7e8cbd87mr46648105ad.44.1782975994973; Thu, 02 Jul 2026 00:06:34 -0700 (PDT) Received: from [192.168.1.45] ([45.64.226.42]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca9a9124f2sm8865035ad.33.2026.07.02.00.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 00:06:34 -0700 (PDT) From: Prashant Rahul Date: Thu, 02 Jul 2026 12:36:17 +0530 Subject: [PATCH v2 4/4] staging: octeon: handle rx/tx initialization failures in probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260702-staging-driver-octeon-panic-v2-4-2c2b6ae086dd@gmail.com> References: <20260702-staging-driver-octeon-panic-v2-0-2c2b6ae086dd@gmail.com> In-Reply-To: <20260702-staging-driver-octeon-panic-v2-0-2c2b6ae086dd@gmail.com> To: Greg Kroah-Hartman Cc: Shuah Khan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Klara Modin , Prashant Rahul X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2139; i=prashantrahul23@gmail.com; h=from:subject:message-id; bh=qwCY0nFaOJCUvrmLvadCEv+mpvx7nZJWCKGrLiomDdU=; b=owEBbQKS/ZANAwAKAWw+kajX8DhtAcsmYgBqRg3pQ0F973YJeuqcWtpTNrj3CnK/+ILJkFIIJ Xsv+ApE3eSJAjMEAAEKAB0WIQRS5esR6MP3hQs0SsxsPpGo1/A4bQUCakYN6QAKCRBsPpGo1/A4 baD8EACwPLwOlwPPoNMCRbkJrGzhIVtMtC6CnufFYRxD3GeLHHeDZ6W0Ez3cvvLq9g8vCvvaNly l+2N8dImpk0V/7Nq3Ou3BLDo6c3Pptdvfb9wkStEgP9xxBMFrdrR6JTIVG9ZRZ5m69xnpqptk9u 1nFC8Mpbj2C5hljelZnvNpLiMg7tJzjMvkdTY5wLFAKUomxQ4+yyu1uG5usf2D7R73UGgs7xJh3 BbfOc7TAY1LV1uRFrtFKyxwf3Kw+JY01EqSXTYpw91W4XbqmfSx89dlgbLZrHHTGjGIZTADLdUo KPPi4gN+O9/bxMJuwwJKPSRdTrNWbQ/U1Bb07bxOtmhJNap5a8QB680DVt+Tl7sEPQEG9T2qFKR O8QI7zuVMj79OO8TfEZZaP3p7X47Cl1qux5WhwB5yzU0/7IwH9vFuH+MrfJp1UmkaeGPlaNKLMK gcx9cPaKxgdTMsXaCaDQaaXLTU5gDq7AOxxYcnug7ZuSrdz+5Tw3mFUafMmAw0FIYXM2TU+bvtA gCbA1lArBHOKuEjOjRYlPGPC64IJM9l7CqUJUAesWK7MTkNVQQoBIXk53k0YtiDQZ5cEg/vXnVl Ao73MX12/FbMUXAspcWC6gz7roneLMK7L1+yCmQukIS4POmLgh1Jdvmbw5Xez+b+rmb5mB5rbne 3urOhP8qRljmEEw== X-Developer-Key: i=prashantrahul23@gmail.com; a=openpgp; fpr=52E5EB11E8C3F7850B344ACC6C3E91A8D7F0386D Check return value of rx/tx initialization functions and abort probing if either one fails. Add error handling labels to deallocate resources before returning the error. Signed-off-by: Prashant Rahul --- drivers/staging/octeon/ethernet.c | 36 ++++++++++++++++++++++++++++++++++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index 56ea848187531..42ec4b8324a83 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -688,6 +688,7 @@ static int cvm_oct_probe(struct platform_device *pdev) { int num_interfaces; int interface; + int ret = 0; int fau = FAU_NUM_PACKET_BUFFERS_TO_FREE; int qos; struct device_node *pip; @@ -934,17 +935,48 @@ static int cvm_oct_probe(struct platform_device *pdev) } } - cvm_oct_tx_initialize(pdev); - cvm_oct_rx_initialize(pdev); + ret = cvm_oct_tx_initialize(pdev); + if (ret) + goto err_tx; + + ret = cvm_oct_rx_initialize(pdev); + if (ret) + goto err_rx; /* * 150 uS: about 10 1500-byte packets at 1GE. */ cvm_oct_tx_poll_interval = 150 * (octeon_get_clock_rate() / 1000000); schedule_delayed_work(&plat->rx_refill_work, HZ); return 0; + +err_rx: + cvm_oct_tx_shutdown(); +err_tx: + cvmx_ipd_disable(); + + atomic_inc_return(&cvm_oct_poll_queue_stopping); + + /* Free the ethernet devices */ + for (int port = 0; port < TOTAL_NUMBER_OF_PORTS; port++) + cvm_oct_remove_device(port); + + cvmx_pko_shutdown(); + + cvmx_ipd_free_ptr(); + + /* Free the HW pools */ + cvm_oct_mem_empty_fpa(pdev, CVMX_FPA_PACKET_POOL, CVMX_FPA_PACKET_POOL_SIZE, + num_packet_buffers); + cvm_oct_mem_empty_fpa(pdev, CVMX_FPA_WQE_POOL, CVMX_FPA_WQE_POOL_SIZE, + num_packet_buffers); + if (CVMX_FPA_OUTPUT_BUFFER_POOL != CVMX_FPA_PACKET_POOL) + cvm_oct_mem_empty_fpa(pdev, CVMX_FPA_OUTPUT_BUFFER_POOL, + CVMX_FPA_OUTPUT_BUFFER_POOL_SIZE, 128); + + return ret; } static void cvm_oct_remove(struct platform_device *pdev) -- 2.54.0